On 3/14/19 2:24 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
It looks good to me.
Just one minor suggestion:
http://cr.openjdk.java.net/~coleenp/2019/8220512.01/webrev/src/hotspot/share/classfile/metadataOnStackMark.cpp.udiff.html
- Threads::metadata_do(Metadata::mark_on_stack);
- CodeCa
Hi Coleen,
It looks good to me.
Just one minor suggestion:
http://cr.openjdk.java.net/~coleenp/2019/8220512.01/webrev/src/hotspot/share/classfile/metadataOnStackMark.cpp.udiff.html
-Threads::metadata_do(Metadata::mark_on_stack);
-CodeCache::
On Thu, 2019-03-14 at 13:58 -0400, Bob Vandette wrote:
> The change looks good. Thanks for fixing this.
Thanks for the review, Bob!
Cheers,
Severin
> I’d send this to core-libs (cc’d).
>
> Bob.
>
>
> > On Mar 14, 2019, at 12:51 PM, Severin Gehwolf
> > wrote:
> >
> > Hi,
> >
> > I'm not su
The change looks good. Thanks for fixing this.
I’d send this to core-libs (cc’d).
Bob.
> On Mar 14, 2019, at 12:51 PM, Severin Gehwolf wrote:
>
> Hi,
>
> I'm not sure what the right list for Metrics.java[1] is. Assuming it's
> serviceability-dev:
>
> Please review this one-liner for for Su
Summary: Walk ICs to determine whether nmethods are dependent on
redefined classes.
See bug for more details. Tested with redefinition tests:
#redefinition tests.
make test TEST=open/test/hotspot/jtreg/vmTestbase/nsk/jvmti >&jvmti.out
make test TEST=open/test/hotspot/jtreg/vmTestbase/nsk/jdi >
+1
On 3/14/19 10:24 AM, serguei.spit...@oracle.com wrote:
Okay.
Thanks,
Serguei
On 3/14/19 10:22, Gary Adams wrote:
This trivial changeset will restore setenabled003 testing to jdk 13
where the test does not appear to be failing.
The original bug JDK-8066993 will be left open in case sustain
Okay.
Thanks,
Serguei
On 3/14/19 10:22, Gary Adams wrote:
This trivial changeset will restore setenabled003 testing to jdk 13
where the test does not appear to be failing.
The original bug JDK-8066993 will be left open in case sustaining
team needs to apply changes in older releases.
diff --g
This trivial changeset will restore setenabled003 testing to jdk 13
where the test does not appear to be failing.
The original bug JDK-8066993 will be left open in case sustaining
team needs to apply changes in older releases.
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jtreg
Hi,
I'm not sure what the right list for Metrics.java[1] is. Assuming it's
serviceability-dev:
Please review this one-liner for for SubSystem.java which currently
behaves differently from the native implementation in
osContainer_linux.cpp. Please see the details in the bug.
Bug: https://bugs.ope
Hi Daniel,
On Thu, 2019-03-14 at 11:24 +, Daniel Fuchs wrote:
> Hi Severin,
>
> If you can update WAIT_FOR_JMX_AGENT_TIMEOUT_MS in
> JMXAgentInterfaceBinding.java
> to 2, in you webrev.04, then I believe you should
> be good to go and push the changes.
>
> This seems to fix the instabil
Hi Severin,
If you can update WAIT_FOR_JMX_AGENT_TIMEOUT_MS in
JMXAgentInterfaceBinding.java
to 2, in you webrev.04, then I believe you should
be good to go and push the changes.
This seems to fix the instability I had observed with
fastdebug VMs.
best regards,
-- daniel
On 12/03/2019
Thanks, Serguei!
StefanK
On 2019-03-12 22:50, serguei.spit...@oracle.com wrote:
Hi Stefan,
The fix looks good to me.
Testing the tiers 1-7 for different GC's has to be good enough.
Thanks,
Serguei
On 3/12/19 8:19 AM, Stefan Karlsson wrote:
Hi all,
Please review and/or comment on this chan
On 2019-03-14 10:21, Erik Helin wrote:
On 12 Mar 2019, at 16:19, Stefan Karlsson wrote:
Hi all,
Hey StefanK,
Please review and/or comment on this change to remove
CodeCache::scavenge_root_nmehods_do from
VM_HeapWalkOperation::collect_simple_roots.
http://cr.openjdk.java.net/~stefank/8
> On 12 Mar 2019, at 16:19, Stefan Karlsson wrote:
>
> Hi all,
Hey StefanK,
> Please review and/or comment on this change to remove
> CodeCache::scavenge_root_nmehods_do from
> VM_HeapWalkOperation::collect_simple_roots.
>
> http://cr.openjdk.java.net/~stefank/8220342/webrev.01/
I think thi
14 matches
Mail list logo
