Re: RFR(m): 8223306: Remove threads linked list (use ThreadsList's array in SA)

Hi Robbin, On 8/05/2019 7:20 pm, Robbin Ehn wrote: Correct links: http://cr.openjdk.java.net/~rehn/8223306/v2/webrev/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html So you removed all uses of lambda in that file ... okay src/jdk.hotspot.agent/share/classe

Re: RFR (S) 8223441: HeapMonitorStatArrayCorrectnessTest fails due to sampling determinism

Ok. Looks good then. Chris On 5/8/19 8:26 PM, Jean Christophe Beyler wrote: Yes and actually  the count variable too were missing due to a mishap when generating the webrev... I had this in my loca

Re: RFR (S): 8219023: Investigate syncing JVMTI spec version with JDK version

Hi Serguei, Changes look good. Can you verify that the .jtr file for com/sun/jdi tests has all the versions updated? For example, you will currently see: JVM version:13-ea JDI version: 11.0 JVM description: Java Debug Interface (Reference Implementation) version 11.0 Java Debug Wire Protocol

Re: RFR (S): 8219023: Investigate syncing JVMTI spec version with JDK version

Hi Serguei, On 9/05/2019 8:57 am, serguei.spit...@oracle.com wrote: Please, review a fix for the task:   https://bugs.openjdk.java.net/browse/JDK-8219023 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8219023-svc-version.1/ Summary:  By design as we have never bumped the JVMTI ve

Re: RFR (S) 8223441: HeapMonitorStatArrayCorrectnessTest fails due to sampling determinism

Hi JC, I don't see how this builds. You used to have:   78   double expected = maxIteration; Now  you have:   81 expected = maxIteration * count; And I don't see a declaration of "expected" anywhere.

RFR (S): 8219023: Investigate syncing JVMTI spec version with JDK version

Please, review a fix for the task:   https://bugs.openjdk.java.net/browse/JDK-8219023 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8219023-svc-version.1/ Summary:  By design as we have never bumped the JVMTI version unless  there were spec changes for that release. Now we want to s

Re: RFR: JDK-8223584 -Exclude javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java until JDK-8042215 is fixed

Thumbs up and trivial. Dan On 5/8/19 4:18 PM, gary.ad...@oracle.com wrote: Another trivial update to ProblemList an intermittent failing test. diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -567,6 +567,7 @@  j

RFR: JDK-8223584 -Exclude javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java until JDK-8042215 is fixed

Another trivial update to ProblemList an intermittent failing test. diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -567,6 +567,7 @@  java/lang/management/ThreadMXBean/AllThreadIds.java 8131745 generic-all  javax/

Re: RFR(m): 8223306: Remove threads linked list (use ThreadsList's array in SA)

On 5/8/19 5:20 AM, Robbin Ehn wrote: Correct links: http://cr.openjdk.java.net/~rehn/8223306/v2/webrev/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html http://cr.openjdk.java.net/~rehn/8223306/v2/inc/webrev/ http://cr.openjdk.java.net/~rehn/8223306/v2/webre

Re: RFR(m): 8223306: Remove threads linked list (use ThreadsList's array in SA)

Looks good to me. Coleen On 5/8/19 5:20 AM, Robbin Ehn wrote: Correct links: http://cr.openjdk.java.net/~rehn/8223306/v2/webrev/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html http://cr.openjdk.java.net/~rehn/8223306/v2/inc/webrev/ http://cr.openjdk.jav

RE: RFR 8223065: Add jcmd to get the listen address of the debugger

Hi Alan, Ralf has opened a CSR for JDK-8214892: https://bugs.openjdk.java.net/browse/JDK-8223456 What will we do now? Shall we use this CSR to discuss how the VM options and jcmds/dcmds for "debugging on demand" will be named and what they will be? And in case, the outcome is different to wha

RE: RFR 8223065: Add jcmd to get the listen address of the debugger

Hi Ralf, thanks for the new webrev. It looks good. In GetListenAddressTest.java, the directive "@modules java.base/jdk.intenal.vm" can be removed as well. I've loaded the patch with this modification into our test system. But anyway, we'll need to wait for the CSR discussion until it can be pus

Re: RFR(m): 8223306: Remove threads linked list (use ThreadsList's array in SA)

Correct links: http://cr.openjdk.java.net/~rehn/8223306/v2/webrev/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html http://cr.openjdk.java.net/~rehn/8223306/v2/inc/webrev/ http://cr.openjdk.java.net/~rehn/8223306/v2/webrev/ /Robbin On 2019-05-08 11:17, Robbin

Re: RFR(m): 8223306: Remove threads linked list (use ThreadsList's array in SA)

Hi David, I changed to normal for: http://rehn-ws.se.oracle.com/cr_mirror/8223306/v2/webrev/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java.sdiff.html Full: http://rehn-ws.se.oracle.com/cr_mirror/8223306/v2/webrev/ Inc: http://rehn-ws.se.oracle.com/cr_mirror/8223306/v2/

Re: RFR (S) 8223441: HeapMonitorStatArrayCorrectnessTest fails due to sampling determinism

Hi Jc, A couple of minor comments. 37 private static final int maxCount = 5;   Constant names are better to start from a capital letter.   Also, I'd suggest 10 instead of 5 to make it more reliable.   But it depend on how much it potentiall