Re: [12u] RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows

2019-05-23 Thread David Holmes
Looks good. Thanks, David On 24/05/2019 11:22 am, Daniil Titov wrote: Please review the backport of this fix to JDK 12. The JDK 12 changes applied mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply because of changed context lines. That's the only difference. Webrev:

[12u] RFR: 8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows

2019-05-23 Thread Daniil Titov
Please review the backport of this fix to JDK 12. The JDK 12 changes applied mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply because of changed context lines. That's the only difference. Webrev: http://cr.openjdk.java.net/~dtitov/backports/jdk12u/8214545/webrev.01/ Bu

Re: 8223814: SA: jhsdb common help needs to be more detailed

2019-05-23 Thread Osamu Sakamoto
Hi Serguei, Thank for reviewing. > But could you, please, send the output that the help command will print > with your fix? I attached all fixed --help outputs(clhsdb/debugd/hsdb/jstack/jmap/jinfo/jsnap) to this email. Thanks, Osamu On 5/24/19 03:43, serguei.spit...@oracle.com wrote: Hi O

RFR: 8224252: [TESTBUG] hotspot/test/serviceability/sa/sadebugd/SADebugDTest.java is timing out again after fix for JDK-8163805

2019-05-23 Thread Yasumasa Suenaga
Hi all, Please review this change. This webrev has passed all tests on submit repo (mach5-one-ysuenaga-JDK-8224252-3-20190523-0532-2647154). JBS: https://bugs.openjdk.java.net/browse/JDK-8224252 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8224252/webrev.00/ JDK-8163805 was suppose to

Re: 8223814: SA: jhsdb common help needs to be more detailed

2019-05-23 Thread serguei.spit...@oracle.com
Hi Osamu, It looks Okay to me. But could you, please, send the output that the help command will print with your fix? Thanks, Serguei On 5/23/19 02:34, Osamu Sakamoto wrote: Hi all, I've made the patch that was discussed here.

Re: RFR: JDK-8218701: jdb tests failed with AGENT_ERROR_INVALID_THREAD

2019-05-23 Thread Chris Plummer
Hi Gary, So a JVMTI event came in on a valid thread, got processed by the Debug Agent and enqueued to be sent to the Debugger. However, before it was actually sent, the thread became invalid. Am I understanding this issue correctly? thanks, Chris On 5/23/19 2:59 AM, gary.ad...@oracle.com w

RFR: JDK-8218701: jdb tests failed with AGENT_ERROR_INVALID_THREAD

2019-05-23 Thread gary.ad...@oracle.com
This proposed workaround ensures that the delay between a suspend request passing through the jdwp command queue will not fail due to a no longer running thread.   Webrev: http://cr.openjdk.java.net/~gadams/8218701/webrev/   Issue: https://bugs.openjdk.java.net/browse/JDK-8218701

8223814: SA: jhsdb common help needs to be more detailed

2019-05-23 Thread Osamu Sakamoto
Hi all, I've made the patch that was discussed here. This patch fixes the following JBS ticket. I attached the patch to this email. This patch passes serviceabili

Re: RFR (XS): 8046018: JVMTI Spec: can_redefine_any_class capability spec is inconsistent

2019-05-23 Thread serguei.spit...@oracle.com
On 5/22/19 11:50, Daniel D. Daugherty wrote: On 5/22/19 1:54 PM, serguei.spit...@oracle.com wrote: On 5/22/19 07:00, Daniel D. Daugherty wrote: Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8046018-jvmti-cap-spec.3/ Thumbs up on this version. I did add a historical note to