Re: RFR: docs/accessibility: JDK-8220251: fix headings in java.management

looks ok Jon > On May 30, 2019, at 7:53 PM, Jonathan Gibbons > wrote: > > Please review a conceptually simple fix to adjust the rank of the headings in > the following files in 4 management-related modules: > > src/java.management.rmi/share/classes/javax/management/remote/rmi/package.html > s

RFR: docs/accessibility: JDK-8220251: fix headings in java.management

Please review a conceptually simple fix to adjust the rank of the headings in the following files in 4 management-related modules: src/java.management.rmi/share/classes/javax/management/remote/rmi/package.html src/java.management/share/classes/java/lang/management/LockInfo.java src/java.manageme

Re: RFR (XS): 8223718: Checks in check_slot_type_no_lvt() should be always executed

Okay, thanks! Serguei On 5/30/19 11:33, Vladimir Kozlov wrote: Yes, I looked on it and tested when Tom proposed changes. Vladimir On 5/30/19 10:58 AM, serguei.spit...@oracle.com wrote: Hi Vladimir, May I count you as a (R)eviewer? Thanks, Serguei On 5/30/19 10:05, Vladimir Kozlov wrote:

Re: RFR (M) 8223456: CSR Delayed starting of debugging via jcmd

On 27/05/2019 15:33, Langer, Christoph wrote: : The principal feature here is that one wants to be able to "debug on demand". Currently (or before the change that we're discussing was implemented) one had to start the JVM with the JDWP agent activated in case one's planning to debug. The "onjcm

Re: RFR (XS): 8223718: Checks in check_slot_type_no_lvt() should be always executed

Yes, I looked on it and tested when Tom proposed changes. Vladimir On 5/30/19 10:58 AM, serguei.spit...@oracle.com wrote: Hi Vladimir, May I count you as a (R)eviewer? Thanks, Serguei On 5/30/19 10:05, Vladimir Kozlov wrote: Thank you, Serguei, for fixing this. Vladimir K On 5/29/19 7:32

Re: RFR (XS): 8223718: Checks in check_slot_type_no_lvt() should be always executed

Hi Vladimir, May I count you as a (R)eviewer? Thanks, Serguei On 5/30/19 10:05, Vladimir Kozlov wrote: Thank you, Serguei, for fixing this. Vladimir K On 5/29/19 7:32 PM, serguei.spit...@oracle.com wrote: Thanks, Gary! I've fixed the copyright year in the test and split the updated lines.

Re: RFR (XS): 8223718: Checks in check_slot_type_no_lvt() should be always executed

Thanks a lot, Gary and Alex for reviewing! Serguei On 5/30/19 09:52, Gary Adams wrote: +1 On 5/30/19, 12:39 PM, Alex Menkov wrote: Looks good. --alex On 05/29/2019 19:32, serguei.spit...@oracle.com wrote: Thanks, Gary! I've fixed the copyright year in the test and split the updated lines.

Re: RFR (XS): 8223718: Checks in check_slot_type_no_lvt() should be always executed

Thank you, Serguei, for fixing this. Vladimir K On 5/29/19 7:32 PM, serguei.spit...@oracle.com wrote: Thanks, Gary! I've fixed the copyright year in the test and split the updated lines. Also found some inconsistent use of cached local variables and fixed it. The webrev location is the same: h

Re: RFR (XS): 8223718: Checks in check_slot_type_no_lvt() should be always executed

+1 On 5/30/19, 12:39 PM, Alex Menkov wrote: Looks good. --alex On 05/29/2019 19:32, serguei.spit...@oracle.com wrote: Thanks, Gary! I've fixed the copyright year in the test and split the updated lines. Also found some inconsistent use of cached local variables and fixed it. The webrev locat

Re: RFR (XS): 8223718: Checks in check_slot_type_no_lvt() should be always executed

Looks good. --alex On 05/29/2019 19:32, serguei.spit...@oracle.com wrote: Thanks, Gary! I've fixed the copyright year in the test and split the updated lines. Also found some inconsistent use of cached local variables and fixed it. The webrev location is the same: http://cr.openjdk.java.net/~s