Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

On 7/2/19 10:12 PM, David Holmes wrote: On 3/07/2019 2:27 pm, serguei.spit...@oracle.com wrote: On 7/2/19 8:57 PM, David Holmes wrote: On 2/07/2019 7:53 pm, serguei.spit...@oracle.com wrote: On 7/2/19 01:06, David Holmes wrote: Hi Serguei, On 2/07/2019 6:01 pm, David Holmes wrote: Hi Ser

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

On 3/07/2019 2:27 pm, serguei.spit...@oracle.com wrote: On 7/2/19 8:57 PM, David Holmes wrote: On 2/07/2019 7:53 pm, serguei.spit...@oracle.com wrote: On 7/2/19 01:06, David Holmes wrote: Hi Serguei, On 2/07/2019 6:01 pm, David Holmes wrote: Hi Serguei, On 2/07/2019 12:32 pm, serguei.spit..

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

On 7/2/19 8:57 PM, David Holmes wrote: On 2/07/2019 7:53 pm, serguei.spit...@oracle.com wrote: On 7/2/19 01:06, David Holmes wrote: Hi Serguei, On 2/07/2019 6:01 pm, David Holmes wrote: Hi Serguei, On 2/07/2019 12:32 pm, serguei.spit...@oracle.com wrote: Hi David, On 7/1/19 19:03, Davi

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

On 2/07/2019 7:53 pm, serguei.spit...@oracle.com wrote: On 7/2/19 01:06, David Holmes wrote: Hi Serguei, On 2/07/2019 6:01 pm, David Holmes wrote: Hi Serguei, On 2/07/2019 12:32 pm, serguei.spit...@oracle.com wrote: Hi David, On 7/1/19 19:03, David Holmes wrote: Hi Serguei, The updates t

Re: A Bug about the JVM Attach mechanism

Hi Serguei, Can I send RFR for JDK-8225690 and close JDK-8225193 as duplicate of it? Thanks, Yasumasa On 2019/07/03 1:06, serguei.spit...@oracle.com wrote: Hi Yasumasa, The approach looks Okay in general. Could you, please, post an RFR with the bug number in the email subject? Thanks, Ser

Re: RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

> On Jul 2, 2019, at 9:53 AM, Stefan Karlsson > wrote: > > Hi all, > > Please review this patch to read objects with AS_NO_KEEPALIVE in the > HeapDumper. > > http://cr.openjdk.java.net/~stefank/8227086/webrev.01/ > https://bugs.openjdk.java.net/browse/JDK-8227086 > > Found this while running

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

Thank you, Alex! Serguei On 7/2/19 11:47 AM, Alex Menkov wrote: v2 looks good as well --alex On 07/01/2019 18:12, serguei.spit...@oracle.com wrote: Hi Alex, Thank you for the review! Could also look at the webrev v2? : http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.2/ T

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

v2 looks good as well --alex On 07/01/2019 18:12, serguei.spit...@oracle.com wrote: Hi Alex, Thank you for the review! Could also look at the webrev v2? : http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.2/ This change also updates page headings (result of our discussion wi

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Hi Poonam, The update still looks good to me (modulo renaming jhat => jstat). Thanks, Serguei On 6/28/19 07:19, Poonam Parhar wrote: Hello, Thomas Schatzl pointed out that the recalculate_used_stable() call

Re: A Bug about the JVM Attach mechanism

Hi Yasumasa, The approach looks Okay in general. Could you, please, post an RFR with the bug number in the email subject? Thanks, Serguei On 6/26/19 18:41, Yasumasa Suenaga wrote: Hi Serguei, Thank you for your comment. I uploaded new webrev which includes the fix. http://cr.openjdk.java

RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

Hi all, Please review this patch to read objects with AS_NO_KEEPALIVE in the HeapDumper. http://cr.openjdk.java.net/~stefank/8227086/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8227086 Found this while running some extra verification code through our barriers. This is one place where

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

On 7/2/19 3:42 PM, Poonam Parhar wrote: > It wasn't meant to be non-public. I have opened it. Thanks! -Aleksey signature.asc Description: OpenPGP digital signature

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Hi Aleksey, Thomas, It wasn't meant to be non-public. I have opened it. Thanks, Poonam On 7/2/19 3:36 AM, Thomas Schatzl wrote: Hi, On Tue, 2019-07-02 at 10:10 +0200, Aleksey Shipilev wrote: Hi, On 6/21/19 10:30 PM, Poonam Parhar wrote: On 6/21/19 12:21 PM, Poonam Parhar wrote: Bug 821552

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Hi, On Tue, 2019-07-02 at 10:10 +0200, Aleksey Shipilev wrote: > Hi, > > On 6/21/19 10:30 PM, Poonam Parhar wrote: > > On 6/21/19 12:21 PM, Poonam Parhar wrote: > > > Bug 8215523 : > > > jstat reports incorrect values for > > > OU for CMS GC > >

RE: RFR: 8225715: jhsdb jmap fails to write binary heap dump of a jshell process

Hi Kevin, > -Original Message- > From: Kevin Walls > Sent: Tuesday, July 02, 2019 2:18 PM > To: Fairoz Matte ; serviceability- > d...@openjdk.java.net > Subject: Re: RFR: 8225715: jhsdb jmap fails to write binary heap dump of a > jshell process > > Hi Fairoz - > > Looks good to me too. >

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

On 7/2/19 01:06, David Holmes wrote: Hi Serguei, On 2/07/2019 6:01 pm, David Holmes wrote: Hi Serguei, On 2/07/2019 12:32 pm, serguei.spit...@oracle.com wrote: Hi David, On 7/1/19 19:03, David Holmes wrote: Hi Serguei, The updates to the heading levels all looks fine. Okay, thanks!

Re: RFR: 8225715: jhsdb jmap fails to write binary heap dump of a jshell process

Hi Fairoz - Looks good to me too. The " -encoding utf8" in the test might be a leftover from something else (maybe /timeout=240 also?), you could leave it out but no problem either way. Thanks! Kevin On 01/07/2019 05:31, Fairoz Matte wrote: Hi, Please review a fix that potentially handle

Re: RFR 8215523: jstat reports incorrect values for OU for CMS GC

Hi, On 6/21/19 10:30 PM, Poonam Parhar wrote: > On 6/21/19 12:21 PM, Poonam Parhar wrote: >> Bug 8215523 : jstat >> reports incorrect values for >> OU for CMS GC This bug is non-public, was it really meant to be? -- Thanks, -Aleksey signatur

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

Hi Serguei, On 2/07/2019 6:01 pm, David Holmes wrote: Hi Serguei, On 2/07/2019 12:32 pm, serguei.spit...@oracle.com wrote: Hi David, On 7/1/19 19:03, David Holmes wrote: Hi Serguei, The updates to the heading levels all looks fine. Okay, thanks! However the tables in the generated ou

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

Hi Serguei, On 2/07/2019 12:32 pm, serguei.spit...@oracle.com wrote: Hi David, On 7/1/19 19:03, David Holmes wrote: Hi Serguei, The updates to the heading levels all looks fine. Okay, thanks! However the tables in the generated output look broken - they all have empty "header" rows wi

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

Thanks Alan, much appreciated. Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd internet email: andrew_m_leon...@uk.ibm.com From: Alan Bateman To: Andrew Leonard Cc: serviceability-dev@openjdk.java.net Date: 02/07/2019 07:45 Subject:Re: RFR JDK