RFR: JDK-8228547: accessibility errors in jvmti.html

2019-08-16 Thread Alex Menkov
Hi all, Please review the change that fixes accessibility issues in generated jvmti.html There are 2 "general" accessibility issues ("content outside of a region") - fixed by replacing with and role="main"> with and huge number (5200+) of table issues: - no row or column header for cells;

Re: RFR: 8229258: Rework markOop and markOopDesc into a simpler mark word value carrier

2019-08-16 Thread Kim Barrett
> On Aug 16, 2019, at 4:20 AM, Stefan Karlsson > wrote: > > On 2019-08-16 00:59, Kim Barrett wrote: >> src/hotspot/share/oops/markOop.hpp >> 109 template operator T(); >> My mistake in the earlier review comment. Function should be const >> qualified, e.g. that should be >> template operat

Re: RFR 8229420: [Redo] jstat reports incorrect values for OU for CMS GC

2019-08-16 Thread Severin Gehwolf
On Wed, 2019-08-14 at 06:13 -0700, Poonam Parhar wrote: > Please review the webrev with the updated fix: > http://cr.openjdk.java.net/~poonam/8229420/webrev.00/ As far as the jhat/jstat typo is concerned this looks good. I haven't reviewed other bits. Thanks for doing this via new bug. Thanks, Se

Re: RFR: 8229258: Rework markOop and markOopDesc into a simpler mark word value carrier

2019-08-16 Thread Stefan Karlsson
On 2019-08-16 00:59, Kim Barrett wrote: On Aug 15, 2019, at 7:46 AM, Stefan Karlsson wrote: Thanks Kim, Roman, Dan and Coleen for reviews and feedback. I rebased the patch, fixed more alignments, renamed the bug, and rerun the test through tier1-3. https://cr.openjdk.java.net/~stefank/822925