Re: RFR: 8230830: No required ResourceMark in src/hotspot/share/prims/jvmtiImpl.cpp:JvmtiSuspendControl::print()

David, Daniel, Serguei, Chris Thank you for review. Leonid > On Sep 11, 2019, at 4:38 PM, Daniel D. Daugherty > wrote: > > Thanks for chasing that down. I'm good with your change. > > Dan > > > On 9/11/19 6:45 PM, Leonid Mesnik wrote: >> Hi >> >> It is still needed for >> vframe *vf = v

Re: RFR: 8230830: No required ResourceMark in src/hotspot/share/prims/jvmtiImpl.cpp:JvmtiSuspendControl::print()

Thanks for chasing that down. I'm good with your change. Dan On 9/11/19 6:45 PM, Leonid Mesnik wrote: Hi It is still needed for vframe *vf = vframeFor(java_thread, depth); Leonid On Sep 11, 2019, at 5:56 AM, Daniel D. Daugherty mailto:daniel.daughe...@oracle.com>> wrote: On 9/11/19 1:06

Re: RFR: 8230830: No required ResourceMark in src/hotspot/share/prims/jvmtiImpl.cpp:JvmtiSuspendControl::print()

Hi It is still needed for vframe *vf = vframeFor(java_thread, depth); Leonid > On Sep 11, 2019, at 5:56 AM, Daniel D. Daugherty > wrote: > > On 9/11/19 1:06 AM, Leonid Mesnik wrote: >> Hi >> >> Thank you for feedback. >> >>> On Sep 10, 2019, at 10:03 PM, David Holmes >>

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

Hi Christoph, On 12/09/2019 8:05 am, Langer, Christoph wrote: Hi, please review an enhancement which I’ve identified when working with Processhelper for JDK-8230850. I noticed that ProcessHelper is an interface in common code with a static method that would lookup the actual platform implem

RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

Hi, please review an enhancement which I've identified when working with Processhelper for JDK-8230850. I noticed that ProcessHelper is an interface in common code with a static method that would lookup the actual platform implementation via reflection. This seems a little cumbersome since we

RE: RFR (S): 8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently

Hi Chris, Thomas, thanks for looking at this. I was also wondering whether a fix in ProcessHelper would be appropriate. But I think introducing retries and delays in that code can do more harm than help. For this special test case, aiming to test the ProcessHelper functionality (on Linux) only

Re: RFR (S): 8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently

It does seem that the fix should be in ProcessHelper.java in getMainClass(), or maybe even getCommandLine(). Fixing it in the test implies that every user of getMainClass() should be doing something similar. But then also note what ProcessArgumentMatch.check() is

Re: RFR: 8229378: jdwp library loader in linker_md.c quietly truncates on buffer overflow

Hi Adam, Yes, the fix in this file is not needed. Thanks, Serguei On 9/11/19 04:18, Adam Farley8 wrote: Hi Serguei, If you're happy with the fix, then here's a webrev without the os.cpp bit.

Re: RFR (S): 8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently

Hi Christoph, in general I think this is fine. The increase-by-pow2 sleep time is odd but okay :) The whole things seems rather fragile and has a lot of question marks but I think your fix does not make it worse. One fun error now is that with a follow up java test reusing the PID we could get a

Re: RFR: 8230830: No required ResourceMark in src/hotspot/share/prims/jvmtiImpl.cpp:JvmtiSuspendControl::print()

On 9/11/19 1:06 AM, Leonid Mesnik wrote: Hi Thank you for feedback. On Sep 10, 2019, at 10:03 PM, David Holmes > wrote: Hi Leonid, On 11/09/2019 12:03 pm, Leonid Mesnik wrote: Hi Could you please review following tiny fix which just add ResourceMark in Jvmti

RFR (S): 8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently

Hi, please review this change for test sun/tools/jcmd/TestProcessHelper.java to make it more robust. Bug: https://bugs.openjdk.java.net/browse/JDK-8230850 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8230850.0/ This Linux only test is starting several Java processes and then tries to fi

Re: RFR: 8229378: jdwp library loader in linker_md.c quietly truncates on buffer overflow

Hi Serguei, If you're happy with the fix, then here's a webrev without the os.cpp bit. http://cr.openjdk.java.net/~afarley/8229378.3/webrev/ That was only included to make direct testing possible, and I want to make sure it doesn't get included by accident. Best Regards Adam Farley IBM Runti

RE: RFR: JDK-8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException

Hi Alex, thanks, the change looks good. Best regards, Richard. -Original Message- From: Alex Menkov Sent: Dienstag, 10. September 2019 22:33 To: Reingruber, Richard ; serguei.spit...@oracle.com; OpenJDK Serviceability Subject: Re: RFR: JDK-8192057: com/sun/jdi/BadHandshakeTest.java

Re: RFR: 8229378: jdwp library loader in linker_md.c quietly truncates on buffer overflow

Hi Adam, I'm Okay with this fix. If nobody else have comments then I'll build it, test a little bit and push to the jdk/jdk repo. Thanks, Serguei On 9/9/19 09:53, Adam Farley8 wrote: Hi Serguei,