Re: RFR (M): 8207266: ThreadMXBean::getThreadAllocatedBytes() can be quicker for self thread

Hi Paul, It looks pretty good in general. http://cr.openjdk.java.net/~phh/8207266/webrev.08/test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java.frames.html It would be nice to refactor the java main() method as it becomes too big. Two ways ofgetCurrentThreadAllocatedBytes() test

Re: RFR: 8230881: serviceability/sa/TestJmapCore tests fail with java.lang.RuntimeException: Could not find dump file

Hi Leonid, Thank you for filing the bug! I've changed it to Enhancement. Thanks, Serguei On 9/13/19 4:42 PM, Leonid Mesnik wrote: Thank you for your review. I filed another bug (rfe?) to support testing on hosts with compressing cores https://bugs.openjdk.java.net/browse/JDK-8230942 Will

Re: RFR: 8230881: serviceability/sa/TestJmapCore tests fail with java.lang.RuntimeException: Could not find dump file

Thank you for your review. I filed another bug (rfe?) to support testing on hosts with compressing cores https://bugs.openjdk.java.net/browse/JDK-8230942 Will fix it later. Leonid > On Sep 13, 2019, at 4:33 PM, serguei.spit...@oracle.com wrot

Re: RFR: 8230881: serviceability/sa/TestJmapCore tests fail with java.lang.RuntimeException: Could not find dump file

Hi Leonid, +1 Thanks, Serguei On 9/12/19 4:46 PM, David Holmes wrote: Looks good! Thanks for fixing. David On 13/09/2019 2:56 am, Leonid Mesnik wrote: Hi Could you please verify following fix which update core filename patterns. Some hosts are configured to compress core files during co

Re: RFR (M): 8207266: ThreadMXBean::getThreadAllocatedBytes() can be quicker for self thread

Hi Paul, On 14/09/2019 5:11 am, Hohensee, Paul wrote: Hi David, thanks for your comments. New webrev in http://cr.openjdk.java.net/~phh/8207266/webrev.08/ Both the old and new versions of the code check that thread allocated memory is both supported and enabled. The existing version of getTh

Re: RFR [XS]: 8230901: missing ReleaseStringUTFChars in servicability native code

Hi Matthias, On 9/12/19 4:52 AM, Baesken, Matthias wrote: Hi Thomas,   thanks for the review . You are correct about atoi . New webrev  : http://cr.openjdk.java.net/~mbaesken/webrevs/8230901.1/ I had 2 additional  observations 

Re: RFR [XS]: 8230901: missing ReleaseStringUTFChars in servicability native code

Hi Matthias, The fix looks good to me. Thank you for catching and fixing this! Thanks, Serguei On 9/13/19 3:01 AM, Baesken, Matthias wrote: Hello , my colleague  Ralf pointed out that  the  NULL-check  of the result of GetStringUTFChars should be done right  after the  GetStringUTFChars  

Re: RFR (M): 8207266: ThreadMXBean::getThreadAllocatedBytes() can be quicker for self thread

Hi David, thanks for your comments. New webrev in http://cr.openjdk.java.net/~phh/8207266/webrev.08/ Both the old and new versions of the code check that thread allocated memory is both supported and enabled. The existing version of getThreadAllocatedBytes(long []) calls verifyThreadAllocatedMe

Re: RFR (S): 8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently

3 minutes??? Sounds like something is wrong. What is the JVM doing during this time? Chris On 9/12/19 12:53 PM, Langer, Christoph wrote: Hi Severin, that seems an interesting idea for an elegant solution. However, after trying this on a decently fast linux x86 box by leveraging one of these

RFR(S) 8230956: Should disable Escape Analysis when JVMTI capability can_tag_objects is taken

Hi, could I please get reviews for Webrev: http://cr.openjdk.java.net/~rrich/webrevs/2019/8230956/webrev.0/ Bug:https://bugs.openjdk.java.net/browse/JDK-8230956 JVMTI provides functions to follow references beginning at the roots of the object graph and it provides functions to iterate all

RE: RFR [XS]: 8230901: missing ReleaseStringUTFChars in servicability native code

Hello , my colleague Ralf pointed out that the NULL-check of the result of GetStringUTFChars should be done right after the GetStringUTFChars so I moved the NULL-check up : http://cr.openjdk.java.net/~mbaesken/webrevs/8230901.2/ Best regards, Matthias Hi Thomas, thanks for the r

Re: RFR (S): 8230850: Test sun/tools/jcmd/TestProcessHelper.java fails intermittently

On Thu, 2019-09-12 at 19:53 +, Langer, Christoph wrote: > Hi Severin, > > that seems an interesting idea for an elegant solution. However, > after trying this on a decently fast linux x86 box by leveraging one > of these ProcessTools::startProcess methods that would wait for a > certain output

Re: RFR (M): 8207266: ThreadMXBean::getThreadAllocatedBytes() can be quicker for self thread

Hi Paul, On 13/09/2019 10:29 am, Hohensee, Paul wrote: Thanks for clarifying the review rules. Would someone from the serviceability team please review? New webrev at http://cr.openjdk.java.net/~phh/8207266/webrev.07/ One aspect of the functional change needs clarification for me - and apol