Re: RFR(S): JDK-8231635: SA Stackwalking code stuck in BasicTypeDataBase.findDynamicTypeForAddress()

Thanks Daniil! Chris On 11/12/19 9:08 PM, Daniil Titov wrote: Hi Chris, The change looks good to me. Thanks! --Daniil On 11/12/19, 11:06 AM, "serviceability-dev on behalf of Chris Plummer" wrote: Thanks Serguei! Can I get one more review please? thanks,

Re: RFC 8233915: JVMTI FollowReferences: Java Heap Leak not found because of C2 Scalar Replacement

Thank you for fixing this. Leonid On 11/13/19 4:24 AM, Reingruber, Richard wrote: Hi Leonid, these are valid points. Thanks for making me aware of them. I've increased the maximum heap size in my tests as suggested, and I've also run them with ZGC enabled. I've also added the vm.opt.TieredC

Re: RFR: 8233549: Thread interrupted state must only be accessed when not in a safepoint-safe state

On 11/12/19 5:50 PM, David Holmes wrote: Hi Dan, Thanks for taking a look so quickly! Your welcome! I figured you would prefer to get this one out of the way quickly. On 13/11/2019 3:18 am, Daniel D. Daugherty wrote: On 11/11/19 11:52 PM, David Holmes wrote: webrev: http://cr.openjdk.jav

RE: RFC 8233915: JVMTI FollowReferences: Java Heap Leak not found because of C2 Scalar Replacement

Hi Leonid, these are valid points. Thanks for making me aware of them. I've increased the maximum heap size in my tests as suggested, and I've also run them with ZGC enabled. I've also added the vm.opt.TieredCompilation != true requirement. I've done the changes in place. Thanks, Richard. --