Re: RFR(S): 8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INVALID_SLOT) on static method

2019-11-20 Thread Chris Plummer
+1 On 11/20/19 3:32 PM, Alex Menkov wrote: Looks good. --alex On 11/19/2019 15:36, serguei.spit...@oracle.com wrote: Please, review a fix for:    https://bugs.openjdk.java.net/browse/JDK-8169467 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8169467-jvmti-local-instance.1/ Sum

Re: 8233197(S): Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

2019-11-20 Thread serguei . spitsyn
Hi Marcus, Thank you for the answers! The update looks good to me. A couple of minor minor comments. http://cr.openjdk.java.net/~mgronlun/8233197/webrev02/src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp.frames.html 57 static bool set_event_notification_mode(jvmtiEventMode mode, 58

Re: RFR(S): 8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INVALID_SLOT) on static method

2019-11-20 Thread serguei . spitsyn
Thank you, Alex! Serguei On 11/20/19 3:32 PM, Alex Menkov wrote: Looks good. --alex On 11/19/2019 15:36, serguei.spit...@oracle.com wrote: Please, review a fix for:    https://bugs.openjdk.java.net/browse/JDK-8169467 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8169467-jvmti-loc

Re: RFR(S): 8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INVALID_SLOT) on static method

2019-11-20 Thread Alex Menkov
Looks good. --alex On 11/19/2019 15:36, serguei.spit...@oracle.com wrote: Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8169467 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8169467-jvmti-local-instance.1/ Summary:   The JVMTI GetLocalInstance function

RE: 8233197(S): Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

2019-11-20 Thread Markus Gronlund
Hi Serguei, thanks for taking a look.   "It does not look as a good idea to change the JVMTI phase like above.   If you need the ONLOAD phase just to enable capabilities then it is better to do it in the real ONLOAD phase.   Do I miss anything important here?   Please, ask questions if you h