Re: RFR: 8234624: jstack mixed mode should refer DWARF

Hi Yasumasa, This is nice move in general. Thank you for working on this! http://cr.openjdk.java.net/~ysuenaga/JDK-8234624/webrev.01/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxCDebugger.java.frames.html 96 long libptr = dbg.findLibPtrByAddress(pc); 97 if (libptr ==

Re: RFR [XS]: 8234968: check calloc rv in libinstrument InvocationAdapter

Hi Matthias, +1 Thanks, Serguei On 12/12/19 2:00 AM, Langer, Christoph wrote: Hi Matthias, I think your current patch is good as it is – at least it wouldn’t make things worse, AFAICS. Further improvements can probably be done under another issue. Cheers Christoph *From:* serviceabilit

Re: RFR(T) 8235922: [TESTBUG]TestRecordAttrGenericSig.java and TestRecordAttr.java are failing

Hi Harold, +1 Thanks, Serguei On 12/13/19 11:45 AM, Daniel D. Daugherty wrote: On 12/13/19 2:35 PM, Harold Seigel wrote: Hi, Please review this trivial fix to prevent java/lang/instrument/... TestRecordAttr.java and TestRecordAttrGenericSig.java from failing.  The fix replaces hard-wired J

Re: RFR(T) 8235922: [TESTBUG]TestRecordAttrGenericSig.java and TestRecordAttr.java are failing

Thanks Dan! Harold On 12/13/2019 2:45 PM, Daniel D. Daugherty wrote: On 12/13/19 2:35 PM, Harold Seigel wrote: Hi, Please review this trivial fix to prevent java/lang/instrument/... TestRecordAttr.java and TestRecordAttrGenericSig.java from failing.  The fix replaces hard-wired JDK version

Re: RFR(T) 8235922: [TESTBUG]TestRecordAttrGenericSig.java and TestRecordAttr.java are failing

On 12/13/19 2:35 PM, Harold Seigel wrote: Hi, Please review this trivial fix to prevent java/lang/instrument/... TestRecordAttr.java and TestRecordAttrGenericSig.java from failing.  The fix replaces hard-wired JDK version 14 with mechanisms that get the latest JDK version. Open Webrev: htt

RFR(T) 8235922: [TESTBUG]TestRecordAttrGenericSig.java and TestRecordAttr.java are failing

Hi, Please review this trivial fix to prevent java/lang/instrument/... TestRecordAttr.java and TestRecordAttrGenericSig.java from failing.  The fix replaces hard-wired JDK version 14 with mechanisms that get the latest JDK version. Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_823592

RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

Hi David, > Some further queries/concerns: > > src/hotspot/share/runtime/objectMonitor.cpp > > Can you please explain the changes to ObjectMonitor::wait: > > ! _recursions = save // restore the old recursion count > ! + jt->get_and_reset_relock_count_after

Re: Discuss the design of parallel and incremental jmap histo.

Hi Lin, I have a question regarding the need for incremental support. The CSR states: Problem: Now, the "JMap -histo" tool can not dump intermediate result, which is useful if the heap is large and dumping the whole heap can be stuck.

Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

Looks good. thanks, Chris On 12/13/19 5:02 AM, Fairoz Matte wrote: Hi Chris, Thanks for the review, Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro for -1L. I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L. http://cr.openjdk.java.net/~fmatte/8235637/webrev.0

RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

Hi David, Vladimir, The tests are very targeted and customized towards the issues they solve. IMHO they should be run in the configuration they are tailored for, but as I said, I'm ok with removing the tiered options/conditions. The enhancement should be covered also by existing JVMTI, JDI, JDW

RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

Hi Chris, Thanks for the review, Please find the webrev.01 with usage of INAVLID_LOAD_ADDRESS macro for -1L. I have also added one more macro for ZERO_LOAD_ADDRESS for 0x0L. http://cr.openjdk.java.net/~fmatte/8235637/webrev.01/ Thanks, Fairoz -Original Message- From: Chris Plummer Sent

Re: RFR: 8226797: serviceability/tmtools/jstat/GcCapacityTest.java fails with Exception: java.lang.RuntimeException: OGCMN > OGCMX (min generation capacity > max generation capacity)

Hi Serguei, On 2019-12-13 01:41, serguei.spit...@oracle.com wrote: Hi Stefan, It looks good to me. Thanks for reviewing. Sorry, I was on the meeting, wrote this email and forgot to push 'send' button. Just now discovered that it has not been really sent. :( No problem. I pushed this ye