Hi Yasumasa,
Thanks for the review. If you mean plans for an alternate extension
mechanism, we have none at the moment. We are of course open to
suggestions. Some have been discussed on the recent thread regarding
this topic, but there doesn't seem to be much consensus on how to
approach this
Hi Chris,
Looks good.
BTW do you have any plan to provide alternative(s) on CLHSDB?
Thanks,
Yasumasa
On 2019/12/17 14:36, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8236062
http://cr.openjdk.java.net/~cjplummer/8236062/webrev.00/
Si
David
On 17/12/2019 4:57 pm, David Holmes wrote:
Hi Richard,
On 14/12/2019 5:01 am, Reingruber, Richard wrote:
Hi David,
> Some further queries/concerns:
>
> src/hotspot/share/runtime/objectMonitor.cpp
>
> Can you please explain the changes to ObjectMonitor::wait:
>
> !
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8236062
http://cr.openjdk.java.net/~cjplummer/8236062/webrev.00/
Since SA javascript support is broken as described in [1] JDK-8235594,
and we'll likely remove it, I'd like to at least get it disabled now.
I'd like t
Clarification ...
On 17/12/2019 12:40 pm, coleen.phillim...@oracle.com wrote:
Short answer below.
On 12/16/19 5:51 PM, David Holmes wrote:
Hi Coleen,
A quick initial response ...
On 16/12/2019 11:26 pm, coleen.phillim...@oracle.com wrote:
On 12/16/19 8:04 AM, David Holmes wrote:
Hi Cole
Dear All,
I found jhsdb jmap —heap print the value of uint_max (17592186044415 MB)
when MaxMetaspaceSize is not set by user. This number confused me a little.
And I also found the jcmd VM.metaspace prints “unimited” if
MaxMetaspaceSize is not set. Which seems more reasonable.
So D
Dear Chris,
I think I can first make the patch of parallel jmap. it seems to me that if
parallel is fast enough, there is no need for incremental. So l will not work
on it until I found new cases that show it is necessary, then we can discuss it
again.
Thanks!
BRs,
Lin
On Dec 17, 2019
Short answer below.
On 12/16/19 5:51 PM, David Holmes wrote:
Hi Coleen,
A quick initial response ...
On 16/12/2019 11:26 pm, coleen.phillim...@oracle.com wrote:
On 12/16/19 8:04 AM, David Holmes wrote:
Hi Coleen,
On 16/12/2019 9:41 pm, coleen.phillim...@oracle.com wrote:
Summary: Start
Hi Ioi,
It looks good.
It is nice to get rid of unneeded dependency.
Thanks,
Serguei
On 12/15/19 23:22, Alan Bateman wrote:
On 16/12/2019 06:21, Ioi Lam wrote:
:
The fix is to rewrite RedefineClassHelper to use ClassFileInstaller
instead.
This looks okay but just to point out that the jar
Hi Coleen,
A quick initial response ...
On 16/12/2019 11:26 pm, coleen.phillim...@oracle.com wrote:
On 12/16/19 8:04 AM, David Holmes wrote:
Hi Coleen,
On 16/12/2019 9:41 pm, coleen.phillim...@oracle.com wrote:
Summary: Start ServiceThread before compiler threads, and run nmethod
barriers
On 12/16/19 8:13 AM, Robbin Ehn wrote:
Hi Coleen, in VM_RedefineClasses::doit:
This updates the breakpoints:
MetadataOnStackMark md_on_stack(/*walk_all_metadata*/true,
/*redefinition_walk*/true);
And this removes breakpoints:
for (int i = 0; i < _class_count; i++) {
redefine_single_
+1
On 12/16/19 8:35 AM, Kevin Walls wrote:
Great! 8-)
On 16/12/2019 15:36, Fairoz Matte wrote:
Oh yes,
Thanks Kevin for the review.
Corrected the same -
http://cr.openjdk.java.net/~fmatte/8235637/webrev.02
Thanks,
Fairoz
On 12/15/19 5:38 PM, linzang(臧琳) wrote:
Dear Chris,
>> why jmap is getting stuck or "killed by timer" as you mention below.
Shouldn't this be considered a bug and addressed directly.
This “timer” is usually another process, my experience is HDFS and
ZKFC, the ZKFC pings it’s NameNode period
Thanks Serguei!
Harold
On 12/13/2019 4:50 PM, serguei.spit...@oracle.com wrote:
Hi Harold,
+1
Thanks,
Serguei
On 12/13/19 11:45 AM, Daniel D. Daugherty wrote:
On 12/13/19 2:35 PM, Harold Seigel wrote:
Hi,
Please review this trivial fix to prevent java/lang/instrument/...
TestRecordAttr.j
Hi Alan,
Thanks for the review and the tip. I will use ToolProvider for
JDK-8236028 [TESTBUG] Remove dependency of sun.tools.jar from
appcds/JarBuilder
- Ioi
On 12/15/19 11:22 PM, Alan Bateman wrote:
On 16/12/2019 06:21, Ioi Lam wrote:
:
The fix is to rewrite RedefineClassHelper to use Cla
Hi Richard,
On 2019-12-16 14:41, Reingruber, Richard wrote:
Hi Robbin,
first of all: thanks a lot for providing feedback. I do appreciate it.
I am absolutely willing to move this to handshakes. Only I still can't see how
to achieve it.
Could you explain the drafted class EscapeBarrierSuspend
Great! 8-)
On 16/12/2019 15:36, Fairoz Matte wrote:
Oh yes,
Thanks Kevin for the review.
Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02
Thanks,
Fairoz
Oh yes,
Thanks Kevin for the review.
Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02
Thanks,
Fairoz
-Original Message-
From: Kevin Walls
Sent: Monday, December 16, 2019 8:44 PM
To: Fairoz Matte ; Chris Plummer
; serviceability-dev@openjdk.java.net
Subject: Re:
Nice to know the difference between something that is zero, and
something that has failed. 8-)
...oops, that says INAVLID_LOAD_ADDRESS
..not INVALID, so other that the typo yes it looks good.
---
Kevin
On 13/12/2019 13:02, Fairoz Matte wrote:
Hi Chris,
Thanks for the review,
Please find t
Hi Robbin,
first of all: thanks a lot for providing feedback. I do appreciate it.
I am absolutely willing to move this to handshakes. Only I still can't see how
to achieve it.
Could you explain the drafted class EscapeBarrierSuspendHandshake a little bit?
[1]
I'd like to look at it by example
On 12/16/19 8:04 AM, David Holmes wrote:
Hi Coleen,
On 16/12/2019 9:41 pm, coleen.phillim...@oracle.com wrote:
Summary: Start ServiceThread before compiler threads, and run nmethod
barriers for zgc before adding to the service thread queue, or
posting the events on the java thread queue.
Hi Coleen, in VM_RedefineClasses::doit:
This updates the breakpoints:
MetadataOnStackMark md_on_stack(/*walk_all_metadata*/true,
/*redefinition_walk*/true);
And this removes breakpoints:
for (int i = 0; i < _class_count; i++) {
redefine_single_class(_class_defs[i].klass, _scratch_class
Hi Coleen,
On 16/12/2019 9:41 pm, coleen.phillim...@oracle.com wrote:
Summary: Start ServiceThread before compiler threads, and run nmethod
barriers for zgc before adding to the service thread queue, or posting
the events on the java thread queue.
I can't comment on most of this but the earli
I have to think about this. Could there be breakpoints in old emcp
methods that we do not remove? The metadata_do function is trying to
keep old Methods from being deleted while there are still references to
them.
http://cr.openjdk.java.net/~rehn/8235912/v1/webrev/src/hotspot/share/prims
I forgot to post the updated webrev:
http://cr.openjdk.java.net/~rschmelter/webrevs/8234510/webrev.2/
In addition to the changes requested by Thomas, I also renamed the entries in
the heap dump segment from entries to sub-records, since that is what they are
called in the comment describing the
Summary: Start ServiceThread before compiler threads, and run nmethod
barriers for zgc before adding to the service thread queue, or posting
the events on the java thread queue.
See bug for description of the problems found with the new Zombie.java test.
open webrev at http://cr.openjdk.java.n
Hi Richard, as mentioned it would be better if you could do this with
handshakes, instead of using _suspend_flag (since they are going away).
But I can't think of a way doing it without blocking safepoints, so we need to
add some more features in handshakes first.
When possible I hope you are will
Hi all, please review.
From issue, https://bugs.openjdk.java.net/browse/JDK-8235912:
JvmtiBreakpoints are walked via VMThread oops_do (the breakpoint is in a vm
operation) before they are installed in the safeopint and after they have been
installed, walked with JvmtiCurrentBreakpoints::oops_d
28 matches
Mail list logo
