Hi Serguei,
Thank you for finding this! Please review the new version of webrev [1]
that has it corrected. The new webrev also includes changes in the test to
make sure that all jstatd tests run for both styles of command line options.
Testing: Mach5 jobs for sun/tools/jstatd succeeded. Tiers
Good catch. It's a copy-n-paste bug from the block of code just above
this block. You can use "-r " or "-r". The buggy code is
handling the second form. The test case uses the first form so didn't
catch this error.
Chris
On 2/4/20 7:51 PM, serguei.spit...@oracle.com wrote:
Hi Daniil,
It loo
Hi Daniil,
It looks okay to me in general.
But I'm puzzled with this part:
http://cr.openjdk.java.net/~dtitov/8196729/webrev.01/src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java.udiff.html
+} else if (arg.startsWith("-r")) {
+
Ping!
And I decided to push to 15 instead of 14. Will backport to 14
eventually.
thanks,
Chris
On 1/30/20 10:20 PM, Chris Plummer wrote:
Yes, you are correct:
https://bugs.openjdk.java.net/b
Hi,
I have prepared webrev.4 that incorporates feedback from webrev.3 (thanks!)
Full: http://cr.openjdk.java.net/~rrich/webrevs/2019/8227745/webrev.4/
Incremental:
http://cr.openjdk.java.net/~rrich/webrevs/2019/8227745/webrev.4.inc/
I was not able to eliminate the additional suspend flag now. I
