Re: Re: RFR: add parallel heap inspection support for jmap histo(G1)(Internet mail)

2020-02-17 Thread 臧琳
Dear David,        Thanks a lot!       I have updated the refined code to  http://cr.openjdk.java.net/~lzang/jmap-8214535/8215264/webrev_01/.       IMHO the parallel heap inspection can be extended to all kinds of heap as long as the heap layout can support parallel iteration.       Maybe we can f

Re: RFR: add parallel heap inspection support for jmap histo(G1)

2020-02-17 Thread David Holmes
Hi Lin, Adding in hotspot-gc-dev as they need to see how this interacts with GC worker threads, and whether it needs to be extended beyond G1. I happened to spot one nit when browsing: src/hotspot/share/gc/shared/collectedHeap.hpp + virtual bool run_par_heap_inspect_task(KlassInfoTable* ci

RFR: add parallel heap inspection support for jmap histo(G1)

2020-02-17 Thread 臧琳
Dear All, May I ask your help to review the follow changes: webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215264/webrev_00/ bug: https://bugs.openjdk.java.net/browse/JDK-8215624 related CSR: https://bugs.openjdk.java.net/browse/JDK-8239290 This patch enable parall

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-17 Thread Zhengyu Gu
Hi Stefan, Thanks for the review and suggestions, updated accordingly: http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.01/ --- Previously, the calls to 'mark' and 'visited' were inlineable, but now every GC has to take a virtual call when marking the objects. My guess is that this code i