Re: RFR: 8196751: Add jhsdb option to specify debug server RMI connector port

Hi Daniil, On 2020/03/14 7:05, Daniil Titov wrote: Hi Yasumasa, Serguei and Alex, Please review a new version of the webrev that includes the changes Yasumasa suggested. Shutdown hook is already registered in c'tor of HotSpotAgent. It works same as shutdownServer(), so I think shutdown h

RFR: 8240956: SEGV in DwarfParser::process_dwarf after JDK-8234624

and LSDA in this webrev. Also I added bailout code if DWARF processing is failed due to these concerns. This change has passed all tests on submit repo (mach5-one-ysuenaga-JDK-8240956-20200313-1518-9434671), also I tested it on my Fedora 31 box and Oracle Linux 7.7 container. Thanks, Yasumasa

Re: RFR: 8196751: Add jhsdb option to specify debug server RMI connector port

Hi Yasumasa, Serguei and Alex, Please review a new version of the webrev that includes the changes Yasumasa suggested. > Shutdown hook is already registered in c'tor of HotSpotAgent. >It works same as shutdownServer(), so I think shutdown hook at SALauncher > is not needed. The shutdown ho

Re: RFR: [small, docs] JDK-8240971 Fix CSS styles in some doc comments

This is really nice. Incidentally, it also makes https://bugs.openjdk.java.net/browse/JDK-8234395 less relevant. -Pavel > On 12 Mar 2020, at 20:50, Jonathan Gibbons > wrote: > > Please review a simple fix regarding the non-standard use of some CSS in some > doc comments. > > From the JBS

Re: RFR: [small, docs] JDK-8240971 Fix CSS styles in some doc comments

At some point, we should separate JDK-specific definitions from javadoc-general definitions, using a separate stylesheet. -- Jon On 3/13/20 9:26 AM, Pavel Rappo wrote: This is really nice. Incidentally, it also makes https://bugs.openjdk.java.net/browse/JDK-8234395 less relevant. -Pavel

Re: RFR(L) 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available

HI Chris, overall looks good to me, a few comments though: 1. since you removed vm.hasSAandCanAttach from VMProps, you also need to remove it from all TEST.ROOT files which mention it (test/jdk/TEST.ROOT and test/hotspot/jtreg/TEST.ROOT) so people won't be confused by undefined property and jtr

RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump

Hi, I have updated the webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8237354/webrev.1/ It has the following significant changes: - The jcmd now uses two separate flags. The -gz flag is now a boolean flag which toggles the compression on/off. And the new -gz-level flag can be used to

RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

Hi Martin, thanks a lot for reviewing and the feedback. I'll dig into the details as soon as possible. Looking forward to it :) Thanks, Richard. -Original Message- From: Doerr, Martin Sent: Donnerstag, 12. März 2020 17:28 To: Reingruber, Richard ; 'Robbin Ehn' ; Lindenmaier, Goetz ;