Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

2020-04-04 Thread Mandy Chung
Hi Peter, On 4/4/20 3:58 AM, Peter Levart wrote: Here I think, you are not quite right. First I need to clarify that we are talking about the case where the method reference in above example is not converted to lambda by javac, so the proxy class needs to invoke the superclass method directl

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

2020-04-04 Thread Mandy Chung
On 4/4/20 9:16 AM, Peter Levart wrote: Hi Mandy, Just another observation of the code in InnerClassLambdaMetafactory... For the useImplMethodHandle case you generate the protectedImplMethod static field to hold the MH and a static setter method:     mv = cw.visitMethod(ACC_PRIVATE

Re: RFR(XS) 8242153: ProblemList serviceability/sa/ClhsdbDumpheap.java on OSX

2020-04-04 Thread Chris Plummer
Thanks! On 4/4/20 6:02 AM, Daniel D. Daugherty wrote: Thumbs up. This is a trivial fix. Dan On 4/4/20 4:07 AM, Chris Plummer wrote: Hi, I just added this test, but it often fails due to a pre-existing SA bug on OSX that happens during heap dumps. It needs to be problem listed: diff --gi

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

2020-04-04 Thread Peter Levart
Hi Mandy, Just another observation of the code in InnerClassLambdaMetafactory... For the useImplMethodHandle case you generate the protectedImplMethod static field to hold the MH and a static setter method:     mv = cw.visitMethod(ACC_PRIVATE + ACC_STATIC,

Re: RFR(XS) 8242153: ProblemList serviceability/sa/ClhsdbDumpheap.java on OSX

2020-04-04 Thread Daniel D. Daugherty
Thumbs up. This is a trivial fix. Dan On 4/4/20 4:07 AM, Chris Plummer wrote: Hi, I just added this test, but it often fails due to a pre-existing SA bug on OSX that happens during heap dumps. It needs to be problem listed: diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jt

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

2020-04-04 Thread Peter Levart
Hi Mandy, On 4/3/20 11:32 PM, Mandy Chung wrote: Hi Peter, I added a JBS comment [1] to describe this special case trying to put the story together (let me know if it needs more explanation).   More comment inline below. Thanks, this helps in establishing the historical context. On 4/3/2

RFR(XS) 8242153: ProblemList serviceability/sa/ClhsdbDumpheap.java on OSX

2020-04-04 Thread Chris Plummer
Hi, I just added this test, but it often fails due to a pre-existing SA bug on OSX that happens during heap dumps. It needs to be problem listed: diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt +++ b/test/hotspot/j