Hi Magnus,
It looks good to me.
Thanks,
Serguei
On 4/15/20 06:00, Magnus Ihse Bursie wrote:
Here is an updated version, that avoids the SuppressWarnings for
modelToView:
http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02
(Only change is in SourceCodePanel.java
Looks fine Magnus; thanks,
-Joe
On 4/15/2020 1:18 AM, Magnus Ihse Bursie wrote:
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation
messages, that are trivial to fix and might hide more tricky issues.
This patch
On 4/15/20 1:28 AM, David Holmes wrote:
On 14/04/2020 10:36 pm, coleen.phillim...@oracle.com wrote:
On 4/13/20 10:49 PM, David Holmes wrote:
Hi Coleen,
On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote:
Summary: Do not install async exceptions at_safepoint for each
bytecode.
I'm
On 4/15/20 9:37 PM, David Holmes wrote:
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at
http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8242896
Looks good but ...
Built and ran vmTestbase
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8242896
Looks good but ...
Built and ran vmTestbase RedefineTests which use the protected code.
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8242896
Built and ran vmTestbase RedefineTests which use the protected code.
thanks,
Coleen
Thanks Serguei and Alex!
On 4/15/20 2:40 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
LGTM++
Thanks,
Serguei
On 4/15/20 13:42, Alex Menkov wrote:
Hi Chris,
The fix looks good.
--alex
On 04/15/2020 10:28, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.
Hi Chris,
LGTM++
Thanks,
Serguei
On 4/15/20 13:42, Alex Menkov wrote:
Hi Chris,
The fix looks good.
--alex
On 04/15/2020 10:28, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8230731
http://cr.openjdk.java.net/~cjplummer/8230731/webrev.
Hi Chris,
The fix looks good.
--alex
On 04/15/2020 10:28, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8230731
http://cr.openjdk.java.net/~cjplummer/8230731/webrev.00/index.html
SA reads in memory from the target process as needed. The lo
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8230731
http://cr.openjdk.java.net/~cjplummer/8230731/webrev.00/index.html
SA reads in memory from the target process as needed. The lowest level
API that reads in a page of memory on windows is
WindbgDebuggerLocal.r
Looks good.
/Erik
On 2020-04-15 01:18, Magnus Ihse Bursie wrote:
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation
messages, that are trivial to fix and might hide more tricky issues.
This patch handles the "n
Here is an updated version, that avoids the SuppressWarnings for
modelToView:
http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02
(Only change is in SourceCodePanel.java compared to v01)
/Magnus
On 2020-04-15 14:30, Magnus Ihse Bursie wrote:
On 2020-04-15 12:59, P
On 2020-04-15 12:59, Prasanta Sadhukhan wrote:
Hi Magnus,
Why can't we just use modelToView2D() to get Rectangle2D and then cast
to Rectangle tobe used in scrollRectToVisible() or else use
(int)Rectangle2D.getX(), (int)getY(), getWidth(), getHeight() to
construct a new Rectangle()?
Casting
Hi Magnus,
Why can't we just use modelToView2D() to get Rectangle2D and then cast
to Rectangle tobe used in scrollRectToVisible() or else use
(int)Rectangle2D.getX(), (int)getY(), getWidth(), getHeight() to
construct a new Rectangle()?
Regard
Prasanta
On 15-Apr-20 3:35 PM, Magnus Ihse Bursie
Hi swing-dev,
Do you have any other suggestions for how to resolve the deprecation of
modelToView() in this code?
Basically, the code does this:
Rectangle rect = source.modelToView(offset);
source.scrollRectToVisible(rect);
but scrollRectToVisible() requires a Rectangle (a subt
Hi Magnus,
This one sounds like it needs a Swing/Java2D developer to review it :)
Cheers,
David
On 15/04/2020 7:13 pm, Magnus Ihse Bursie wrote:
After JDK-8242804, a few places remain which are using deprecated
methods. They too should be fixed, and the deprecation warning should no
longer be
Hi Magnus,
This all looks good to me.
Thanks,
David
On 15/04/2020 6:18 pm, Magnus Ihse Bursie wrote:
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation messages,
that are trivial to fix and might hide more trick
After JDK-8242804, a few places remain which are using deprecated
methods. They too should be fixed, and the deprecation warning should no
longer be disabled.
This patch presupposes the fix for JDK-8242804 has been applied
(otherwise we cannot turn the deprecation warning back on).
Some brie
In the quest for getting rid of warning messages in jdk.hotspot.agent,
the time has now come for another major source of deprecation messages,
that are trivial to fix and might hide more tricky issues.
This patch handles the "new Integer(42)" pattern of explicit boxing,
which is deprecated. I
Thank you for taking care about this,
Magnus!
Serguei
On 4/15/20 00:02, Magnus Ihse Bursie wrote:
On
2020-04-15 02:34, serguei.spit...@oracle.com
wrote:
Hi Magnus,
It looks good to me.
On 2020-04-15 02:34, serguei.spit...@oracle.com wrote:
Hi Magnus,
It looks good to me.
Thanks for the review, Serguei!
/Magnus
Thanks,
Serguei
On 4/14/20 14:23, Chris Plummer wrote:
Hi Magnus,
The changes look good. Just one minor issue:
http://cr.openjdk.java.net/~ihse/JDK-8241618-fix-
On 2020-04-14 23:23, Chris Plummer wrote:
Hi Magnus,
The changes look good. Just one minor issue:
http://cr.openjdk.java.net/~ihse/JDK-8241618-fix-unchecked-warnings-for-agent/webrev.02/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Metadata.java.frames.html
Copyright was updated, bu
22 matches
Mail list logo
