Re: RFR: JDK-8225056 VM support for sealed classes

2020-05-18 Thread David Holmes
Hi Harold, Adding serviceability-dev for the serviceability related changes. Nit: "VM support for sealed classes" This RFR covers the VM, core-libs, serviceability and even some langtools tests. AFAICS only the javac changes are not included here so when and where will they be reviewed and un

Re: [8u] RFR: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

2020-05-18 Thread Andrew Hughes
On 18/05/2020 10:08, Severin Gehwolf wrote: > Hi, > > Please review this 8u backport of JDK-8150986. It's a clean backport > except for the copyright change. In the 8u252 cycle JDK-8144732 got > backported which now makes the test fail. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8150986

Re: RFR: 8241080: Consolidate signature parsing code in serviceability tools

2020-05-18 Thread Chris Plummer
Looks good. thanks, Chris On 5/14/20 1:33 PM, Daniil Titov wrote: Hi Serguei and Chris, Please review a new version of the change [1] that addresses your comments. Testing: Mach5 tier1-tier5 tests successfully passed. Regarding CR for the JDWP spec issues related to missing type information

RFR: 8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently

2020-05-18 Thread Daniil Titov
Please review the change [1] that fixes an intermittent failure of the test. This test creates and destroys a given number of daemon/user threads and validates the count of those started/stopped threads against values returned from ThreadMXBean thread counts. The problem here is that if some in

[8u] RFR: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

2020-05-18 Thread Severin Gehwolf
Hi, Please review this 8u backport of JDK-8150986. It's a clean backport except for the copyright change. In the 8u252 cycle JDK-8144732 got backported which now makes the test fail. Bug: https://bugs.openjdk.java.net/browse/JDK-8150986 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-815

Re: RFR(XS): 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found

2020-05-18 Thread serguei.spit...@oracle.com
On 5/18/20 00:30, serguei.spit...@oracle.com wrote: Hi Coleen and potential reviewers, Now, the webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-redef.2/ has a complete fix for all three failure modes relate

Re: RFR(XS): 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found

2020-05-18 Thread serguei.spit...@oracle.com
Hi Coleen and potential reviewers, Now, the webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-redef.2/ has a complete fix for all three failure modes related to the guarantee about OLD and OBSOLETE methods. The root cause

RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump

2020-05-18 Thread Schmelter, Ralf
Hi Christoph, I've updated the webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8237354/webrev.3/ The significant changes are moving most of the new compression code to its own file, changing to use a single option (see CSR) called -gz with a mandatory compression level and to load the z