Re: RFR JDK-8232222: Set state to 'linked' when an archived class is restored at runtime

Hi Jiangli, Before we spend time on the CSR review, do you have any data that shows the actual benefit of doing this? I am specifically asking about the benefit to JVMTI agents. As I mentioned before, there's an alternative, which is to not use the optimization when JVMTI is enabled. I don't

Re: RFR: 8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently

Hi Alex, Serguei, and Martin, Thank you for your comments. Please review a new version of the fix that addresses them, specifically: 1) Replaces a double loop in checkAllThreadsAlive() with a code that uses collections and containsAll() method. 2) Restores the checks for other ThreadMXBean me

Re: RFR(XS): 8221306: JVMTI spec for FramePop(), MethodExit(), and MethodEnter() could use some cleanup

Thank you, Alex! Serguei On 6/2/20 12:04, Alex Menkov wrote: +1 --alex On 06/01/2020 11:31, Chris Plummer wrote: Hi Serguei, Looks good. thanks, Chris On 5/31/20 1:11 AM, serguei.spit...@oracle.com wrote: Please, review a fix for small spec bug: https://bugs.openjdk.java.net/browse/JDK-

RE: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

Excellent. Thanks! Richard. -Original Message- From: serguei.spit...@oracle.com Sent: Dienstag, 2. Juni 2020 20:02 To: Reingruber, Richard ; serviceability-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net; hotspot-gc-...@openjdk.java.net

Re: RFR(XS): 8221306: JVMTI spec for FramePop(), MethodExit(), and MethodEnter() could use some cleanup

+1 --alex On 06/01/2020 11:31, Chris Plummer wrote: Hi Serguei, Looks good. thanks, Chris On 5/31/20 1:11 AM, serguei.spit...@oracle.com wrote: Please, review a fix for small spec bug: https://bugs.openjdk.java.net/browse/JDK-8221306 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/20

Re: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

Hi Richard, On 6/2/20 10:57, Reingruber, Richard wrote: Hi Serguei, This looks good to me. Thanks! From an earlier mail: I'm thinking it would be more safe to run full tier5. I guess we're done with reviewing. Would be good if you could run full tier5 now. After that I would like to pu

RE: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

Hi Serguei, > This looks good to me. Thanks! From an earlier mail: > I'm thinking it would be more safe to run full tier5. I guess we're done with reviewing. Would be good if you could run full tier5 now. After that I would like to push. Thanks, Richard. -Original Message- From: ser

Re: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

Hi Richard, This looks good to me. Thanks, Serguei On 5/28/20 09:02, Vladimir Kozlov wrote: Vladimir Ivanov is on break currently. It looks good to me. Thanks, Vladimir K On 5/26/20 7:31 AM, Reingruber, Richard wrote: Hi Vladimir, Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8238585