Re: RFR: [15,docs] JDK-8247958,minor HTML errors in com.sun.jdi

Looks good. Thanks, David On 20/06/2020 1:08 pm, Jonathan Gibbons wrote: Please review a couple of minor HTML errors (missing end tags) in a couple of classes.  These should be the last of the fixes for com.sun.jdi in this round of cleanup. -- Jon JBS:

RFR: [15,docs] JDK-8247958,minor HTML errors in com.sun.jdi

Please review a couple of minor HTML errors (missing end tags) in a couple of classes.  These should be the last of the fixes for com.sun.jdi in this round of cleanup. -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247958 Patch inline: diff -r 086c7f077fc6

Re: RFR(S): 8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp

Hi Chris, I checked Linux kernel code at a glance, ESRCH seems to be set to errno by default. So I guess it is similar to "generic" error code. https://github.com/torvalds/linux/blob/master/kernel/ptrace.c According to manpage of ptrace(2), it might return errno other than ESRCH. For example,

Re: RFR(S): 8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp

Hello, I've  updated with webrev based on the new finding that a JavaThread cannot be on the ThreadList after its OS thread has been destroyed since the JavaThread removes itself from the ThreadList, and therefore must be running on its OS thread. The logic of the fix is unchanged from the

Re: RFR: JDK-8247784,Bad link causes invalid documentation

+1.  Thanks for fixing this. Mandy On 6/18/20 8:16 PM, Jonathan Gibbons wrote: resend, with correct subject line On 6/18/20 8:12 PM, Jonathan Gibbons wrote: Please review some changes to fix typos in some recent doc updates. In two places, ${docRoot} is used instead of {@docRoot} -- Jon

Re: RFR(S): 8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp

Hi Chris, On 19/06/2020 8:55 am, Chris Plummer wrote: On 6/18/20 1:43 AM, David Holmes wrote: On 18/06/2020 4:49 pm, Chris Plummer wrote: On 6/17/20 10:29 PM, David Holmes wrote: On 18/06/2020 3:13 pm, Chris Plummer wrote: On 6/17/20 10:09 PM, David Holmes wrote: On 18/06/2020 2:33 pm,

Re: RFR: https://bugs.openjdk.java.net/browse/JDK-8247784

Looks good and trivial. Thanks, David On 19/06/2020 1:12 pm, Jonathan Gibbons wrote: Please review some changes to fix typos in some recent doc updates. In two places, ${docRoot} is used instead of {@docRoot} -- Jon JBS: https://bugs.openjdk.java.net/browse/JDK-8247784 Patch: diff -r

Re: Qu: JDK-8247901, Multiple conflicting @return for FlightRecorderMXBean

Hi Jon, Redirecting to hotspot-jfr-dev Cheers, David On 19/06/2020 12:45 pm, Jonathan Gibbons wrote: I have filed JDK-8247901, to cover an issue detected by doclint, regarding two conflicting @return descriptions for a single method. I can make the fix, if you want, but I need confirmation

Re: RFR: 8247729: GetObjectMonitorUsage() might return inconsistent information

Thanks Serguei! Yasumasa On 2020/06/19 15:25, serguei.spit...@oracle.com wrote: Hi Yasumasa, Looks good. Thanks, Serguei On 6/18/20 18:56, Yasumasa Suenaga wrote: Hi Serguei, I tested vmTestbase/nsk/jdi with webrev.03, all tests work fine on my laptop.  

Re: RFR: JDK-8247784,Bad link causes invalid documentation

Hi Jon, Looks good. Thanks, Serguei On 6/18/20 20:16, Jonathan Gibbons wrote: resend, with correct subject line On 6/18/20 8:12 PM, Jonathan Gibbons wrote: Please review some

Re: RFR: 8247729: GetObjectMonitorUsage() might return inconsistent information

Hi Yasumasa, Looks good. Thanks, Serguei On 6/18/20 18:56, Yasumasa Suenaga wrote: Hi Serguei, I tested vmTestbase/nsk/jdi with webrev.03, all tests work fine on my laptop.   http://cr.openjdk.java.net/~ysuenaga/JDK-8247729/webrev.03/ Thanks, Yasumasa On 2020/06/19 9:22,

Re: RFR: JDK-8247784,Bad link causes invalid documentation

Looks good. On 19/06/2020 04:16, Jonathan Gibbons wrote: resend, with correct subject line On 6/18/20 8:12 PM, Jonathan Gibbons wrote: Please review some changes to fix typos in some recent doc updates. In two places, ${docRoot} is used instead of {@docRoot} -- Jon JBS: