I've corrected this change with Kim's and David's feedback, and retested
with tier1-3. This is much better.
incremental webrev at
http://cr.openjdk.java.net/~coleenp/2020/8247878.02.incr/webrev
full webrev at http://cr.openjdk.java.net/~coleenp/2020/8247878.02/webrev
Thanks,
Coleen
On 7/
Hi Kim, Thank you for reviewing this.
On 7/17/20 5:02 AM, Kim Barrett wrote:
On Jul 16, 2020, at 11:01 AM, coleen.phillim...@oracle.com wrote:
Summary: Use OopStorage for strong oops stored with memory and thread sampling
and dumping, and remove oops_do and GC calls.
These use OopStorageSet:
Hi David, thank you for reviewing this.
On 7/17/20 12:13 AM, David Holmes wrote:
Hi Coleen,
On 17/07/2020 1:01 am, coleen.phillim...@oracle.com wrote:
Summary: Use OopStorage for strong oops stored with memory and thread
sampling and dumping, and remove oops_do and GC calls.
These use OopS
Hi Richard,
> I'll answer to the obvious things in this mail now.
> I'll go through the code thoroughly again and write
> a review of my findings thereafter.
As promised a detailed walk-throug, but without any major findings:
c1_IR.hpp: ok
ci_Env.h|cpp: ok
compiledMethod.cpp, nmethod.cpp: ok
debu
> On Jul 16, 2020, at 11:01 AM, coleen.phillim...@oracle.com wrote:
>
> Summary: Use OopStorage for strong oops stored with memory and thread
> sampling and dumping, and remove oops_do and GC calls.
>
> These use OopStorageSet::vm_global() OopStorage for now. I'll change the
> thread sampling
