Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

2020-07-19 Thread Kim Barrett
> On Jul 20, 2020, at 1:53 AM, David Holmes wrote: > > Hi Kim, > > Thanks for looking at this. > > Updated webrev at: > > http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/ Looks good. > > On 20/07/2020 3:22 pm, Kim Barrett wrote: >>> On Jul 20, 2020, at 12:16 AM, David Holmes wrote: >

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

2020-07-19 Thread David Holmes
Hi Kim, Thanks for looking at this. Updated webrev at: http://cr.openjdk.java.net/~dholmes/8249650/webrev.v2/ On 20/07/2020 3:22 pm, Kim Barrett wrote: On Jul 20, 2020, at 12:16 AM, David Holmes wrote: Subject line got truncated by accident ... On 20/07/2020 11:06 am, David Holmes wrote:

Re: RFR 8247878: Move Management strong oops to OopStorage

2020-07-19 Thread Kim Barrett
> On Jul 20, 2020, at 12:47 AM, David Holmes wrote: > > Hi Coleen, > > On 18/07/2020 7:29 am, coleen.phillim...@oracle.com wrote: >> I've corrected this change with Kim's and David's feedback, and retested >> with tier1-3. This is much better. > > Yes this is better. :) Thanks to Kim for clar

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

2020-07-19 Thread Kim Barrett
> On Jul 20, 2020, at 12:16 AM, David Holmes wrote: > > Subject line got truncated by accident ... > > On 20/07/2020 11:06 am, David Holmes wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8249650 >> webrev: http://cr.openjdk.java.net/~dholmes/8249650/webrev/ >> This is a simple cleanup t

Re: RFR 8247878: Move Management strong oops to OopStorage

2020-07-19 Thread David Holmes
Hi Coleen, On 18/07/2020 7:29 am, coleen.phillim...@oracle.com wrote: I've corrected this change with Kim's and David's feedback, and retested with tier1-3.  This is much better. Yes this is better. :) Thanks to Kim for clarifying the acquire/release issue. LGTM. Thanks, David - inc

Re: RFR (M) 8249650: Optimize JNIHandle::make_local thread variable usage

2020-07-19 Thread David Holmes
Subject line got truncated by accident ... On 20/07/2020 11:06 am, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8249650 webrev: http://cr.openjdk.java.net/~dholmes/8249650/webrev/ This is a simple cleanup that touches files across a number of VM areas - hence the cross-pos

RFR (M) 8249650: Optimize JNIHandle::make_local thread variable

2020-07-19 Thread David Holmes
Bug: https://bugs.openjdk.java.net/browse/JDK-8249650 webrev: http://cr.openjdk.java.net/~dholmes/8249650/webrev/ This is a simple cleanup that touches files across a number of VM areas - hence the cross-post. Whilst working on a different JNI fix I noticed that in most cases in jni.cpp we we