Re: RFR (trivial): 8250826: jhsdb does not work with coredump which comes from Substrate VM

2020-07-31 Thread Chris Plummer
On 7/30/20 6:18 PM, Yasumasa Suenaga wrote: Hi Chris, On 2020/07/31 7:29, Chris Plummer wrote: Hi Yasumasa, If I understand correctly we first call add_map_info() for all the PT_LOAD segments in the core file. We then process all the library segments, calling add_map_info() for them if the t

RFR(L/S) : 8249030 : clean up FileInstaller $test.src $cwd in vmTestbase_nsk_jdi tests

2020-07-31 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8249030/webrev.00 > 2258 lines changed: 0 ins; 1144 del; 1114 mod; Hi all, could you please review the clean-up of nsk_jdi tests? from main issue(8204985) : > all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to > mimic old test harne

RFR(XXS): 8249150: SA core file tests sometimes time out on OSX with "java.io.IOException: App waiting timeout"

2020-07-31 Thread Chris Plummer
Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8249150 http://cr.openjdk.java.net/~cjplummer/8249150/webrev.00/index.html The tests in question use recently added LingeredApp support for dumping a core file. On OSX a core file dump sometimes takes a very long

Re: JDK 16 RFR of JDK-8250640: Address reliance on default constructors in jdk.jdi

2020-07-31 Thread serguei.spit...@oracle.com
Hi Joe, It looks good to me. Thanks, Serguei On 7/27/20 23:45, Alan Bateman wrote: On 27/07/2020 21:42, Joe Darcy wrote: Hello, Another module, another set of default constructors to replace with explicit ones. Please review the code changes and CSR to address:     JDK-8250640: Address

RE: RFR(S) 8249293: Unsafe stackwalk in VM_GetOrSetLocal::doit_prologue()

2020-07-31 Thread Reingruber, Richard
Hi, I rebase the fix after JDK-8250042. New webrev: http://cr.openjdk.java.net/~rrich/webrevs/8249293/webrev.2/ Thanks, Richard. -Original Message- From: serviceability-dev On Behalf Of Reingruber, Richard Sent: Montag, 27. Juli 2020 09:45 To: serguei.spit...@oracle.com; serviceabilit