RE: RFR(S) 8249293: Unsafe stackwalk in VM_GetOrSetLocal::doit_prologue()

2020-08-17 Thread Reingruber, Richard
Thanks David, have a good time! Richard. -Original Message- From: David Holmes Sent: Dienstag, 18. August 2020 07:20 To: Reingruber, Richard ; serguei.spit...@oracle.com; serviceability-dev@openjdk.java.net Subject: Re: RFR(S) 8249293: Unsafe stackwalk in VM_GetOrSetLocal::doit_prologu

Re: RFR(S) 8249293: Unsafe stackwalk in VM_GetOrSetLocal::doit_prologue()

2020-08-17 Thread David Holmes
Hi Richard, The test seems a lot clearer to me now. I'll leave it to you are Serguei to iron out any last wrinkles as I am disappearing on vacation for a week after today. But you have my Review. Thanks, David On 15/08/2020 12:06 am, Reingruber, Richard wrote: Hi Serguei, thanks for the fe

Re: RFR (S): JDK-8250630 JdwpListenTest.java fails on Alpine Linux

2020-08-17 Thread serguei.spit...@oracle.com
Hi Dmitry, I agree with Alex, it is better to rename compareIPv6Addr to isEqualIPv6Addr. 705 static int compareIPv6Addr(struct addrinfo *ai, struct in6_addr in6Addr) 706 { 707 708 if (ai->ai_addr->sa_family == AF_INET6) { 709 const struct sockad

Ping: RFR: JDK-8234808: jdb quoted option parsing broken

2020-08-17 Thread Alex Menkov
On 08/07/2020 15:09, Alex Menkov wrote: Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8234808 webrev: http://cr.openjdk.java.net/~amenkov/jdk16/jdb_options/webrev/ Some background: when jdb launches debuggee process it passes java options from "options" value for

Re: RFR (S): JDK-8250630 JdwpListenTest.java fails on Alpine Linux

2020-08-17 Thread Alex Menkov
Hi Dmitry, In general the fix looks good to me. Some notes: please update copyright year; I'd rename compareIPv6Addr to something like isEqualIPv6Addr or equalsIPv6Addr; Also both parameters should be const; 737 // Try to find bind address of preferred address familty first "familty" ->

Re: Protecting references from GC in JDI tests

2020-08-17 Thread Daniel D. Daugherty
Aditya, I think you've found the right alias... A similar observation was made here: http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-March/030635.html It looks like that conversation didn't go beyond Egor's original message and Chris P's reply. My recommendation would be to onl

Protecting references from GC in JDI tests

2020-08-17 Thread Aditya Mandaleeka
Hi serviceability-dev, I hope this is the right list for this topic, but feel free to redirect if not... It appears that there are jtreg tests that exercise JDI functionality without protecting target objects from being GC'd. An example of this is com/sun/jdi/VarargsTest.java, where references

Re: RFR(s): 8248295: serviceability/jvmti/CompiledMethodLoad/Zombie.java failure with Graal

2020-08-17 Thread Vladimir Kozlov
Hi Fairoz, How you determine that +10Mb is enough with Graal? Thanks, Vladimir On 8/17/20 5:46 AM, Fairoz Matte wrote: Hi, Please review this small test change to work with Graal. Background: Graal require more code cache compared to c1/c2. but the test case always set it to 20MB

Re: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits(Internet mail)

2020-08-17 Thread 傅杰
Ping… Any comments? Thanks. Best regards, Jie From: serviceability-dev on behalf of "jiefu(傅杰)" Date: Friday, August 7, 2020 at 7:44 AM To: "serviceability-dev@openjdk.java.net" Subject: Re: RFR: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits(Internet mail) FYI

RFR(s): 8248295: serviceability/jvmti/CompiledMethodLoad/Zombie.java failure with Graal

2020-08-17 Thread Fairoz Matte
Hi, Please review this small test change to work with Graal. Background: Graal require more code cache compared to c1/c2. but the test case always set it to 20MB. This may not be sufficient when running graal. Default configuration for ReservedCodeCacheSize = 250MB With graal enabled,

[Discussion] Expected behavior of combining "all" and "live" options of jmap

2020-08-17 Thread 臧琳
Dear all, we found the jmap’s histo/dump command could accept "live" and "all" options together, and the specification does not describe what is the expected behavior of it. I have tried that when these two options used together, the "live" takes effect, no matter what sequ

RFR (S): JDK-8250630 JdwpListenTest.java fails on Alpine Linux

2020-08-17 Thread Dmitry Samersoff
Hello Everybody, Please review the fix: https://cr.openjdk.java.net/~dsamersoff/JDK-8250630/webrev.01/ Binding to IN6ADDR_ANY allow us to serve both IPv4 and IPv6 connections, but binding to mapped INADDR_ANY (:::0.0.0.0) allow us to serve IPv4 connections only. So make sure, that IN6AD