Hi Richard,
I read through your change again. It looks good to me now.
The new naming and additional comments make it
easier to read I think, thank you.
One small thing:
deoptimization.cpp, l. 1503
You don't really need the brackets. Two lines below you don't use them either.
(No webrev needed)
Hi Lin,
LGTM++
Thanks,
Serguei
On 8/21/20 14:01, Daniel D. Daugherty wrote:
On 8/20/20 7:42 PM, linzang(臧琳) wrote:
After discuss with paul, it is not a good idea to combine two fix
together in one webrev. I will handle them separately
Please help review the updated one. Thanks!
Webrev:
On 8/20/20 7:42 PM, linzang(臧琳) wrote:
After discuss with paul, it is not a good idea to combine two fix together in
one webrev. I will handle them separately
Please help review the updated one. Thanks!
Webrev: http://cr.openjdk.java.net/~lzang/8252101/webrev.01/
src/jdk.jcmd/share/cla
On 8/21/20 11:07, serguei.spit...@oracle.com wrote:
Hi Paul,
Sorry, Volker, for using this "indirection".
I hope, Paul redirected my "Hi" to you. :)
Thanks,
Serguei
Thank you for explanation.
Thanks,
Serguei
On 8/21/20 10:54, Volker Simonis wrote:
On Thu, Aug 20, 2020 at 10:06 PM sergue
Lgtm.
Paul
From: "linzang(臧琳)"
Date: Thursday, August 20, 2020 at 5:03 PM
To: "serviceability-dev@openjdk.java.net"
, "Hohensee, Paul"
Subject: RFR(s):8251848: JMap.histo() and JMap.dump() should parse
sub-arguments similarly
Dear All,
Please help review the patch of 8251848, Thanks
Hi Paul,
Thank you for explanation.
Thanks,
Serguei
On 8/21/20 10:54, Volker Simonis wrote:
On Thu, Aug 20, 2020 at 10:06 PM serguei.spit...@oracle.com
wrote:
Hi Paul,
I was also wondering if there is a compatibility risk involved with the
JMM_VERSION change.
So, thanks to Volker for aski
On Thu, Aug 20, 2020 at 10:06 PM serguei.spit...@oracle.com
wrote:
>
> Hi Paul,
>
> I was also wondering if there is a compatibility risk involved with the
> JMM_VERSION change.
> So, thanks to Volker for asking these questions.
>
> One more question.
> I do not see a backport of the
> src/jdk.m
Hi Richard,
It looks good, thank you for the update!
These two lines can be removed:
391 jvmtiEnv* jvmti;
406 ::jvmti = jvmti;
No need in another webrev if you fix it.
Thanks,
Serguei
On 8/21/20 09:09, Rei
Hi Serguei,
I have prepared a new webrev based on your suggestions.
Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8249293/webrev.6/
Delta: http://cr.openjdk.java.net/~rrich/webrevs/8249293/webrev.6.inc/
Thanks,
Richard.
__
From: serguei.spit...@oracle.com
Sent: Freitag, 21. August 20
Hi Richard,
Thank you for the update, it looks really nice.
Just several more minor comments though (I hope, the last ones).
> Should I rename the variable to spinWaitCycles or something
similar?
Yes, waitCycles would be better an
10 matches
Mail list logo
