Re: 8242427: JVMTI frame pop operations should use Thread-Local Handshakes

2020-08-25 Thread Patricio Chilano
Hi Yasumasa, On 8/23/20 11:40 PM, Yasumasa Suenaga wrote: Hi all, I want to hear your opinions about the change for JDK-8242427. I'm trying to migrate following operations to direct handshake.     - VM_UpdateForPopTopFrame     - VM_SetFramePop     - VM_GetCurrentLocation Some operations (VM_

RE: RFR/RFA (M): 8185003: JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

2020-08-25 Thread Hohensee, Paul
:) New webrevs following Volker's suggestion. http://cr.openjdk.java.net/~phh/8185003/webrev.8u.jdk.06/ http://cr.openjdk.java.net/~phh/8185003/webrev.8u.hotspot.06/ Passes jdk/test/com/sun/management jdk/test/java/lang/management jdk/test/sun/management jdk/test/javax/management Paul On 8/2

Re: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits(Internet mail)

2020-08-25 Thread 傅杰
Thanks Claes for your review. Pushed. Best regards, Jie On 2020/8/25, 7:26 PM, "Claes Redestad" wrote: Hi Jie, fix looks good to me! /Claes On 2020-08-25 04:12, jiefu(傅杰) wrote: > Thanks Serguei for your review. > > Claes, are you okay with this chan

Re: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits(Internet mail)

2020-08-25 Thread Claes Redestad
Hi Jie, fix looks good to me! /Claes On 2020-08-25 04:12, jiefu(傅杰) wrote: Thanks Serguei for your review. Claes, are you okay with this change: http://cr.openjdk.java.net/~jiefu/8251155/webrev.00/ Thanks. Best regards, Jie

RE: RFR(S) 8249293: Unsafe stackwalk in VM_GetOrSetLocal::doit_prologue()

2020-08-25 Thread Reingruber, Richard
Hi Serguei, thanks for your review. > These two lines can be removed: > 391 jvmtiEnv* jvmti; > 406 ::jvmti = jvmti; > No need in another webrev if you fix it. I've made this change and fixed the copyright year in jvmtiImpl.hpp. Unfortunately I got no results from the submit repo [1]. I've