http://cr.openjdk.java.net/~iignatyev//8252532/webrev.00
> 145 lines changed: 28 ins; 22 del; 95 mod;
Hi all,
could you please review this trivial clean up which replaces
System.getProperty("test.nativepath") w/ Utils.TEST_NATIVE_PATH where
appropriate?
while updating these files, I've also c
On 2020/08/29 5:54, Patricio Chilano wrote:
Hi Yasumasa,
On 8/27/20 10:18 PM, Yasumasa Suenaga wrote:
Hi Patricio,
On 2020/08/27 15:20, Patricio Chilano wrote:
Hi Yasumasa,
On 8/26/20 8:57 PM, Yasumasa Suenaga wrote:
Hi Patricio,
Thanks for your review, but webrev.00 has been rotten.
Can y
Hi Yasumasa,
On 8/27/20 10:18 PM, Yasumasa Suenaga wrote:
Hi Patricio,
On 2020/08/27 15:20, Patricio Chilano wrote:
Hi Yasumasa,
On 8/26/20 8:57 PM, Yasumasa Suenaga wrote:
Hi Patricio,
Thanks for your review, but webrev.00 has been rotten.
Can you review webrev.02?
webrev: http://cr.ope
Hi Dmitry,
LGTM++
Thanks,
Serguei
On 8/28/20 13:10, Alex Menkov wrote:
Hi Dmitry,
Looks good to me.
2 minor nits (no new webrev required):
- copyright year
- indentation in lines 763 and 766
--alex
On 08/27/2020 08:03, Dmitry Samersoff wrote:
Hello Everybody,
http://cr.openjdk.java.net/~
Hi Dmitry,
Looks good to me.
2 minor nits (no new webrev required):
- copyright year
- indentation in lines 763 and 766
--alex
On 08/27/2020 08:03, Dmitry Samersoff wrote:
Hello Everybody,
http://cr.openjdk.java.net/~dsamersoff/JDK-8250630/webrev.02/
Webrev is updated, all comments accepted
Hi David,
good point, parseArguments (or rather checkOption) does indeed validate that
passed option is valid and has a valid value, yet for many options all values
are treated as valid, so ill-formed command lines like
`-debugee.vmkeys="${test.vm.opts} ${test.java.opts} -transport.address=dyn
Hi,
we have seen the following fatal error more than 50 times since 2020-05-25 in
various JCK tests vm/jvmti.
fatal error: String conversion failure: [check] ExitLock destroyed
-->[check] ExitLock exited
(followed by garbage output)
8166358: Re-enable String verification in java_lang_String:
thanks Serguei, pushed.
-- Igor
> On Aug 28, 2020, at 12:39 AM, serguei.spit...@oracle.com wrote:
>
> Hi Igor,
>
> It looks good and trivial.
>
> Thanks,
> Serguei
>
>
> On 8/26/20 16:59, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8252401/webrev.00
>>> 6 lines changed: 5
Hi Yasumasa,
then this was a misunderstanding. I thought you were saying you covered all vm
operations in the JVMTI subsystem that can be replaced with handshakes.
I wanted to state that I think that local variable access does not require
global synchronization (i.e. a safepoint) and that it is f
Hi Richard,
On 2020/08/28 17:54, Reingruber, Richard wrote:
Hi Yasumasa,
VM_DeoptimizeFrame can be replaced too I'd think.
The scope of this change is JVMTI, so I don't want to change VM_DeoptimizeFrame
now.
Of course it would be nice if other VM operations (includes VM_DeoptimizeFrame)
are
Hi Yasumasa,
VM_DeoptimizeFrame can be replaced too I'd think.
Cheers, Richard.
-Original Message-
From: Yasumasa Suenaga
Sent: Freitag, 28. August 2020 10:42
To: Reingruber, Richard ; David Holmes
; serviceability-dev
Subject: Re: 8242427: JVMTI frame pop operations should use Thre
Hi Richard,
On 2020/08/28 17:11, Reingruber, Richard wrote:
Hi David, hi Yasumasa,
Unfortunately I do not have any benchmark for this change, however I think it is
worth to do it for consistency. All of VM operations which do not need global
lock in JVMTI are replaced to direct handshake if th
Hello Sergei,
I decided not to add extra check here, if IPv6 is not enabled in
general, JDWP will not work at all and it's the only possibility for
inet_pton to fail.
>> Except:
> The error code from the inet_pton is not checked.
inet_pton performs conversion of the constant value in our cas
Hi David, hi Yasumasa,
> Unfortunately I do not have any benchmark for this change, however I think it
> is
> worth to do it for consistency. All of VM operations which do not need global
> lock in JVMTI are replaced to direct handshake if this enhancement is merged.
VM_GetOrSetLocal can be repl
Thanks a lot!
Richard.
-Original Message-
From: Lindenmaier, Goetz
Sent: Freitag, 28. August 2020 08:38
To: Reingruber, Richard ;
serviceability-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: RE: RFR(L) 8227745: Enable Escape
Hi Igor,
It looks good and trivial.
Thanks,
Serguei
On 8/26/20 16:59, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8252401/webrev.00
6 lines changed: 5 ins; 0 del; 1 mod;
Hi all,
could you please review this trivial patch which adds
j.t.l.Utils.TEST_NATIVE_PATH static field
16 matches
Mail list logo
