Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

Hi David, I thought "Exactly one call to a start-up function is made per agent." means "per -agentlib / -agentpath". Actually we can see following behavior: source code (README.md is in Japanese, sorry): https://github.com/YaSuenag/jvmti-examples/tree/master/helloworld Attach same agent 4

Re: RFR: 8242427: JVMTI frame pop operations should use Thread-Local Handshakes

Hi Serguei, On 2/09/2020 4:11 pm, serguei.spit...@oracle.com wrote: Hi Yasumasa, It seems to me your update for sync with the JvmtiThreadState_lock is incorrect. Let me explain it. The original design was that the functions is_frame_pop, set_frame_pop, clear_frame_pop and clear_to_frame_pop

Re: RFR: 8242427: JVMTI frame pop operations should use Thread-Local Handshakes

Hi Yasumasa, It seems to me your update for sync with the JvmtiThreadState_lock is incorrect. Let me explain it. The original design was that the functions is_frame_pop, set_frame_pop, clear_frame_pop and clear_to_frame_pop are always called eit

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

On 2/09/2020 3:47 pm, Yasumasa Suenaga wrote: Hi David, On 2020/09/02 14:00, David Holmes wrote: Hi Yasumasa, On 1/09/2020 11:42 pm, Yasumasa Suenaga wrote: Hi all, Please review this change:    JBS: https://bugs.openjdk.java.net/browse/JDK-8252657    webrev: http://cr.openjdk.java.net/~ysu

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

Hi David, On 2020/09/02 14:00, David Holmes wrote: Hi Yasumasa, On 1/09/2020 11:42 pm, Yasumasa Suenaga wrote: Hi all, Please review this change:    JBS: https://bugs.openjdk.java.net/browse/JDK-8252657    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8252657/webrev.00/ I tried to attach

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

Hi Yasumasa, On 1/09/2020 11:42 pm, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8252657   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8252657/webrev.00/ I tried to attach JVMTI agent which returns JNI_ERR in Agent_OnUnload

Re: RFR: 8242427: JVMTI frame pop operations should use Thread-Local Handshakes

Hi Yasumasa, On 9/1/20 21:17, Yasumasa Suenaga wrote: Hi David, On 2020/09/02 13:13, David Holmes wrote: Hi Yasumasa, On 31/08/2020 7:10 pm, Yasumasa Suenaga wrote: Hi David, I uploaded new webrev. Could you review again?    http://cr.openjdk.java.net/~ysuenaga/JDK-8242427/webrev.04/ Thi

Re: RFR: 8242427: JVMTI frame pop operations should use Thread-Local Handshakes

Hi David, On 2020/09/02 13:13, David Holmes wrote: Hi Yasumasa, On 31/08/2020 7:10 pm, Yasumasa Suenaga wrote: Hi David, I uploaded new webrev. Could you review again?    http://cr.openjdk.java.net/~ysuenaga/JDK-8242427/webrev.04/ This webrev includes two changes:    1. Use assert_lock_str

Re: RFR: 8242427: JVMTI frame pop operations should use Thread-Local Handshakes

Hi Yasumasa, On 31/08/2020 7:10 pm, Yasumasa Suenaga wrote: Hi David, I uploaded new webrev. Could you review again?   http://cr.openjdk.java.net/~ysuenaga/JDK-8242427/webrev.04/ This webrev includes two changes:   1. Use assert_lock_strong() for JvmtiThreadState_lock    http://hg.ope

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

Thanks Serguei! Yasumasa On 2020/09/02 12:28, serguei.spit...@oracle.com wrote: Hi Yasumasa, It looks good to me. Thanks, Serguei On 9/1/20 15:28, Yasumasa Suenaga wrote: On 2020/09/02 1:00, Daniel D. Daugherty wrote: On 9/1/20 9:42 AM, Yasumasa Suenaga wrote: Hi all, Please review this

Re: RFR(S):8252629:jmap histo should accept "parallel" option without any specified value(Internet mail)

Hi Lin, Thank you for double-checking it. Thanks, Serguei On 9/1/20 20:26, linzang(臧琳) wrote: Hi Serguei, Thanks for your reminder! Yes, just checked we have discussed that before. I will close the bug. BRs, Lin On Sep 2, 2020, at 11:22 AM, "serguei.spit...@oracle.com" wrote:

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

Hi Yasumasa, It looks good to me. Thanks, Serguei On 9/1/20 15:28, Yasumasa Suenaga wrote: On 2020/09/02 1:00, Daniel D. Daugherty wrote: On 9/1/20 9:42 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8252657   webrev: http://

Re: RFR(S):8252629:jmap histo should accept "parallel" option without any specified value(Internet mail)

Hi Serguei, Thanks for your reminder! Yes, just checked we have discussed that before. I will close the bug. BRs, Lin > On Sep 2, 2020, at 11:22 AM, "serguei.spit...@oracle.com" > wrote: > > Hi Lin, > > I agree with David. > If I remember correctly, we already discussed this in the

Re: RFR(S):8252629:jmap histo should accept "parallel" option without any specified value

Hi Lin, I agree with David. If I remember correctly, we already discussed this in the CSR for parallel flag and decided it should not be accepted without a value. Thanks, Serguei On 9/1/20 16:51, David Holmes wrote: Hi Lin, On 1/09/2020 7:06 pm, linzang(臧琳) wrote: Hi All,   Please he

Re: RFR(T) : 8252532 : use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")

thanks Serguei, David, pushed. -- Igor > Hi Igor, > > The update looks good. > > Thanks, > Serguei > On Sep 1, 2020, at 4:58 PM, David Holmes wrote: > > Hi Igor, > > Changes seem fine (incremental webrev didn't show them all though). > > There are other pre-existing indentation issues in

Re: RFR(S) : 8252402 : rewrite vmTestbase/nsk/jvmti/Allocate/alloc001 shell test to Java

thanks Alex, pushed. -- Igor > On Aug 31, 2020, at 3:37 PM, Alex Menkov wrote: > > I suppose with WSL cygwin is not required. > But it should be OK as well. > LGTM. > > --alex > > On 08/31/2020 15:03, Igor Ignatyev wrote: >> Hi Alex, >> AFAIK, cygwin always was and still is a requirement for

Re: RFR(S):8252629:jmap histo should accept "parallel" option without any specified value(Internet mail)

Dear David, Thanks for your comments! At present the parallal processing (with default parallel number) of jmap -histo can be used with either "jmap -histo" or "jmap -histo:parallel=0". IMHO it is more intuitive for user to use "jmap -histo:parallel" to get same result. So I thi

Re: RFR(T) : 8252532 : use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")

Hi Igor, The update looks good. Thanks, Serguei On 9/1/20 13:21, Igor Ignatyev wrote: Hi Serguei, David, thanks for your reviews, I've updated the patch to address David's comments:  http

Re: RFR(T) : 8252532 : use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")

Hi Igor, Changes seem fine (incremental webrev didn't show them all though). There are other pre-existing indentation issues in those files but this is fine. Thanks, David On 31/08/2020 2:53 pm, David Holmes wrote: Hi Igor, On 29/08/2020 1:52 pm, Igor Ignatyev wrote: http://cr.openjdk.jav

Re: RFR(S):8252629:jmap histo should accept "parallel" option without any specified value

Hi Lin, On 1/09/2020 7:06 pm, linzang(臧琳) wrote: Hi All, Please help review this small change about jmap -histo:parallel Bug: https://bugs.openjdk.java.net/browse/JDK-8252629 webrev: http://cr.openjdk.java.net/~lzang/8252629/webrev.00/ The problem is that "jmap -histo

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

On 2020/09/02 1:00, Daniel D. Daugherty wrote: On 9/1/20 9:42 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8252657   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8252657/webrev.00/ I tried to attach JVMTI agent which return

Re: RFR(T) : 8252532 : use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")

Hi Serguei, David, thanks for your reviews, I've updated the patch to address David's comments: http://cr.openjdk.java.net/~iignatyev//8252532/webrev.01/ (whole) http://cr.openjdk.java.net/~iignatyev//8252532/webrev.0-1/

Re: RFR/RFA (M): 8185003: JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

Hi, I've re-finalized the CSR after Volker's re-review. See https://bugs.openjdk.java.net/browse/JDK-8251498. It now says we won't update JMM_VERSION. I've also updated the webrevs to reflect the CSR changes and to target 8u282. jdk: http://cr.openjdk.java.net/~phh/8185003/webrev.8u.jdk.07/ ho

Re: RFR(S) : 8252403 : rewrite serviceability/7170638/SDTProbesGNULinuxTest.sh to java

Serguei, Alex, thanks for your reviews, pushed. -- Igor > On Sep 1, 2020, at 1:22 AM, serguei.spit...@oracle.com wrote: > > Hi Igor, > > LGTM++ > I've lost track of what Linux distro's have the systemtap though. :) > > Thanks, > Serguei > > > On 8/31/20 15:29, Alex Menkov wrote: >> Hi Igor,

Re: RFR(S) : 8252477 : nsk/share/ArgumentParser should expect that jtreg "splits" an argument

Serguei, David, thanks for your reviews, pushed. -- Igor > On Sep 1, 2020, at 1:09 AM, serguei.spit...@oracle.com wrote: > > Hi Igor, > > LGTM++ > It is a nice clean. Surprisingly, this code had a lot of typos! > > Thanks, > Serguei > > > On 8/30/20 21:18, David Holmes wrote: >> Hi Igor, >>

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

On 9/1/20 9:42 AM, Yasumasa Suenaga wrote: Hi all, Please review this change:   JBS: https://bugs.openjdk.java.net/browse/JDK-8252657   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8252657/webrev.00/ I tried to attach JVMTI agent which returns JNI_ERR in Agent_OnUnload via JVMTI.agent_loa

RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8252657 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8252657/webrev.00/ I tried to attach JVMTI agent which returns JNI_ERR in Agent_OnUnload via JVMTI.agent_load dcmd. I expected the library would be unlo

Re: Fatal errors when running JCK tests with JDK15/16 debug build

Hi I thought I reported this.  I reenabled the assert that you're hitting.  One of the JCK tests is passing junk to JNI. I don't know why our tests aren't failing this though. Coleen On 9/1/20 1:06 AM, David Holmes wrote: Hi Leonid, On 1/09/2020 10:42 am, leonid.kus...@oracle.com wrote: H

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

> On Sep 1, 2020, at 4:57 AM, David Holmes wrote: > > Hi Eric, > > On 1/09/2020 6:15 pm, Eric Liu wrote: >> Hi all, >> Please review this simple change to fix some compile warnings. >> The newer gcc (gcc-8 or higher) would warn for calls to bounded string >> manipulation functions such as 'strnc

RFR(S):8252629:jmap histo should accept "parallel" option without any specified value

Hi All, Please help review this small change about jmap -histo:parallel Bug: https://bugs.openjdk.java.net/browse/JDK-8252629 webrev: http://cr.openjdk.java.net/~lzang/8252629/webrev.00/ The problem is that "jmap -histo:parallel" command prompt error message " Fail: invalid

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Eric, On 1/09/2020 6:15 pm, Eric Liu wrote: Hi all, Please review this simple change to fix some compile warnings. The newer gcc (gcc-8 or higher) would warn for calls to bounded string manipulation functions such as 'strncpy' that may either truncate the copied string or leave the destinat

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Eric, It looks good to me. Thank you for taking care about it. Thanks, Serguei On 9/1/20 01:15, Eric Liu wrote: Hi all, Please review this simple change to fix some compile warnings. The newer gcc (gcc-8 or higher) would warn for calls to bounded string manipulation functions such as 'st

Re: RFR(T) : 8252532 : use Utils.TEST_NATIVE_PATH instead of System.getProperty("test.nativepath")

Hi Igor, This looks fine to me too. I also agree with David's suggestions. Thanks, Serguei On 8/30/20 21:53, David Holmes wrote: Hi Igor, On 29/08/2020 1:52 pm, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8252532/webrev.00 145 lines changed: 28 ins; 22 del; 95 mod; Hi al

Re: RFR(S) : 8252403 : rewrite serviceability/7170638/SDTProbesGNULinuxTest.sh to java

Hi Igor, LGTM++ I've lost track of what Linux distro's have the systemtap though. :) Thanks, Serguei On 8/31/20 15:29, Alex Menkov wrote: Hi Igor, LGTM --alex On 08/31/2020 12:03, Igor Ignatyev wrote: ping? On Aug 26, 2020, at 10:14 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi all, Please review this simple change to fix some compile warnings. The newer gcc (gcc-8 or higher) would warn for calls to bounded string manipulation functions such as 'strncpy' that may either truncate the copied string or leave the destination unchanged. This patch fixed stringop-truncati

Re: RFR(S) : 8252477 : nsk/share/ArgumentParser should expect that jtreg "splits" an argument

Hi Igor, LGTM++ It is a nice clean. Surprisingly, this code had a lot of typos! Thanks, Serguei On 8/30/20 21:18, David Holmes wrote: Hi Igor, Update looks good. Thanks, David On 29/08/2020 4:18 am, Igor Ignatyev wrote: Hi David, good point, parseArguments (or rather checkOption) does in