On Tue, 8 Sep 2020 04:38:43 GMT, David Holmes wrote:
>> This is a rather large but generally simple cleanup.
>>
>> We use a lot of raw C-style casts to "(JavaThread*)" typically after
>> checking "thread->is_Java_thread()". To simplify
>> this pattern, and make the code look somewhat cleaner we
On Tue, 8 Sep 2020 03:15:10 GMT, Lin Zang wrote:
> - enable parallel heap inspecton for ShenandoahHeap
> - preliminary evaluation:
> Time of jmap histo on (8GB heap with 4GB objects)
> * before: 5.186s
> * after : 1.698s
Thanks, this looks interesting.
I need more time to digest t
> On Sep 8, 2020, at 12:09 AM, David Holmes wrote:
> David Holmes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Used static_cast instead of raw C-style cast
> Moved inline functions to thread.inline.hpp
> Updated #includes to deal with th
> This is a rather large but generally simple cleanup.
>
> We use a lot of raw C-style casts to "(JavaThread*)" typically after checking
> "thread->is_Java_thread()". To simplify
> this pattern, and make the code look somewhat cleaner we introduce a
> convenience function Thread::as_Java_thread(
> This is a rather large but generally simple cleanup.
>
> We use a lot of raw C-style casts to "(JavaThread*)" typically after checking
> "thread->is_Java_thread()". To simplify
> this pattern, and make the code look somewhat cleaner we introduce a
> convenience function Thread::as_Java_thread(
- enable parallel heap inspecton for ShenandoahHeap
- preliminary evaluation:
Time of jmap histo on (8GB heap with 4GB objects)
* before: 5.186s
* after : 1.698s
-
Commit messages:
- 8252104: parallel heap inspection for ShenandoahHeap
Changes: https://git.openjdk.java
Hi Kim,
Thanks for taking a look.
On 8/09/2020 9:23 am, Kim Barrett wrote:
On Sep 7, 2020, at 5:47 PM, David Holmes wrote:
[…]
Commit messages:
- Initial changes for 8252406
Changes: https://git.openjdk.java.net/jdk/pull/37/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=37&range
Hi Robbin,
On 8/09/2020 4:56 am, Robbin Ehn wrote:
When these two methods (set_frame_pop/clear_frame_pop) are called in a
handshake the requesting thread will have lock
the JvmtiThreadState_lock. But the thread executing one of these in the
handshake may not be the owner.
Ouch! We continue t
> On Sep 7, 2020, at 5:47 PM, David Holmes wrote:
>
> […]
> Commit messages:
> - Initial changes for 8252406
>
> Changes: https://git.openjdk.java.net/jdk/pull/37/files
> Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=37&range=00
> Issue: https://bugs.openjdk.java.net/browse/JDK-8252406
On Mon, 7 Sep 2020 14:14:28 GMT, Robbin Ehn wrote:
> When these two methods (set_frame_pop/clear_frame_pop) are called in a
> handshake the requesting thread will have lock
> the JvmtiThreadState_lock. But the thread executing one of these in the
> handshake may not be the owner.
> So we only c
On Mon, 7 Sep 2020 13:37:10 GMT, Aleksey Shipilev wrote:
>> This is a rather large but generally simple cleanup.
>>
>> We use a lot of raw C-style casts to "(JavaThread*)" typically after
>> checking "thread->is_Java_thread()". To simplify
>> this pattern, and make the code look somewhat cleane
This is a rather large but generally simple cleanup.
We use a lot of raw C-style casts to "(JavaThread*)" typically after checking
"thread->is_Java_thread()". To simplify
this pattern, and make the code look somewhat cleaner we introduce a
convenience function Thread::as_Java_thread(),
which ass
On Mon, 7 Sep 2020 05:56:14 GMT, David Holmes wrote:
> This is a rather large but generally simple cleanup.
>
> We use a lot of raw C-style casts to "(JavaThread*)" typically after checking
> "thread->is_Java_thread()". To simplify
> this pattern, and make the code look somewhat cleaner we intr
When these two methods (set_frame_pop/clear_frame_pop) are called in a
handshake the requesting thread will have lock
the JvmtiThreadState_lock. But the thread executing one of these in the
handshake may not be the owner.
So we only check that JvmtiThreadState_lock is locked.
When verifying the
Hi,
I would like to close the review of this change.
It has received a lot of helpful feedback during the process and 2 full
Reviews. Thanks everybody!
I'm planning to push it this week on Thursday as solution for JBS items:
https://bugs.openjdk.java.net/browse/JDK-8227745
https://bugs.openjdk.
On Mon, 7 Sep 2020 11:23:28 GMT, Aleksei Voitylov wrote:
> continuing the review thread from here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
>
>> The download side of using JNI in these tests is that it complicates the
>> setup a bit for those that run jt
continuing the review thread from here
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html
> The download side of using JNI in these tests is that it complicates the
> setup a bit for those that run jtreg directly and/or just build the JDK
> and not the test libraries
Hi Leonid,
the errors were observed in many more vm/jvmti/Get... tests like the following
ones:
vm/jvmti/GetAllThreads/gath001/gath00101/gath00101.html
vm/jvmti/GetAvailableProcessors/gaps001/gaps00101/gaps00101.html
vm/jvmti/GetClassModifiers/gcmo001/gcmo00102/gcmo00102.html
vm/jvmti/GetClassMe
On Mon, 7 Sep 2020 07:25:41 GMT, David Holmes wrote:
>> The format for SAP copyrights in OpenJDK headers should be like:
>> Copyright (c) SAP SE. All rights reserved.
>> or
>> Copyright (c) , SAP SE. All rights reserved.
>>
>> There should not be a comma character (",") before "SAP SE".
>>
>>
On Mon, 7 Sep 2020 07:28:36 GMT, Christoph Langer wrote:
>>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
>>> [nio-dev](mailto:nio-...@openjdk.java.net):_
>>> Looks good to me - and trivial.
>>>
>>> Thanks,
>>> David
>>>
>>> On 7/09/2020 2:22 pm, Christoph Langer
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote:
> The format for SAP copyrights in OpenJDK headers should be like:
> Copyright (c) SAP SE. All rights reserved.
> or
> Copyright (c) , SAP SE. All rights reserved.
>
> There should not be a comma character (",") before "SAP SE".
>
> Thi
On Mon, 7 Sep 2020 04:14:06 GMT, Christoph Langer wrote:
> The format for SAP copyrights in OpenJDK headers should be like:
> Copyright (c) SAP SE. All rights reserved.
> or
> Copyright (c) , SAP SE. All rights reserved.
>
> There should not be a comma character (",") before "SAP SE".
>
> Thi
On Mon, 7 Sep 2020 07:27:39 GMT, Christoph Langer wrote:
>> Marked as reviewed by dholmes (Reviewer).
>
>> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
>> [nio-dev](mailto:nio-...@openjdk.java.net):_
>> Looks good to me - and trivial.
>>
>> Thanks,
>> David
>>
>>
Looks good to me - and trivial.
Thanks,
David
On 7/09/2020 2:22 pm, Christoph Langer wrote:
The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) SAP SE. All rights reserved.
or
Copyright (c) , SAP SE. All rights reserved.
There should not be a comma character (",")
The test case already handles out of memory conditions, but not if the whole
JVM crashes because of it.
This PR has already been discussed on the mailing list:
https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032884.html
@plummercj please review this PR again. I also nee
On 2020-09-04 21:08, Chris Plummer wrote:
+1 for webrev.02
Yes, this does remove the test from tier1 testing, but I think that is
fine for any resourcehogs test. Have you run this through the submit
repo? If so I can use your job to make sure it passes on all our platforms.
I am only an auth
26 matches
Mail list logo
