On Thu, 10 Sep 2020 03:18:23 GMT, David Holmes wrote:
>> This is a rather large but generally simple cleanup.
>>
>> We use a lot of raw C-style casts to "(JavaThread*)" typically after
>> checking "thread->is_Java_thread()". To simplify
>> this pattern, and make the code look somewhat cleaner w
> This is a rather large but generally simple cleanup.
>
> We use a lot of raw C-style casts to "(JavaThread*)" typically after checking
> "thread->is_Java_thread()". To simplify
> this pattern, and make the code look somewhat cleaner we introduce a
> convenience function Thread::as_Java_thread(
Hi Dan,
Thanks for looking at this one.
On 10/09/2020 9:26 am, Daniel D.Daugherty wrote:
On Wed, 9 Sep 2020 14:06:02 GMT, Kim Barrett wrote:
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
Reverted to the original code as the e
- enable parallel heap inspection for ZCollectedHeap
- preliminary evaluation:
Time of jmap histo on 8GB heap with ~5GB objects
* before: 7.103s
* after : 2.734s (with 4 parallel threads)
-
Commit messages:
- 8252105: parallel heap inspection for ZCollectedHeap
Changes: https:
On Wed, 9 Sep 2020 12:48:11 GMT, David Holmes wrote:
>> This is a rather large but generally simple cleanup.
>>
>> We use a lot of raw C-style casts to "(JavaThread*)" typically after
>> checking "thread->is_Java_thread()". To simplify
>> this pattern, and make the code look somewhat cleaner we
On Wed, 9 Sep 2020 23:24:26 GMT, Daniel D. Daugherty wrote:
>> Marked as reviewed by kbarrett (Reviewer).
>
> This is a really nice set of cleanup changes.
>
> I have a few comments.
>
> https://openjdk.github.io/cr/?repo=jdk&pr=37&range=06#frames-33
> 51 if (thread->is_Java_thread())
> 5
On Wed, 9 Sep 2020 14:06:02 GMT, Kim Barrett wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reverted to the original code as the explicit assertion is preferred.
>
> Marked as reviewed by kbarrett (Reviewer).
Thi
Updated @exception with @throws for core-libs, it fixes all open sub-tasks of
JDK-8252536.
Open Subtasks part of this fix are:
1. JDK-8252537
2. JDK-8252539
3. JDK-8252540
4. JDK-8252541
-
Commit messages:
- JDK-8252537 Updated @exception with @throws
Changes: https://git.openjdk.
On Wed, 9 Sep 2020 12:48:11 GMT, David Holmes wrote:
>> This is a rather large but generally simple cleanup.
>>
>> We use a lot of raw C-style casts to "(JavaThread*)" typically after
>> checking "thread->is_Java_thread()". To simplify
>> this pattern, and make the code look somewhat cleaner we
Trimming ...
On 9/09/2020 7:09 pm, Kim Barrett wrote:
src/hotspot/share/gc/shared/concurrentGCBreakpoints.cpp
63 #define assert_Java_thread() \
64 assert(Thread::current()->is_Java_thread(), "precondition")
65
66 void ConcurrentGCBreakpoints::run_to_idle_impl(bool acquiring_control) {
> This is a rather large but generally simple cleanup.
>
> We use a lot of raw C-style casts to "(JavaThread*)" typically after checking
> "thread->is_Java_thread()". To simplify
> this pattern, and make the code look somewhat cleaner we introduce a
> convenience function Thread::as_Java_thread(
Hi David. Thanks for clarifying some bits I was confused abut.
>> src/hotspot/share/jvmci/jvmciEnv.cpp
>> 243 void JVMCIEnv::describe_pending_exception(bool clear) {
>> 244 JavaThread* THREAD = JavaThread::current();
>> This change looks suspicious. The old code used Thread::current() here a
> Hi Richard,
> I suspect this one fell off the radar due to the extended review period.
> The actual review started last December (there was prior discussion
> IIRC) and only seemed to get partial reviews. I only looked at some
> parts. Robbin may have given things a deeper look, but seemed fo
> This is a rather large but generally simple cleanup.
>
> We use a lot of raw C-style casts to "(JavaThread*)" typically after checking
> "thread->is_Java_thread()". To simplify
> this pattern, and make the code look somewhat cleaner we introduce a
> convenience function Thread::as_Java_thread(
Hi Kim,
On 9/09/2020 1:30 pm, Kim Barrett wrote:
On Sep 8, 2020, at 9:27 AM, David Holmes wrote:
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
This is a simpler approach to use the static_cast. Changes:
- Change C-style cast to
15 matches
Mail list logo
