On Wed, 18 Nov 2020 04:04:49 GMT, Chris Plummer wrote:
>> Hi @plummercj,
>> Thanks for your comments!
>>
>>> Are the Attach API changes backwards compatible? You've added a new arg,
>>> but that arg could be passed to an older JVM that doesn't support it (I
>>> think it just gets ignore
On Wed, 18 Nov 2020 01:22:08 GMT, Lin Zang wrote:
> And the old jmap -dump can not accept "gz" option, it fails with error
> message printed, no matter what jvm version it work with.
I just want to clarify what I was referring to. I was not talking about trying
to use gz with the old jmap comm
On Tue, 17 Nov 2020 18:57:10 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revise the uintx format issue for output message
>
> Are the Attach API changes backwards compatible? You've added a new a
On Tue, 17 Nov 2020 18:20:17 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that changes the way how archive
>> regions are managed in general and specifically by the G1 collector, fixing
>> the crashes caused by adding the module graph into the archive in
>>
On Tue, 17 Nov 2020 09:18:20 GMT, Lin Zang wrote:
>> This PR add "gz" option to jmap -dump command to support generate gzipped
>> heap dump.
>>
>> example:
>> jmap -dump:live,gz=1,file=dump.gz
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the
On Mon, 16 Nov 2020 23:00:05 GMT, Alex Menkov wrote:
> OperatingSystemMXBean was changed in jdk14 (see JDK-8226575):
> New methods getTotalMemorySize and getFreeMemorySize were added, old
> getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated.
>
> The fix adds fallbacks for
> Hi all,
>
> can I have reviews for this change that changes the way how archive regions
> are managed in general and specifically by the G1 collector, fixing the
> crashes caused by adding the module graph into the archive in
> [JDK-8244778](https://bugs.openjdk.java.net/browse/JDK-8244778)
On Tue, 17 Nov 2020 15:55:07 GMT, Claes Redestad wrote:
>> Thomas Schatzl has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - sjohanss review
>> - Remove code that "activates" dormant objects as now all active objects
>> are reachable vi
On Tue, 17 Nov 2020 14:51:23 GMT, Kim Barrett wrote:
>> Thomas Schatzl has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - sjohanss review
>> - Remove code that "activates" dormant objects as now all active objects
>> are reachable via t
On Tue, 17 Nov 2020 10:55:19 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that changes the way how archive
>> regions are managed in general and specifically by the G1 collector, fixing
>> the crashes caused by adding the module graph into the archive in
>>
On Tue, 17 Nov 2020 10:55:19 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that changes the way how archive
>> regions are managed in general and specifically by the G1 collector, fixing
>> the crashes caused by adding the module graph into the archive in
>>
On Tue, 17 Nov 2020 10:55:19 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that changes the way how archive
>> regions are managed in general and specifically by the G1 collector, fixing
>> the crashes caused by adding the module graph into the archive in
>>
On Tue, 17 Nov 2020 10:56:44 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 4458:
>>
>>> 4456: heap_region_iterate(&cl);
>>> 4457:
>>> 4458: remove_from_old_gen_sets(0, 0, cl.humongous_regions_reclaimed());
>>
>> Looking at this call and now having three par
On Tue, 17 Nov 2020 10:16:28 GMT, Stefan Johansson wrote:
>> Thomas Schatzl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' of https://git.openjdk.java.net/jdk into
>> 8253081-null-na
> Hi all,
>
> can I have reviews for this change that changes the way how archive regions
> are managed in general and specifically by the G1 collector, fixing the
> crashes caused by adding the module graph into the archive in
> [JDK-8244778](https://bugs.openjdk.java.net/browse/JDK-8244778)
On Mon, 16 Nov 2020 12:33:10 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that changes the way how archive
>> regions are managed in general and specifically by the G1 collector, fixing
>> the crashes caused by adding the module graph into the archive in
>>
> This PR add "gz" option to jmap -dump command to support generate gzipped
> heap dump.
>
> example:
> jmap -dump:live,gz=1,file=dump.gz
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
revise the uintx format issue for output me
This PR add "gz" option to jmap -dump command to support generate gzipped heap
dump.
example:
jmap -dump:live,gz=1,file=dump.gz
-
Commit messages:
- 8256450: Add gz option to jmap to write a gzipped heap dump
Changes: https://git.openjdk.java.net/jdk/pull/1251/files
Webrev
18 matches
Mail list logo