On Sun, 29 Nov 2020 18:03:24 GMT, Andrey Turbanov
wrote:
> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set
> returned by Collections.singleton
Looks good now!
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1505
On Sun, 29 Nov 2020 18:03:24 GMT, Andrey Turbanov
wrote:
> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set
> returned by Collections.singleton
This pull request has now been integrated.
Changeset: d08c612b
Author:Andrey Turbanov
Committer: Aleksey Shipilev
U
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes i
This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
avoid keeping a referent strongly reachable that could cause unnecessary delay
in collecting such object. I only made change in some but not all classes in
core libraries when working with Kim on `Reference::refersTo
On Wed, 25 Nov 2020 21:36:12 GMT, Alex Menkov wrote:
> JdbTest can get exception before jdb field is initialized.
> As Jdb logging does not depend on the instance, made Jdb.log method static
This pull request has now been integrated.
Changeset: c5b32b33
Author:Alex Menkov
URL: https:
On Sun, 29 Nov 2020 18:03:24 GMT, Andrey Turbanov
wrote:
> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set
> returned by Collections.singleton
Hi Andrey,
It looks good - nice simplification.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
On Sun, 29 Nov 2020 18:03:24 GMT, Turbanov Andrey
wrote:
> 8257708: Remove redundant unmodifiableSet wrapper from already immutable set
> returned by Collections.singleton
Changes requested by shade (Reviewer).
Submitted -- https://bugs.openjdk.java.net/browse/JDK-8257708, rename this PR
to
8257708: Remove redundant unmodifiableSet wrapper from already immutable set
returned by Collections.singleton
-
Commit messages:
- 8257708: Remove redundant unmodifiableSet wrapper from already immutable set
returned by Collections.singleton
- [PATCH] Remove redundant unmodifiabl
This PR replaces the withdraw PR #1348. This PR tries to fix the underlying
problem, rather than fix the tests.
The problem is that a number of JDI tests create objects on the debugger side
with calls to `newInstance()`. However, on the debugee side, these new
instances will only be held on to
On Mon, 30 Nov 2020 21:13:05 GMT, Harold Seigel wrote:
> Please review this change to obsolete the deprecated and aliased Trace flags.
> The now empty aliased_logging_flags support was left in arguments.cpp for
> use by trace flags that get deprecated and aliased in the future.
>
> With this
On Wed, 2 Dec 2020 23:00:03 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256718: Obsolete the long term deprecated and aliased Trace flags
>
> Looks good!
>
> Thanks,
> David
Thanks Coleen,
when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump
heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.".
Skip non-java thread stack dump to avoid printing the message.
-
Commit messages:
- 8257668: SA JMap - skip non-java thread stack du
On Tue, 1 Dec 2020 12:33:31 GMT, Per Liden wrote:
>>> Just a friendly ping. Still looking for reviewers for this fix.
>>
>> Until we resolve the discussion in
>> [JDK-8255987](https://bugs.openjdk.java.net/browse/JDK-8255987), I don't
>> think your suggested fix should be applied since it coul
On Fri, 20 Nov 2020 13:23:28 GMT, Per Liden wrote:
> A number of JDI tests create objects on the debugger side with calls to
> `newInstance()`. However, on the debugee side, these new instances will only
> be held on to by a `JNIGlobalWeakRef`, which means they could be collected at
> any time
14 matches
Mail list logo