> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
delete unnecessary print
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new:
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new:
On Tue, 8 Dec 2020 14:00:25 GMT, Richard Reingruber wrote:
>> This fixes a bug in the test test/jdk/com/sun/jdi/EATests.java that caused
>> timeout failures when graal is enabled.
>>
>> The fix is to avoid suspending all threads when a breakpoint is reached and
>> then resume
>> just the main
On Tue, 8 Dec 2020 20:05:24 GMT, Serguei Spitsyn wrote:
>> All the discussion is in the bug and CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8165276
>> https://bugs.openjdk.java.net/browse/JDK-8248189
>> We messed up in JDK-5070281 (JDK 6) and it came to light in JDK 9 when
>> auditing the
> This change have been already reviewed by Mandy, Sundar, Alan and David.
> Please, see the jdk 15 review thread:
>
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>
> Now, the PR approval is needed.
> The push was postponed because the CSR was not approved
On Wed, 9 Dec 2020 16:33:22 GMT, Coleen Phillimore wrote:
> This change handles redefinition during method resolution, by returning the
> new method. It's not needed to reresolve the invocation. See the bug for
> more information.
>
> Tested with tier1-3 and tier8 on linux-x64-debug and
On Wed, 9 Dec 2020 23:06:38 GMT, David Holmes wrote:
>> This change handles redefinition during method resolution, by returning the
>> new method. It's not needed to reresolve the invocation. See the bug for
>> more information.
>>
>> Tested with tier1-3 and tier8 on linux-x64-debug and
On Wed, 9 Dec 2020 16:33:22 GMT, Coleen Phillimore wrote:
> This change handles redefinition during method resolution, by returning the
> new method. It's not needed to reresolve the invocation. See the bug for
> more information.
>
> Tested with tier1-3 and tier8 on linux-x64-debug and
On Wed, 9 Dec 2020 18:44:37 GMT, Harold Seigel wrote:
>> This change handles redefinition during method resolution, by returning the
>> new method. It's not needed to reresolve the invocation. See the bug for
>> more information.
>>
>> Tested with tier1-3 and tier8 on linux-x64-debug and
On Wed, 9 Dec 2020 16:33:22 GMT, Coleen Phillimore wrote:
> This change handles redefinition during method resolution, by returning the
> new method. It's not needed to reresolve the invocation. See the bug for
> more information.
>
> Tested with tier1-3 and tier8 on linux-x64-debug and
On Wed, 9 Dec 2020 06:40:25 GMT, Serguei Spitsyn wrote:
>> src/java.instrument/share/classes/sun/instrument/InstrumentationImpl.java
>> line 501:
>>
>>> 499: String msg = "method " + classname + "." + methodname + "
>>> must be declared public";
>>> 500: throw new
On Wed, 9 Dec 2020 17:21:16 GMT, Serguei Spitsyn wrote:
>> This change handles redefinition during method resolution, by returning the
>> new method. It's not needed to reresolve the invocation. See the bug for
>> more information.
>>
>> Tested with tier1-3 and tier8 on linux-x64-debug and
On Wed, 9 Dec 2020 16:33:22 GMT, Coleen Phillimore wrote:
> This change handles redefinition during method resolution, but returning the
> new method. It's not needed to reresolve the invocation. See the bug for
> more information.
>
> Tested with tier1-3 and tier8 on linux-x64-debug and
On Wed, 9 Dec 2020 13:22:58 GMT, Coleen Phillimore wrote:
>> We had a private slack chat with Coleen.
>> Coleen suggested a nice fix in the InterpreterRuntime::resolve_invoke which
>> I like.
>> My mach5 job with Coleen's patch doing 100 StressRedefine tests runs is
>> passed.
>> So, most
On Tue, 8 Dec 2020 09:53:36 GMT, Serguei Spitsyn wrote:
> The StressRedefine.java (base for redefine stress tests) defines 3 important
> constants:
> private static int staticMethodCallersNumber = 10;
> private static int nonstaticMethodCallersNumber = 10;
> private static int
This change handles redefinition during method resolution, but returning the
new method. It's not needed to reresolve the invocation. See the bug for more
information.
Tested with tier1-3 and tier8 on linux-x64-debug and macos-x64-debug, and
running the failing tests 100x without failure.
On Wed, 9 Dec 2020 01:31:16 GMT, Serguei Spitsyn wrote:
>> I don't get serviceability-dev mail anymore because it was being duplicated
>> with hotspot-runtime-dev most of the time. I don't think this fixes the
>> problem, it only makes the test less stressful. Both of these tests find a
>>
8257234 : Add gz option to SA jmap to write a gzipped heap dump
-
Commit messages:
- 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Changes: https://git.openjdk.java.net/jdk/pull/1712/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1712=00
Issue:
18 matches
Mail list logo
