Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v2]

2020-12-10 Thread Mandy Chung
On Thu, 10 Dec 2020 00:37:14 GMT, Serguei Spitsyn wrote: >> This change have been already reviewed by Mandy, Sundar, Alan and David. >> Please, see the jdk 15 review thread: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html >> >> Now, the PR approval is nee

Integrated: 8256424: Move ciSymbol::symbol_name() to ciSymbols::symbol_name()

2020-12-10 Thread Claes Redestad
On Tue, 17 Nov 2020 12:53:48 GMT, Claes Redestad wrote: > This moves the mirroring of vmSymbols in ciSymbols to a separate file, > ciSymbols.hpp, to reduce includes throughout hotspot (and clean up the > ciSymbol namespace). In a few places code is moved from .hpp to .cpp to > facilitate this.

Integrated: 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems

2020-12-10 Thread Severin Gehwolf
On Mon, 7 Dec 2020 17:48:01 GMT, Severin Gehwolf wrote: > This has been implemented for cgroups v1 with > [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) but was > lacking some tooling support for cgroups v2. With podman 2.2.0 release this > could now be implemented (and tested

Re: RFR: 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems

2020-12-10 Thread Severin Gehwolf
On Thu, 10 Dec 2020 16:28:59 GMT, Harold Seigel wrote: > The changes look good. Thanks for doing this. Thanks for the review! - PR: https://git.openjdk.java.net/jdk/pull/1672

Re: RFR: 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems

2020-12-10 Thread Harold Seigel
On Mon, 7 Dec 2020 17:48:01 GMT, Severin Gehwolf wrote: > This has been implemented for cgroups v1 with > [JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) but was > lacking some tooling support for cgroups v2. With podman 2.2.0 release this > could now be implemented (and tested

Re: RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads [v3]

2020-12-10 Thread Richard Reingruber
On Thu, 10 Dec 2020 02:08:38 GMT, Serguei Spitsyn wrote: >> Richard Reingruber has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Only main thread needs to be resumed in >> EARelockingObjectCurrentlyWaitingOn. > > Hi Richard, > The fix loo