Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v10]

2020-12-21 Thread Serguei Spitsyn
> This change have been already reviewed by Mandy, Sundar, Alan and David. > Please, see the jdk 15 review thread: > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html > > Now, the PR approval is needed. > The push was postponed because the CSR was not approved at

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v9]

2020-12-21 Thread Serguei Spitsyn
On Mon, 21 Dec 2020 20:04:39 GMT, Mandy Chung wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Suppress premain method check only if agent class is in unnamed module; >> 2. minor tests cleanup > > The change

Re: [jdk16] RFR: 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java

2020-12-21 Thread Chris Plummer
On Mon, 21 Dec 2020 22:09:33 GMT, Daniel D. Daugherty wrote: > ProblemList three jstatd tests on Win* to reduce the noise in the JDK16 CI. Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/57

Re: [jdk16] RFR: 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java

2020-12-21 Thread Alex Menkov
On Mon, 21 Dec 2020 22:09:33 GMT, Daniel D. Daugherty wrote: > ProblemList three jstatd tests on Win* to reduce the noise in the JDK16 CI. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/57

Re: [jdk16] RFR: 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java

2020-12-21 Thread Daniel D . Daugherty
On Mon, 21 Dec 2020 22:09:33 GMT, Daniel D. Daugherty wrote: > ProblemList three jstatd tests on Win* to reduce the noise in the JDK16 CI. Links to the JDK16 CI failures for each of the three tests are in the bug report. - PR: https://git.openjdk.java.net/jdk16/pull/57

[jdk16] RFR: 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java

2020-12-21 Thread Daniel D . Daugherty
ProblemList three jstatd tests on Win* to reduce the noise in the JDK16 CI. - Commit messages: - 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java Changes: https://git.openjdk.java.net/jdk16/pull/57/files Webrev: https://webrevs.openjd

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v9]

2020-12-21 Thread Mandy Chung
On Fri, 18 Dec 2020 12:00:48 GMT, Serguei Spitsyn wrote: >> This change have been already reviewed by Mandy, Sundar, Alan and David. >> Please, see the jdk 15 review thread: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html >> >> Now, the PR approval is nee

Re: RFR: 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo [v8]

2020-12-21 Thread Сергей Цыпанов
On Mon, 21 Dec 2020 09:51:25 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2459: >> >>> 2457: byte[] bytes = in.readAllBytes(); >>> 2458: return >>> CertificateFactory.getInstance("X509").generateCRLs( >>> 2

Re: RFR: 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo [v8]

2020-12-21 Thread Andrey Turbanov
On Mon, 21 Dec 2020 09:40:39 GMT, Сергей Цыпанов wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo >> revert changes in Apache Santuari

Re: RFR: 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo [v8]

2020-12-21 Thread Сергей Цыпанов
On Mon, 21 Dec 2020 09:16:11 GMT, Andrey Turbanov wrote: >> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8080272: Refactor I/O stream copying

Re: RFR: 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo [v8]

2020-12-21 Thread Andrey Turbanov
> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo revert changes in Apache Sant

Re: RFR: 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo

2020-12-21 Thread Alan Bateman
On Mon, 21 Dec 2020 07:55:06 GMT, Andrey Turbanov wrote: >> I already suggested this, but anyway please always extract the changes to >> the java.desktop module to the separate PR. > > I've extracted changes in java.desktop into separate PR #1856 > Reverted this changes from current PR. Probab

Re: RFR: 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo [v7]

2020-12-21 Thread Andrey Turbanov
> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo Andrey Turbanov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains