On Wed, 9 Dec 2020 07:11:53 GMT, Hao Sun
wrote:
> Flag '-Wmisleading-indentation' was introduced since clang-10 [1] and
> gcc-6 [2]. Putting the code with proper indentations would suppress this
> warning.
>
> The main reason why test image build with gcc succeeds is that, clang
> and gcc might
On Tue, 22 Dec 2020 23:07:12 GMT, Mandy Chung wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 1. Prperly reverted fixes in 3 tests; 2. Got rid of term in
>> tests summary comment
>
> Thanks for the change. Lo
On Tue, 22 Dec 2020 22:11:19 GMT, Serguei Spitsyn wrote:
>> This change have been already reviewed by Mandy, Sundar, Alan and David.
>> Please, see the jdk 15 review thread:
>>
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>>
>> Now, the PR approval is nee
On Mon, 21 Dec 2020 20:04:39 GMT, Mandy Chung wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 1. Suppress premain method check only if agent class is in unnamed module;
>> 2. minor tests cleanup
>
> The change
> This change have been already reviewed by Mandy, Sundar, Alan and David.
> Please, see the jdk 15 review thread:
>
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>
> Now, the PR approval is needed.
> The push was postponed because the CSR was not approved at
On Wed, 9 Dec 2020 07:11:53 GMT, Hao Sun
wrote:
> Flag '-Wmisleading-indentation' was introduced since clang-10 [1] and
> gcc-6 [2]. Putting the code with proper indentations would suppress this
> warning.
>
> The main reason why test image build with gcc succeeds is that, clang
> and gcc might
On Tue, 22 Dec 2020 18:00:29 GMT, Alex Menkov wrote:
>> This is a trivial fix to ProblemList com/sun/jdi/AfterThreadDeathTest.java
>> on Linux-X64.
>
> Marked as reviewed by amenkov (Reviewer).
Thanks for the fast reviews!
-
PR: https://git.openjdk.java.net/jdk16/pull/59
On Tue, 22 Dec 2020 17:42:49 GMT, Daniel D. Daugherty
wrote:
> This is a trivial fix to ProblemList com/sun/jdi/AfterThreadDeathTest.java on
> Linux-X64.
This pull request has now been integrated.
Changeset: 61e5e393
Author:Daniel D. Daugherty
URL: https://git.openjdk.java.net/jdk1
On Wed, 9 Dec 2020 07:11:53 GMT, Hao Sun
wrote:
> Flag '-Wmisleading-indentation' was introduced since clang-10 [1] and
> gcc-6 [2]. Putting the code with proper indentations would suppress this
> warning.
>
> The main reason why test image build with gcc succeeds is that, clang
> and gcc might
On Tue, 22 Dec 2020 17:42:49 GMT, Daniel D. Daugherty
wrote:
> This is a trivial fix to ProblemList com/sun/jdi/AfterThreadDeathTest.java on
> Linux-X64.
Marked as reviewed by amenkov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk16/pull/59
On Tue, 22 Dec 2020 17:42:49 GMT, Daniel D. Daugherty
wrote:
> This is a trivial fix to ProblemList com/sun/jdi/AfterThreadDeathTest.java on
> Linux-X64.
Looks good and trivial.
-
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.java.net/jdk16/pull/59
This is a trivial fix to ProblemList com/sun/jdi/AfterThreadDeathTest.java on
Linux-X64.
-
Commit messages:
- 8258832: ProblemList com/sun/jdi/AfterThreadDeathTest.java on Linux-X64
Changes: https://git.openjdk.java.net/jdk16/pull/59/files
Webrev: https://webrevs.openjdk.java.net/
On Tue, 22 Dec 2020 05:47:19 GMT, Serguei Spitsyn wrote:
>> This change have been already reviewed by Mandy, Sundar, Alan and David.
>> Please, see the jdk 15 review thread:
>>
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>>
>> Now, the PR approval is nee
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty
wrote:
> ProblemList two java/rmi/Naming tests on Windows in order to reduce the
> noise in the JDK16 CI. This is a trivial fix.
This pull request has now been integrated.
Changeset: eabc9030
Author:Daniel D. Daugherty
URL: https
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty
wrote:
> ProblemList two java/rmi/Naming tests on Windows in order to reduce the
> noise in the JDK16 CI. This is a trivial fix.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk16/pull/58
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty
wrote:
> ProblemList two java/rmi/Naming tests on Windows in order to reduce the
> noise in the JDK16 CI. This is a trivial fix.
overdue
-
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.java.net/jdk16/pull/58
On Tue, 22 Dec 2020 17:14:24 GMT, Phil Race wrote:
>> ProblemList two java/rmi/Naming tests on Windows in order to reduce the
>> noise in the JDK16 CI. This is a trivial fix.
>
> overdue
Thanks for the fast reviews!
-
PR: https://git.openjdk.java.net/jdk16/pull/58
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty
wrote:
> ProblemList two java/rmi/Naming tests on Windows in order to reduce the
> noise in the JDK16 CI. This is a trivial fix.
LGTM
-
Marked as reviewed by msheppar (Reviewer).
PR: https://git.openjdk.java.net/jdk16/pull/58
ProblemList two java/rmi/Naming tests on Windows in order to reduce the
noise in the JDK16 CI. This is a trivial fix.
-
Commit messages:
- 8258827: ProblemList Naming/DefaultRegistryPort.java and
Naming/legalRegistryNames/LegalRegistryNames.java on Windows
Changes: https://git.open
On Mon, 21 Dec 2020 22:09:33 GMT, Daniel D. Daugherty
wrote:
> ProblemList three jstatd tests on Win* to reduce the noise in the JDK16 CI.
This pull request has now been integrated.
Changeset: 88dd6a94
Author:Daniel D. Daugherty
URL: https://git.openjdk.java.net/jdk16/commit/88dd6a9
On Mon, 21 Dec 2020 22:44:51 GMT, Alex Menkov wrote:
>> ProblemList three jstatd tests on Win* to reduce the noise in the JDK16 CI.
>
> Marked as reviewed by amenkov (Reviewer).
@alexmenkov and @plummercj - Thanks for the fast reviews.
-
PR: https://git.openjdk.java.net/jdk16/pull/
21 matches
Mail list logo
