On Wed, 27 Jan 2021 06:38:02 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update copyright info
> - fix commandline argument issue an
On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward
wrote:
>>> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
>>> framework
>>> ie:
>>> `--with-extra-ldflags='-F
>>> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Fram
On Tue, 26 Jan 2021 19:44:55 GMT, Chris Plummer wrote:
>> Dear @plummercj,
>> I have made investigation on extending GZIPOutputStream, since it is not
>> possible to override/overwrite private method writeHeader(), the only way I
>> could figure out is to create a class named HProfGZIPOutputS
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- update copyright info
- fix commandline argument issue and refine test cases
-
Changes:
- all: https://gi
On 27/01/2021 3:44 pm, Yasumasa Suenaga wrote:
On Wed, 27 Jan 2021 04:51:04 GMT, David Holmes wrote:
I thought the comments regarding the test were to use an if statement to check
iter.hasNext() and return after seeing one Monitor, rather than keeping the
while-loop and reporting every singl
On Wed, 27 Jan 2021 04:51:04 GMT, David Holmes wrote:
> I thought the comments regarding the test were to use an if statement to
> check iter.hasNext() and return after seeing one Monitor, rather than keeping
> the while-loop and reporting every single Monitor found. The latter seems a
> waste
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Wed, 27 Jan 2021 03:46:32 GMT, Serguei Spitsyn wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update testcase
>
> LGTM++
> Thanks,
> Serguei
Thank you for the review!
> What test has been done with the la
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Wed, 27 Jan 2021 00:59:59 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Tue, 26 Jan 2021 02:14:34 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains seven commits:
>>
>> - Update comments for ObjectMonitorIterator
>> - Merge remote-tracking branch 'upstr
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
On Tue, 26 Jan 2021 09:23:18 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> make/autoconf/build-aux/autoconf-confi
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 26 Jan 2021 19:34:35 GMT, Claes Redestad wrote:
> Simplify and desugar the static initialization of PlatformMBeanFinder.
>
> While arguably making the code easier to comprehend, this saves 5-6ms on
> startup in various applications such as the spring-petclinic.
Looks fine.
--
On Tue, 26 Jan 2021 19:33:28 GMT, Weijun Wang wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert harfbuzz changes, disable warnings for it
>
> src/java.security.jgss/share/native/libj2gss/gssapi.h line 48:
>
>
On Tue, 26 Jan 2021 12:24:16 GMT, Lin Zang wrote:
>> As for any testing requirement, maybe you could pass in a flag to Reader
>> indicating whether or not the testing requires the "HPROF BLOCKSIZE"
>> comment.
>
> Dear @plummercj,
> I have made investigation on extending GZIPOutputStream, si
On Mon, 25 Jan 2021 17:43:35 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/java.desktop/share/native/libhar
Simplify and desugar the static initialization of PlatformMBeanFinder.
While arguably making the code easier to comprehend, this saves 5-6ms on
startup in various applications such as the spring-petclinic.
-
Commit messages:
- Simplify PlatformMBeanFinder
Changes: https://git.ope
On Tue, 26 Jan 2021 18:42:02 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Tue, 26 Jan 2021 16:35:54 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm This and other harfbuzz changes came from MS, could you please
>> comment here ?
>
> This looks like a merge fix mistake:
> https://github.com/openjdk/jdk/commit/051357ef977ecab77fa9b2b1e61f94f288e716f9#diff-e3815f37244
On 2021-01-26 04:44, Magnus Ihse Bursie wrote:
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt
JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
/Applications/Xcode.app/Contents
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 26 Jan 2021 16:07:19 GMT, Vladimir Kempik wrote:
>> src/java.desktop/share/native/libharfbuzz/hb-common.h line 113:
>>
>>> 111:
>>> 112: #define HB_TAG(c1,c2,c3,c4)
>>> ((hb_tag_t)uint32_t)(c1)&0xFF)<<24)|(((uint32_t)(c2)&0xFF)<<16)|(((uint32_t)(c3)&0xFF)<<8)|((uint32_t)(c4)&0xFF))
On Mon, 25 Jan 2021 17:43:22 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/java.desktop/share/native/libhar
On Tue, 26 Jan 2021 11:33:37 GMT, Severin Gehwolf wrote:
> I propose to add additional context to the string which must not match after
> [JDK-8258836](https://bugs.openjdk.java.net/browse/JDK-8258836). This then
> passes the test for a fixed JDK (including JDKs with JDK-8187450 *not* fixed).
>
On Tue, 26 Jan 2021 15:11:12 GMT, Daniel D. Daugherty
wrote:
>> I propose to add additional context to the string which must not match after
>> [JDK-8258836](https://bugs.openjdk.java.net/browse/JDK-8258836). This then
>> passes the test for a fixed JDK (including JDKs with JDK-8187450 *not*
On Tue, 26 Jan 2021 11:33:37 GMT, Severin Gehwolf wrote:
> I propose to add additional context to the string which must not match after
> [JDK-8258836](https://bugs.openjdk.java.net/browse/JDK-8258836). This then
> passes the test for a fixed JDK (including JDKs with JDK-8187450 *not* fixed).
>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Mon, 25 Jan 2021 10:00:20 GMT, Andrew Haley wrote:
>> I like the suggestion. For the defense, new functions were made this way
>> intentionally, to match existing `pass_int`, `pass_long`,.. I take your
>> comment as a blessing to fix all of them. But I feel that refactoring of
>> existing c
On Tue, 26 Jan 2021 08:29:03 GMT, Yasumasa Suenaga wrote:
>> I saw the exception as following when I chose "Monitor Cache Dump" menu on
>> HSDB:
>>
>> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
>> at
>> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCache
On Sat, 23 Jan 2021 03:25:49 GMT, Yasumasa Suenaga wrote:
>> test/hotspot/jtreg/serviceability/sa/TestObjectMonitorIterate.java line 78:
>>
>>> 76: SATestUtils.addPrivilegesIfNeeded(processBuilder);
>>> 77: OutputAnalyzer SAOutput =
>>> ProcessTools.executeProcess(processBuilder
On Mon, 25 Jan 2021 19:12:17 GMT, Coleen Phillimore wrote:
>> I've tried to do something like this initially. The idea was to use Write in
>> VM state and Exec in Java and Native states. However, for example, JIT runs
>> in the Native state and needs Write access. So instead, W^X is managed on
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
/Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework
On Tue, 26 Jan 2021 08:50:06 GMT, Serguei Spitsyn wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>> line 2119:
>>
>>> 2117: }
>>> 2118: } else {
>>> 2119: err.println("Unknow option \"" + option + "\"");
>>
>> "Unknown"
>
> -
On Tue, 26 Jan 2021 12:06:28 GMT, Vladimir Kempik wrote:
> > AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> > framework
> > ie:
> > `--with-extra-ldflags='-F
> > /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Fr
On Tue, 26 Jan 2021 04:41:40 GMT, Chris Plummer wrote:
>> So the problem is that the code in GzipRandomAccess.getAccess() returns NULL
>> if it doesn't find the "HPROF BLOCKSIZE" comment, but you are also saying
>> that tools like heaphero.io work fine without the comment. So maybe you just
>>
On Tue, 26 Jan 2021 09:23:23 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> Changes requested by ihse (Reviewer).
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> framework
> ie:
> `--with-extra-ldflags='-F
> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Frameworks/'`
On Tue, 26 Jan 2021 11:31:18 GMT, Anton Kozlov wrote:
>> This could be a follow-up RFE.
>
> I assume a WXVerifier class that tracks W^X mode in debug mode and does
> nothing in release mode. I've considered to do this, it's relates to small
> inefficiencies, while this patch brings zero overhea
On Tue, 26 Jan 2021 11:33:37 GMT, Severin Gehwolf wrote:
> I propose to add additional context to the string which must not match after
> [JDK-8258836](https://bugs.openjdk.java.net/browse/JDK-8258836). This then
> passes the test for a fixed JDK (including JDKs with JDK-8187450 *not* fixed).
>
I propose to add additional context to the string which must not match after
[JDK-8258836](https://bugs.openjdk.java.net/browse/JDK-8258836). This then
passes the test for a fixed JDK (including JDKs with JDK-8187450 *not* fixed).
Testing:
- [x] Reverted the fix from product code of JDK-8258836,
On Mon, 25 Jan 2021 14:40:42 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/thread.hpp line 915:
>>
>>> 913: verify_wx_state(WXExec);
>>> 914: }
>>> 915: };
>>
>> Rather than add all this to thread.hpp, can you make a wxVerifier.hpp and
>> just add the class instance as
On Tue, 26 Jan 2021 08:50:06 GMT, Serguei Spitsyn wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>> line 2119:
>>
>>> 2117: }
>>> 2118: } else {
>>> 2119: err.println("Unknow option \"" + option + "\"");
>>
>> "Unknown"
>
> -
On Tue, 26 Jan 2021 04:41:40 GMT, Chris Plummer wrote:
>> So the problem is that the code in GzipRandomAccess.getAccess() returns NULL
>> if it doesn't find the "HPROF BLOCKSIZE" comment, but you are also saying
>> that tools like heaphero.io work fine without the comment. So maybe you just
>>
On Mon, 25 Jan 2021 21:34:54 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix coding style issue
>
> Copyrights need updating.
Minor suggestion for
`src/jdk.hotspot.agent/share/classes/sun/jvm/h
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 20:53:19 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix coding style issue
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
> line 2119:
>
>> 2
On Tue, 26 Jan 2021 08:23:28 GMT, Serguei Spitsyn wrote:
>> I'd say that's a bug, and probably what was meant is to do a `println` for
>> every monitor found, not just the first one. So what you would want then is
>> to bracket the `while` loop with `if (itr.hasNext()) {` and move the
>> `retu
On Tue, 26 Jan 2021 07:54:35 GMT, Chris Plummer wrote:
>> Hi Yasumasa,
>>
>> It looks good to me.
>> I have one minor question.
>>
>> This loop in the test is a little bit confusing as it has not more than one
>> iteration:
>> 55 while (itr.hasNext()) {
>> 56 Object
> I saw the exception as following when I chose "Monitor Cache Dump" menu on
> HSDB:
>
> Exception in thread "AWT-EventQueue-0" java.lang.ExceptionInInitializerError
> at
> jdk.hotspot.agent/sun.jvm.hotspot.ui.MonitorCacheDumpPanel.dumpOn(MonitorCacheDumpPanel.java:92)
> at
> jd
53 matches
Mail list logo
