Re: CSR: 8259798: Add jcmd option to dump CDS

2021-02-01 Thread Yumin Qi
Hi, Thomas and all   I have updated the CSR ( https://bugs.openjdk.java.net/browse/JDK-8259798). During the code/debug, I have found some information in the CSR needs revision. Please take a look and give your comment.   I am working on newly added test case failures found by mach5 tests,

Re: RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

2021-02-01 Thread Jie Fu
On Tue, 2 Feb 2021 04:09:24 GMT, Chris Plummer wrote: >> Hi all, >> >> com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled. >> It would be better to fix it. >> >> Thanks. >> Best regards, >> Jie > > test/jdk/com/sun/jdi/JdbOptions.java line 99: > >> 97:

Re: RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

2021-02-01 Thread Chris Plummer
On Tue, 2 Feb 2021 03:43:29 GMT, Jie Fu wrote: > Hi all, > > com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled. > It would be better to fix it. > > Thanks. > Best regards, > Jie test/jdk/com/sun/jdi/JdbOptions.java line 99: > 97: test("-connect", > 98:

RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr

2021-02-01 Thread Jie Fu
Hi all, com/sun/jdi/JdbOptions.java fails in our ci/cd when jfr is disabled. It would be better to fix it. Thanks. Best regards, Jie - Commit messages: - 8260878: com/sun/jdi/JdbOptions.java fails without jfr Changes: https://git.openjdk.java.net/jdk/pull/2346/files Webrev:

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

2021-02-01 Thread Andrew John Hughes
On Tue, 12 Jan 2021 14:29:28 GMT, Severin Gehwolf wrote: > Anybody willing to review this? I can have a go. I have two main concerns: 1. There seems to be little documentation on the new additions. I'm particularly concerned about things like CgroupV1Subsystem.java where a big chunk of

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

2021-02-01 Thread Andrew Haley
On Sun, 31 Jan 2021 20:14:01 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Magnus Ihse Bursie
On Mon, 1 Feb 2021 12:35:05 GMT, Alan Hayward wrote: > > Hello, hsdis is a separate out-of-tree project and is not part of this jep. > > Unless there's something I'm missing it only requires a few lines of change > to src/utils/hsdis/makefile (it already has support for macos x86_64) I agree

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Alan Hayward
On Mon, 1 Feb 2021 11:19:34 GMT, Vladimir Kempik wrote: > Hello, hsdis is a separate out-of-tree project and is not part of this jep. Unless there's something I'm missing it only requires a few lines of change to src/utils/hsdis/makefile (it already has support for macos x86_64) >support for

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Vladimir Kempik
On Mon, 1 Feb 2021 09:31:31 GMT, Alan Hayward wrote: > You need add macos arm64 to hsdis. Having it working is fairly essential for > debugging. > > Inside src/utils/hsdis, After cloning binutils > > ``` > make; make demo; ./build/macosx-arm64/hsdis-demo > ``` > > Results in: > > ``` >

[jdk16] RFR: 8258378: Final nroff manpage update for JDK 16

2021-02-01 Thread Magnus Ihse Bursie
Before RC phase we need to ensure we have the final set of manpage updates published in OpenJDK. - Commit messages: - 8258378: Final nroff manpage update for JDK 16 Changes: https://git.openjdk.java.net/jdk16/pull/142/files Webrev:

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-01 Thread Alan Hayward
On Wed, 27 Jan 2021 14:58:27 GMT, Vladimir Kempik wrote: >> Build changes per se now looks okay. However, I agree with Erik that unless >> this PR can wait for the JNF removal, at the very least the build docs needs >> to be updated to explain how to successfully build for this platform. (I