Re: RFR: 8259070: Add jcmd option to dump CDS

2021-02-26 Thread Thomas Stuefe
On Fri, 26 Feb 2021 22:15:12 GMT, Ioi Lam wrote: >> Hi, Please review >> >> Added jcmd option for dumping CDS archive during application runtime. >> Before this change, user has to dump shared archive in two steps: first run >> application with >> `java -XX:DumpLoadedClassList= ` >>

Re: RFR: 8259070: Add jcmd option to dump CDS

2021-02-26 Thread Thomas Stuefe
On Fri, 26 Feb 2021 00:03:40 GMT, Yumin Qi wrote: > Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to c

Re: RFR: 8259070: Add jcmd option to dump CDS

2021-02-26 Thread Thomas Stuefe
On Fri, 26 Feb 2021 22:01:09 GMT, Calvin Cheung wrote: >> Hi, Please review >> >> Added jcmd option for dumping CDS archive during application runtime. >> Before this change, user has to dump shared archive in two steps: first run >> application with >> `java -XX:DumpLoadedClassList=

Re: RFR: 8259070: Add jcmd option to dump CDS

2021-02-26 Thread Ioi Lam
On Fri, 26 Feb 2021 00:03:40 GMT, Yumin Qi wrote: > Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to c

Re: RFR: 8259070: Add jcmd option to dump CDS

2021-02-26 Thread Calvin Cheung
On Fri, 26 Feb 2021 00:03:40 GMT, Yumin Qi wrote: > Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to c

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v21]

2021-02-26 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Integrated: 8262332: serviceability/sa/ClhsdbJhisto.java fails with Test ERROR java.lang.RuntimeException: 'ParselTongue' missing from stdout/stderr

2021-02-26 Thread Leonid Mesnik
On Wed, 24 Feb 2021 22:10:49 GMT, Leonid Mesnik wrote: > …va.lang.RuntimeException: 'ParselTongue' missing from stdout/stderr This pull request has now been integrated. Changeset: 2515c42b Author:Leonid Mesnik URL: https://git.openjdk.java.net/jdk/commit/2515c42b Stats: 4 lines i

Re: RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware [v8]

2021-02-26 Thread Daniel D . Daugherty
> A minor fix to add a new function: > > bool Thread::is_JavaThread_protected(const JavaThread* p) > > that returns true when the target JavaThread* is protected and false > otherwise. Update JavaThread::get_thread_name() to create a > ThreadsListHandle and use the new is_JavaThread_protected

Integrated: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware

2021-02-26 Thread Daniel D . Daugherty
On Thu, 11 Feb 2021 22:04:53 GMT, Daniel D. Daugherty wrote: > A minor fix to add a new function: > > bool Thread::is_JavaThread_protected(const JavaThread* p) > > that returns true when the target JavaThread* is protected and false > otherwise. Update JavaThread::get_thread_name() to crea

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-26 Thread erik . joelsson
On 2021-02-26 06:37, daniel.daughe...@oracle.com wrote: On 2/26/21 7:55 AM, Vladimir Kempik wrote: On Tue, 2 Feb 2021 23:07:08 GMT, Daniel D. Daugherty wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:    support macos_aarc

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-26 Thread daniel . daugherty
On 2/26/21 7:55 AM, Vladimir Kempik wrote: On Tue, 2 Feb 2021 23:07:08 GMT, Daniel D. Daugherty wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision: support macos_aarch64 in hsdis src/java.base/macosx/native/libjli/java_md_mac

Re: RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware [v7]

2021-02-26 Thread Daniel D . Daugherty
On Fri, 26 Feb 2021 07:34:06 GMT, Robbin Ehn wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address dholmes-ora CR4 comments. > > Marked as reviewed by rehn (Reviewer). @robehn - Thanks for the re-review!

Re: RFR: 8241403: JavaThread::get_thread_name() should be ThreadSMR-aware [v7]

2021-02-26 Thread Serguei Spitsyn
On Thu, 25 Feb 2021 23:14:01 GMT, Daniel D. Daugherty wrote: >> A minor fix to add a new function: >> >> bool Thread::is_JavaThread_protected(const JavaThread* p) >> >> that returns true when the target JavaThread* is protected and false >> otherwise. Update JavaThread::get_thread_name() t

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-26 Thread Vladimir Kempik
On Tue, 2 Feb 2021 23:07:08 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/java.base/macosx/native/libjli/java_md_macosx.m line 210: > >> 208: i

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v20]

2021-02-26 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v19]

2021-02-26 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)