Re: RFR: 8262486: Merge trivial JDWP agent changes from the loom repo to the jdk repo [v2]

2021-03-05 Thread Leonid Mesnik
On Fri, 5 Mar 2021 19:05:21 GMT, Chris Plummer wrote: >> In the loom repo there are a number of trivial changes to the JDWP agent >> that are not loom specific. Moving them to the jdk repo will make future >> merges simpler, along with making it easier to get a diff of the important >> differe

Re: RFR: 8262486: Merge trivial JDWP agent changes from the loom repo to the jdk repo [v2]

2021-03-05 Thread Alex Menkov
On Fri, 5 Mar 2021 19:02:57 GMT, Chris Plummer wrote: > > > @alexmenkov @lmesnik I made a couple of very minor edits. Can you please > approve them. Thanks! Still LGTM - PR: https://git.openjdk.java.net/jdk/pull/2815

Re: RFR: 8262486: Merge trivial JDWP agent changes from the loom repo to the jdk repo [v2]

2021-03-05 Thread Chris Plummer
> In the loom repo there are a number of trivial changes to the JDWP agent that > are not loom specific. Moving them to the jdk repo will make future merges > simpler, along with making it easier to get a diff of the important > differences between the loom and jdk repos, without the clutter of

Re: RFR: 8262486: Merge trivial JDWP agent changes from the loom repo to the jdk repo [v2]

2021-03-05 Thread Chris Plummer
On Wed, 3 Mar 2021 23:24:52 GMT, Alex Menkov wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor jdwp agent edits from loom project. > > Marked as reviewed by amenkov (Reviewer). @alexmenkov @lmesnik I made a c

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-05 Thread Richard Reingruber
On Fri, 5 Mar 2021 11:11:44 GMT, Alan Hayward wrote: >>> I was building this PR on a new machine, and I now get the following error: >>> >>> > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:258:31: >>> > error: cast to smaller integer t

Re: RFR: 8262910: Cleanup THREAD/TRAPS/naming and typing issues in ObjectMonitor and related code [v4]

2021-03-05 Thread Daniel D . Daugherty
On Fri, 5 Mar 2021 04:59:02 GMT, David Holmes wrote: >> ObjectMonitors can only be used by JavaThreads (modulo some interactions >> with hashcodes and deflation) but we use "Thread*" almost everywhere mainly >> due to use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685 >> is do

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-05 Thread Alan Hayward
On Thu, 4 Mar 2021 18:19:33 GMT, Vladimir Kempik wrote: > Hello > there is one issue with the info you provided, it's from Xcode12.5 beta. > And beta license agreement forbids sharing output of beta version of > compiler&co > So we can't say we have issue with newer xcode beta until that beta we

Re: RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out

2021-03-05 Thread Lin Zang
On Thu, 4 Mar 2021 13:22:47 GMT, Lin Zang wrote: >> Thanks for the explanation in the CR. That helps a lot. I didn't have time >> to get through the review today, but will do so tomorrow. > > Hi Chris, > Thanks a lot, I am still wip to reduce the memory consumption. So I think you > could help

Re: RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out [v2]

2021-03-05 Thread Lin Zang
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed > out Lin Zang has updated the pull request incrementally with one additional commit since the last revision: reduce memory consumption - Changes: - all: https://git.openjdk.java.net/jdk/pull/2803/f

Re: RFR: 8262520: Add SA Command Line Debugger support to connect to debug server [v5]

2021-03-05 Thread Chris Plummer
On Fri, 5 Mar 2021 07:36:26 GMT, Yasumasa Suenaga wrote: >> test/hotspot/jtreg/serviceability/sa/sadebugd/ClhsdbAttachToDebugServer.java >> line 95: >> >>> 93: out.shouldMatch("^java/lang/Object @0x[0-9a-f]+$"); // for >>> "class java.lang.Object" >>> 94: out.shouldMatc

Re: RFR: 8262520: Add SA Command Line Debugger support to connect to debug server [v6]

2021-03-05 Thread Chris Plummer
On Fri, 5 Mar 2021 07:33:06 GMT, Yasumasa Suenaga wrote: >> `attach` command on CLHSDB supports to attach live process (PID) and >> coredump, but it cannot connect to debug server. CLHSDB does not have a >> command to connect to debug server. >> >> Other jhsdb commands (jstack, jmap, etc...) c