Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread David Holmes
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for

Re: RFR: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records [v7]

2021-04-08 Thread Mandy Chung
On Fri, 2 Apr 2021 18:00:57 GMT, Daniel Fuchs wrote: >> This RFE proposes to extend the MXBean framework to define a mapping to >> records. >> >> The MXBean framework already defines a mapping of `CompositeType` to plain >> java objects. Records are a natural representation of CompositeTypes.

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Vladimir Kozlov
On Thu, 8 Apr 2021 20:59:59 GMT, Coleen Phillimore wrote: > There's a comment above > void VM_RedefineClasses::mark_dependent_code(InstanceKlass* ik) { > that should be rewritten, so I think we should just file an RFE to remove it > afterwards. https://bugs.openjdk.java.net/browse/JDK-8264941

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Coleen Phillimore
On Thu, 8 Apr 2021 20:28:27 GMT, Igor Ignatyev wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > Test changes look good to me. There's a comment above void

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Igor Ignatyev
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Vladimir Kozlov
On Thu, 8 Apr 2021 20:00:30 GMT, Vladimir Kozlov wrote: >> GC changes look good. > >> void CodeCache::mark_for_evol_deoptimization(InstanceKlass* dependee) { >> This function, its caller and the function in jvmtiRedefineClasses.cpp that >> calls it can be deleted also, but you can file a

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Stefan Karlsson
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Vladimir Kozlov
On Thu, 8 Apr 2021 19:58:11 GMT, Stefan Karlsson wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > GC changes look good. > void

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Erik Joelsson
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Coleen Phillimore
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler

2021-04-08 Thread Coleen Phillimore
On Thu, 8 Apr 2021 15:23:52 GMT, Vladimir Kozlov wrote: > As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Ahead-of-Time Compiler from JDK: > > - `jdk.aot` module — the `jaotc` tool > - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution >

Re: RFR: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records [v7]

2021-04-08 Thread Chris Hegarty
On Fri, 2 Apr 2021 18:00:57 GMT, Daniel Fuchs wrote: >> This RFE proposes to extend the MXBean framework to define a mapping to >> records. >> >> The MXBean framework already defines a mapping of `CompositeType` to plain >> java objects. Records are a natural representation of CompositeTypes.

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Vladimir Kozlov
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Ahead-of-Time Compiler from JDK: > > - `jdk.aot` module — the `jaotc` tool > - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution > - related HotSpot code guarded by `#if INCLUDE_AOT` > >

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v3]

2021-04-08 Thread Vladimir Kozlov
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Ahead-of-Time Compiler from JDK: > > - `jdk.aot` module — the `jaotc` tool > - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution > - related HotSpot code guarded by `#if INCLUDE_AOT` > >

Re: RFR: 8257831: Suspend with handshakes [v4]

2021-04-08 Thread Richard Reingruber
On Thu, 8 Apr 2021 07:17:48 GMT, Robbin Ehn wrote: >> A suspend request is done by handshaking thread target thread(s). When >> executing the handshake operation we know the target mutator thread is in a >> dormant state (as in safepoint safe state). We have a guarantee that it will >> check

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v2]

2021-04-08 Thread Vladimir Kozlov
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Ahead-of-Time Compiler from JDK: > > - `jdk.aot` module — the `jaotc` tool > - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution > - related HotSpot code guarded by `#if INCLUDE_AOT` > >

RFR: 8264805: Remove the experimental Ahead-of-Time Compiler

2021-04-08 Thread Vladimir Kozlov
As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to Ahead-of-Time Compiler from JDK: - `jdk.aot` module — the `jaotc` tool - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution - related HotSpot code guarded by `#if INCLUDE_AOT` Additionally,

Integrated: 8264711: More runtime TRAPS cleanups

2021-04-08 Thread Harold Seigel
On Mon, 5 Apr 2021 17:57:13 GMT, Harold Seigel wrote: > Please review this additional cleanup of use of TRAPS in hotspot runtime > code. The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and > Windows and Mach5 tiers 3-5 on Linux x64. > > Thanks, Harold This pull request has

Re: RFR: 8264711: More runtime TRAPS cleanups [v4]

2021-04-08 Thread Harold Seigel
On Thu, 8 Apr 2021 10:10:00 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unneeded statement > > Hi Harold, > > Updates seem fine. > > Thanks, > David Thanks Lois, Patricio, David,

Re: RFR: 8264711: More runtime TRAPS cleanups [v4]

2021-04-08 Thread David Holmes
On Wed, 7 Apr 2021 14:19:50 GMT, Harold Seigel wrote: >> Please review this additional cleanup of use of TRAPS in hotspot runtime >> code. The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and >> Windows and Mach5 tiers 3-5 on Linux x64. >> >> Thanks, Harold > > Harold Seigel

Re: RFR: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records [v6]

2021-04-08 Thread Daniel Fuchs
On Wed, 31 Mar 2021 21:43:58 GMT, Mandy Chung wrote: >> Daniel Fuchs has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - minor style issue >> - minor style issue > > Thanks for making the change. The spec change looks good to me.

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI [v4]

2021-04-08 Thread Serguei Spitsyn
On Thu, 8 Apr 2021 01:25:25 GMT, Daniel D. Daugherty wrote: >> Dan, >> I'm sorry, I do not see much value in this approach going forward. One line >> with a call to check_jvmti_status() does not add much to the platform >> dependency no to complexity in native code. Also, more sophisticated

Re: RFR: 8257831: Suspend with handshakes [v2]

2021-04-08 Thread Serguei Spitsyn
On Thu, 8 Apr 2021 06:02:35 GMT, Serguei Spitsyn wrote: >> Working on pushing a new version, it will not have addressed all comments >> but many of them. >> I will build and do testing before push, and start deep testing in the >> background. >> >> I also merge with mainline. > > Hi Robbin, >

Re: RFR: 8257831: Suspend with handshakes [v4]

2021-04-08 Thread Robbin Ehn
> A suspend request is done by handshaking thread target thread(s). When > executing the handshake operation we know the target mutator thread is in a > dormant state (as in safepoint safe state). We have a guarantee that it will > check it's poll before leaving the dormant state. To stop the

Re: RFR: 8257831: Suspend with handshakes [v2]

2021-04-08 Thread Serguei Spitsyn
On Wed, 7 Apr 2021 16:25:28 GMT, Robbin Ehn wrote: >>> Hi Robbin, >>> I'm looking at it. I have a concern that it can significantly impact Loom >>> implementation. There is a non-trivial update in Loom to support virtual >>> threads in JVMTI Suspend/Resume. So we need to make sure your