RFR: 8266187: Memory leak in appendBootClassPath()

2021-04-27 Thread Wang Huang
Dear All, I find a memory leak in `appendBootClassPath()` https://github.com/openjdk/jdk/blob/75a2354dc276e107d64516d20fc72bc7ef3d5f86/src/java.instrument/share/native/libinstrument/InvocationAdapter.c#L950 we malloc `resolved` from resolve(parent, path) * we use `resolved` in line 951 * w

Re: RFR: 8265153: add time based test for ThreadMXBean.getThreadInfo() and ThreadInfo.getLockOwnerName()

2021-04-27 Thread Daniel D . Daugherty
On Wed, 14 Apr 2021 00:08:52 GMT, Daniel D. Daugherty wrote: > The synopsis pretty much says it all. There's a more detailed history in the > RFE itself. > > Currently running the new test thru Mach5 Tier[1-7]. > I've run the test thru several 12 hour runs on my MBP13 and > on my Linux-X64 ser

Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java fails with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

2021-04-27 Thread Chris Plummer
On Fri, 23 Apr 2021 15:03:42 GMT, Fairoz Matte wrote: > findComponentType() logic is wrong. In findComponentType() method, We always > get vm.classesByName() retruns empty list > list = vm.classesByName(parser.typeName()); > We have "parser.typeName()" retruns " double[][]" > vm.classesByName(""

Re: RFR: 8265153: add time based test for ThreadMXBean.getThreadInfo() and ThreadInfo.getLockOwnerName()

2021-04-27 Thread Chris Plummer
On Wed, 14 Apr 2021 00:08:52 GMT, Daniel D. Daugherty wrote: > The synopsis pretty much says it all. There's a more detailed history in the > RFE itself. > > Currently running the new test thru Mach5 Tier[1-7]. > I've run the test thru several 12 hour runs on my MBP13 and > on my Linux-X64 ser

Re: RFR: 8266002: vmTestbase/nsk/jvmti/ClassPrepare/classprep001 should skip events for unexpected classes

2021-04-27 Thread Chris Plummer
On Tue, 27 Apr 2021 21:30:09 GMT, Alex Menkov wrote: > Class loading may cause loading of some other system/internal classes (for > example loading of java.util.concurrent classes when an other thread loads > some classes concurrently). > The fix updates ClassPrepare test so it skip events for

Re: RFR: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file" [v2]

2021-04-27 Thread Coleen Phillimore
On Wed, 21 Apr 2021 20:51:49 GMT, Alex Menkov wrote: >> The test actually failed starting from jdk13, but the error is masked by >> JDK-8264667 (and shell part of the test didn't verify result of the java >> execution) >> The fix: >> - updates JvmtiClassFileReconstituter to add attributes in th

Re: RFR: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file" [v2]

2021-04-27 Thread Alex Menkov
On Wed, 21 Apr 2021 20:51:49 GMT, Alex Menkov wrote: >> The test actually failed starting from jdk13, but the error is masked by >> JDK-8264667 (and shell part of the test didn't verify result of the java >> execution) >> The fix: >> - updates JvmtiClassFileReconstituter to add attributes in th

RFR: 8266002: vmTestbase/nsk/jvmti/ClassPrepare/classprep001 should skip events for unexpected classes

2021-04-27 Thread Alex Menkov
Class loading may cause loading of some other system/internal classes (for example loading of java.util.concurrent classes when an other thread loads some classes concurrently). The fix updates ClassPrepare test so it skip events for "unexpected" classes. Also it adds a testcase to verify that cl

Re: RFR: 8265153: add time based test for ThreadMXBean.getThreadInfo() and ThreadInfo.getLockOwnerName()

2021-04-27 Thread Daniel D . Daugherty
On Wed, 14 Apr 2021 00:08:52 GMT, Daniel D. Daugherty wrote: > The synopsis pretty much says it all. There's a more detailed history in the > RFE itself. > > Currently running the new test thru Mach5 Tier[1-7]. > I've run the test thru several 12 hour runs on my MBP13 and > on my Linux-X64 ser

Re: RFR: 8266038: Move newAddress() to JVMDebugger

2021-04-27 Thread Kevin Walls
On Tue, 27 Apr 2021 09:19:34 GMT, Yasumasa Suenaga wrote: > SA has `newAddress()` to create `Address` instance, however it is declared in > each debugger classes (e.g. `LinuxDebugger`). So we can't access it directly > from `VM` class. > > Before SA improvement for ZGC in > [JDK-8220624](http

RFR: 8266038: Move newAddress() to JVMDebugger

2021-04-27 Thread Yasumasa Suenaga
SA has `newAddress()` to create `Address` instance, however it is declared in each debugger classes (e.g. `LinuxDebugger`). So we can't access it directly from `VM` class. Before SA improvement for ZGC in [JDK-8220624](https://bugs.openjdk.java.net/browse/JDK-8220624), we need to move `newAddr

RFR: 8265914: Duplicated NotANode and not_a_node

2021-04-27 Thread Yi Yang
NotANode(node.hpp) and not_a_node(compile.cpp) are completely repeated guys. - Commit messages: - not_a_node Changes: https://git.openjdk.java.net/jdk/pull/3715/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3715&range=00 Issue: https://bugs.openjdk.java.net/browse/J