On Wed, 5 May 2021 01:35:11 GMT, Yasumasa Suenaga wrote:
> `ZAddress::address()` has been removed since
> [JDK-8235748](https://bugs.openjdk.java.net/browse/JDK-8235748), however SA
> has not followed it. Thus some SA tests would fail with ZGC.
> After this change, more than half of jtreg
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Sat, 20 Feb 2021 03:27:22 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve jcmd GC.class_histogram to support parallel
>
> For jmap -histo we have:
>
> parallel= parallel threads
On Tue, 11 May 2021 22:57:24 GMT, Pavel Rappo wrote:
>> This fixes two javadoc tag references and several typos. References are
>> fixed by removing whitespace before the opening `(`. That whitespace caused
>> the opening `(` and the rest of the reference to be parsed as a link label.
>>
>>
On Wed, 28 Apr 2021 13:03:15 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unnecessary "@library /test/lib".
>
> HI Dan,
>
> Some minor comments, but to be frank I have no idea
On Wed, 28 Apr 2021 13:03:15 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unnecessary "@library /test/lib".
>
> HI Dan,
>
> Some minor comments, but to be frank I have no idea
On Wed, 5 May 2021 19:22:11 GMT, Daniel Fuchs wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed more typos
>
> src/jdk.management.agent/share/classes/sun/management/jmxremote/ConnectorBootstrap.java
> line
> This fixes two javadoc tag references and several typos. References are fixed
> by removing whitespace before the opening `(`. That whitespace caused the
> opening `(` and the rest of the reference to be parsed as a link label.
>
> Since we are here, I think this class could also benefit from
On Mon, 26 Apr 2021 02:22:47 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 11 May 2021 03:19:05 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 30 commits:
>
> - Merge branch 'master' into par-dump
> - undo
On Tue, 11 May 2021 06:35:43 GMT, Mitsuru kariya
wrote:
>> The current `hashCode` implementation of SA's Address subclasses ignores the
>> upper 32 bits of the long value.
>> This PR changes to use `Long.hashCode` instead.
>
> Mitsuru kariya has updated the pull request incrementally with one
On Tue, 11 May 2021 12:13:33 GMT, Robbin Ehn wrote:
>> Please consider this change which removes the manual transitions to blocked.
>> This adds a preprocess template/functor which is executed in the destructor
>> of 'ThreadBlockInVM' if we are going to do any processing.
>> This gives us a way
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Thu, 6 May 2021 02:34:01 GMT, Hao Tang
wrote:
>> Thanks for linking that. It sounds reasonable to me to prefer `quota` in
>> that case.
>
>> Thanks for linking that. It sounds reasonable to me to prefer `quota` in
>> that case.
>
> Yes, flag `PreferContainerQuotaForCPUCount` is [true by
> OperatingSystemImpl.getCpuLoad() may return 1.0 in a container, even though
> the CPU load is obviously below 100%.
>
> We created a 5-core container and run 4 "while (true)" loops in the
> container. OperatingSystemImpl.getCpuLoad() returned 1.0, which is incorrect
> (0.8 is correct).
>
Hi Brian,
Thanks for looking at this.
The JDK no longer creates unsafe anon classes. So, those tests could
only find an unsafe anonymous class if they explicitly created one. In
which case, the tests would need to call Unsafe.defineAnonymousClass().
And, hopefully, those tests have been
On Tue, 11 May 2021 13:41:53 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/Class/GetModuleTest.java line 42:
>>
>>> 40: import static org.testng.Assert.*;
>>> 41:
>>> 42: public class GetModuleTest {
>>
>> testGetModuleOnVMAnonymousClass is the only test here that uses ASM so you
>> can
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> the tests were modified to use hidden classes, others
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> the tests were modified to use hidden classes, others
On Tue, 11 May 2021 13:37:32 GMT, Alan Bateman wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Tue, 11 May 2021 12:50:31 GMT, Harold Seigel wrote:
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
>
There may be some JDK code that checks for anon classes by comparing the name
to see if it contains a slash, especially tests, but which don’t say
“anonymous”. Did you do a search for these idioms too, which are now dead
tests?
Sent from my iPad
> On May 11, 2021, at 8:59 AM, Harold Seigel
> Please consider this change which removes the manual transitions to blocked.
> This adds a preprocess template/functor which is executed in the destructor
> of 'ThreadBlockInVM' if we are going to do any processing.
> This gives us a way to backout of the object/raw monitor before suspend or
>
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
> out
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 11
On Mon, 10 May 2021 23:19:37 GMT, Chris Plummer wrote:
>> Hi Chris (@plummercj )
>>
>> After several tries, I think maybe the current patch is the better way to
>> fix this issue.
>> For detail, there are three issues that cause the problem.
>> - The incorrect calculated array length when
On Mon, 10 May 2021 23:15:29 GMT, Chris Plummer wrote:
> I don't think you need to.
Sure.
> Some of the more recently changed files need updates to the Oracle copyrights.
I'm sorry for the stupid mistake.
I just updated the copyright.
> Note I'm only requesting updates to the Oracle
On Wed, 5 May 2021 01:35:11 GMT, Yasumasa Suenaga wrote:
> `ZAddress::address()` has been removed since
> [JDK-8235748](https://bugs.openjdk.java.net/browse/JDK-8235748), however SA
> has not followed it. Thus some SA tests would fail with ZGC.
> After this change, more than half of jtreg
> The current `hashCode` implementation of SA's Address subclasses ignores the
> upper 32 bits of the long value.
> This PR changes to use `Long.hashCode` instead.
Mitsuru kariya has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
28 matches
Mail list logo
