> Our code is littered with API's that take, or manifest, a Thread* and then
> assert/guarantee that it must be a JavaThread, rather than taking/manifesting
> a JavaThread in the first place. The main reason for this is that the TRAPS
> macro, used in relation to exception generation and
On 13/05/2021 1:29 pm, Vladimir Kozlov wrote:
On Tue, 11 May 2021 01:56:21 GMT, David Holmes wrote:
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
Review feedback from Serguei
Compiler related changes seems fine.
@dougxc,
On Tue, 11 May 2021 01:56:21 GMT, David Holmes wrote:
>> Our code is littered with API's that take, or manifest, a Thread* and then
>> assert/guarantee that it must be a JavaThread, rather than
>> taking/manifesting a JavaThread in the first place. The main reason for this
>> is that the
On Tue, 11 May 2021 01:34:16 GMT, Yasumasa Suenaga wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/RMIHelper.java line 93:
>>
>>> 91:
>>> 92: public static Remote lookup(String debugServerID) throws
>>> DebuggerException {
>>> 93: // debugServerID follows the pattern
On Wed, 12 May 2021 11:10:37 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 32 commits:
>
> - Merge branch 'master' into pd
> - update
On Wed, 12 May 2021 16:10:24 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Wed, 12 May 2021 18:00:56 GMT, Chris Plummer wrote:
> [JDK-8267045](https://bugs.openjdk.java.net/browse/JDK)-8267045 removed this
> test from the ZGC problem list, but it still fails, so it needs to be
> re-added.
This pull request has now been integrated.
Changeset: 2568d181
Author:
On Wed, 12 May 2021 18:00:56 GMT, Chris Plummer wrote:
> [JDK-8267045](https://bugs.openjdk.java.net/browse/JDK)-8267045 removed this
> test from the ZGC problem list, but it still fails, so it needs to be
> re-added.
Thumbs up. This is a trivial fix.
-
Marked as reviewed by
[JDK-8267045](https://bugs.openjdk.java.net/browse/JDK)-8267045 removed this
test from the ZGC problem list, but it still fails, so it needs to be re-added.
-
Commit messages:
- ProblemList serviceability/sa/TestJmapCoreMetaspace.java
Changes:
On Wed, 12 May 2021 15:22:52 GMT, Richard Reingruber wrote:
>> src/hotspot/share/services/heapDumperCompression.cpp line 262:
>>
>>> 260: }
>>> 261:
>>> 262: void CompressionBackend::thread_loop() {
>>
>> You could simplify `CompressionBackend::thread_loop()` further:
>>
>>
>> void
On Tue, 11 May 2021 17:07:35 GMT, Ioi Lam wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix GetModuleTest.java
>
> src/hotspot/share/oops/instanceMirrorKlass.inline.hpp line 65:
>
>> 63: // so when
On Tue, 11 May 2021 20:49:46 GMT, Mandy Chung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix GetModuleTest.java
>
> src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java
>
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> the tests were modified to use hidden classes, others
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Thu, 22 Apr 2021 14:16:21 GMT, Ralf Schmelter wrote:
> This fixes a race condition in the CompressionBackend class of the heap dump
> code.
>
> The race happens when the thread iterating the heap wants to write the data
> it has collected. If the compression backend has worker threads, the
On Wed, 12 May 2021 14:37:14 GMT, Richard Reingruber wrote:
>> This fixes a race condition in the CompressionBackend class of the heap dump
>> code.
>>
>> The race happens when the thread iterating the heap wants to write the data
>> it has collected. If the compression backend has worker
On 12/05/2021 8:56 pm, Robbin Ehn wrote:
On Wed, 12 May 2021 08:27:33 GMT, Richard Reingruber wrote:
Hi Robbin,
I haven't found the time for a proper review yet but I've experimented a little
bit with lambdas. I could not make it work because g++ created references to
::new which isn't
On Wed, 12 May 2021 10:53:21 GMT, Robbin Ehn wrote:
>
>
> > Hi Robbin,
> > I haven't found the time for a proper review yet but I've experimented a
> > little bit with lambdas. I could not make it work because g++ created
> > references to ::new which isn't allowed.
> > Thanks, Richard.
>
>
On Wed, 12 May 2021 11:10:37 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 32 commits:
>
> - Merge branch 'master' into pd
> - update
On Thu, 22 Apr 2021 14:16:21 GMT, Ralf Schmelter wrote:
> This fixes a race condition in the CompressionBackend class of the heap dump
> code.
>
> The race happens when the thread iterating the heap wants to write the data
> it has collected. If the compression backend has worker threads, the
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
> out
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 12
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 32 commits:
- Merge branch 'master' into pd
- update copyright info
- Merge branch 'master' into par-dump
- undo
On Wed, 5 May 2021 15:59:43 GMT, Pavel Rappo wrote:
> This fixes two javadoc tag references and several typos. References are fixed
> by removing whitespace before the opening `(`. That whitespace caused the
> opening `(` and the rest of the reference to be parsed as a link label.
>
> Since
On Wed, 12 May 2021 08:27:33 GMT, Richard Reingruber wrote:
> Hi Robbin,
>
> I haven't found the time for a proper review yet but I've experimented a
> little bit with lambdas. I could not make it work because g++ created
> references to ::new which isn't allowed.
>
> Thanks, Richard.
Hi
On Wed, 12 May 2021 09:14:53 GMT, Pavel Rappo wrote:
>> This fixes two javadoc tag references and several typos. References are
>> fixed by removing whitespace before the opening `(`. That whitespace caused
>> the opening `(` and the rest of the reference to be parsed as a link label.
>>
>>
On Wed, 12 May 2021 09:14:53 GMT, Pavel Rappo wrote:
>> This fixes two javadoc tag references and several typos. References are
>> fixed by removing whitespace before the opening `(`. That whitespace caused
>> the opening `(` and the rest of the reference to be parsed as a link label.
>>
>>
On Wed, 12 May 2021 00:43:59 GMT, Serguei Spitsyn wrote:
> Just one nit is to add a dot at the end of this comment:
> 280 // time. It's OK for now as logic in Agent.java forbids multiple agents
I added two full stops: one for each unterminated sentence in that inline
comment.
-
> This fixes two javadoc tag references and several typos. References are fixed
> by removing whitespace before the opening `(`. That whitespace caused the
> opening `(` and the rest of the reference to be parsed as a link label.
>
> Since we are here, I think this class could also benefit from
On Wed, 12 May 2021 08:04:24 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 230:
>>
>>> 228: };
>>> 229:
>>> 230: template
>>
>> When you mentioned doing this with templates, I was having
>> nightmares, but this one is not bad at all...
>
> :)
Any
On Wed, 12 May 2021 08:04:47 GMT, Robbin Ehn wrote:
>> Please consider this change which removes the manual transitions to blocked.
>> This adds a preprocess template/functor which is executed in the destructor
>> of 'ThreadBlockInVM' if we are going to do any processing.
>> This gives us a way
> Please consider this change which removes the manual transitions to blocked.
> This adds a preprocess template/functor which is executed in the destructor
> of 'ThreadBlockInVM' if we are going to do any processing.
> This gives us a way to backout of the object/raw monitor before suspend or
>
31 matches
Mail list logo
