[jdk17] RFR: 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC

2021-06-15 Thread Yasumasa Suenaga
In order to reduce the noise in the JDK17 CI, I'm ProblemListing serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC. - Commit messages: - 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC Changes: https://git.openjdk.java.net/j

Re: RFR: 8268857: Merge three vm operations in thread_dump

2021-06-15 Thread David Holmes
On Wed, 16 Jun 2021 03:33:14 GMT, Denghui Dong wrote: > Hi, > > Could I have a review of this change that merges three vm > operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and > signal_thread_entry. > > `jstack` is a very common command, even in the production enviro

RFR: 8268857: Merge three vm operations in thread_dump

2021-06-15 Thread Denghui Dong
Hi, Could I have a review of this change that merges three vm operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and signal_thread_entry. `jstack` is a very common command, even in the production environment. In addition to reduce the cost of entering safepoint, I think

Integrated: 8268780: Use 'print_cr' instead of 'print' for the message 'eliminated '

2021-06-15 Thread Denghui Dong
On Tue, 15 Jun 2021 17:19:26 GMT, Denghui Dong wrote: > Hi, > > Cound I have a review of this small fix that adds a line feed for the message > 'eliminated '. > > When we run the following code and run `jstack ` > > > public static void main(String[] args) { > for (int i = 0; i <

Re: [jdk17] Integrated: 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64

2021-06-15 Thread Daniel D . Daugherty
On Tue, 15 Jun 2021 21:41:34 GMT, Kim Barrett wrote: >> A trivial fix to ProblemList 3 serviceability/dcmd/framework tests with ZGC >> on win-x64. > > Changes requested by kbarrett (Reviewer). @kimbarrett - Thanks for catching that! Made my terminal wider... :-) Fixed. > Looks good. @kimbarre

[jdk17] Integrated: 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64

2021-06-15 Thread Daniel D . Daugherty
On Tue, 15 Jun 2021 21:38:17 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 3 serviceability/dcmd/framework tests with ZGC > on win-x64. This pull request has now been integrated. Changeset: 10068c1b Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk1

Re: [jdk17] Integrated: 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64

2021-06-15 Thread Kim Barrett
On Tue, 15 Jun 2021 21:38:17 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 3 serviceability/dcmd/framework tests with ZGC > on win-x64. Changes requested by kbarrett (Reviewer). Looks good. test/hotspot/jtreg/ProblemList-zgc.txt line 46: > 44: serviceability/dcmd/framework/

[jdk17] Integrated: 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64

2021-06-15 Thread Daniel D . Daugherty
A trivial fix to ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64. - Commit messages: - Fix broken lines in new entries. - 8268830: ProblemList 3 serviceability/dcmd/framework tests with ZGC on win-x64 Changes: https://git.openjdk.java.net/jdk17/pull/66/files

Re: RFR: 8268780: Use 'print_cr' instead of 'print' for the message 'eliminated '

2021-06-15 Thread Daniel D . Daugherty
On Tue, 15 Jun 2021 17:19:26 GMT, Denghui Dong wrote: > Hi, > > Cound I have a review of this small fix that adds a line feed for the message > 'eliminated '. > > When we run the following code and run `jstack ` > > > public static void main(String[] args) { > for (int i = 0; i <

[jdk17] Integrated: 8268723: Problem list SA core file tests on OSX when using ZGC

2021-06-15 Thread Chris Plummer
On Tue, 15 Jun 2021 02:42:09 GMT, Chris Plummer wrote: > See CR for details. I also relocated AdaptiveBlocking001.java in the list so > it is not mixed in with SA tests, and removed > serviceability/sa/TestHeapDumpForLargeArray.java since it was moved to the > resorucehogs directly long ago, a

Re: RFR: 8268780: Use 'print_cr' instead of 'print' for the message 'eliminated '

2021-06-15 Thread Zhengyu Gu
On Tue, 15 Jun 2021 17:19:26 GMT, Denghui Dong wrote: > Hi, > > Cound I have a review of this small fix that adds a line feed for the message > 'eliminated '. > > When we run the following code and run `jstack ` > > > public static void main(String[] args) { > for (int i = 0; i <

Re: RFR: 8268780: Use 'print_cr' instead of 'print' for the message 'eliminated '

2021-06-15 Thread Chris Plummer
On Tue, 15 Jun 2021 17:19:26 GMT, Denghui Dong wrote: > Hi, > > Cound I have a review of this small fix that adds a line feed for the message > 'eliminated '. > > When we run the following code and run `jstack ` > > > public static void main(String[] args) { > for (int i = 0; i <

RFR: 8268780: Use 'print_cr' instead of 'print' for the message 'eliminated '

2021-06-15 Thread Denghui Dong
Hi, Cound I have a review of this small fix that adds a line feed for the message 'eliminated '. When we run the following code and run `jstack ` public static void main(String[] args) { for (int i = 0; i < 2; i++) { try { test(); } c

Re: [jdk17] RFR: 8268723: Problem list SA core file tests on OSX when using ZGC

2021-06-15 Thread Chris Plummer
On Tue, 15 Jun 2021 16:08:51 GMT, Daniel D. Daugherty wrote: > I noticed that runtime/ErrorHandling/CreateCoredumpOnCrash.java is > not in this list. That's okay, but I think we've seen failures related to that > test also. Is that test going to be handled with a different bug? That test doesn'

Re: [jdk17] RFR: 8268723: Problem list SA core file tests on OSX when using ZGC

2021-06-15 Thread Serguei Spitsyn
On Tue, 15 Jun 2021 02:42:09 GMT, Chris Plummer wrote: > See CR for details. I also relocated AdaptiveBlocking001.java in the list so > it is not mixed in with SA tests, and removed > serviceability/sa/TestHeapDumpForLargeArray.java since it was moved to the > resorucehogs directly long ago, a

Re: [jdk17] RFR: 8268723: Problem list SA core file tests on OSX when using ZGC

2021-06-15 Thread Daniel D . Daugherty
On Tue, 15 Jun 2021 02:42:09 GMT, Chris Plummer wrote: > See CR for details. I also relocated AdaptiveBlocking001.java in the list so > it is not mixed in with SA tests, and removed > serviceability/sa/TestHeapDumpForLargeArray.java since it was moved to the > resorucehogs directly long ago, a

RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable

2021-06-15 Thread Сергей Цыпанов
In some JDK classes there's still the following hashCode() implementation: long objNum; public int hashCode() { return (int) objNum; } This outdated expression should be replaced with Long.hashCode(long) as it - uses all bits of the original value, does not discard any information upfront.