Re: RFR: 8256306: ObjectMonitor::_contentions field should not be 'jint'

2021-06-21 Thread Thomas Stuefe
On Tue, 11 May 2021 15:01:18 GMT, Coleen Phillimore wrote: > I changed the _contentions and _waiters fields from jint to int and ran tests > tier1-3. Tested tier1 with linux, mac, windows platforms. Also changed the > _previous_owner_tid to unintptr_t from jlong, since that's what the cast did

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v7]

2021-06-21 Thread Yi Yang
On Tue, 22 Jun 2021 02:39:01 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request incrementally

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v6]

2021-06-21 Thread Yi Yang
On Mon, 21 Jun 2021 20:49:56 GMT, Paul Sandoz wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more replacement 2 > > src/java.base/share/classes/jdk/internal/util/Preconditions.java line 78: > >> 76: = Prec

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v7]

2021-06-21 Thread Yi Yang
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. Yi Yang has updated the pull request incrementally with one additional commit since the last revision: corr

Re: RFR: 8268368: Adopt cast notation for JavaThread conversions

2021-06-21 Thread David Holmes
On Tue, 22 Jun 2021 01:11:30 GMT, Guoxiong Li wrote: > Hi all, > > Considering the consistency of `JavaThread` and other threads, such as > WorkerThread and CompilerThread, `JavaThread` could use a method named `cast` > to replace the method `Thread::as_Java_thread()`. It can reduce the Thread

RFR: 8268368: Adopt cast notation for JavaThread conversions

2021-06-21 Thread Guoxiong Li
Hi all, Considering the consistency of `JavaThread` and other threads, such as WorkerThread and CompilerThread, `JavaThread` could use a method named `cast` to replace the method `Thread::as_Java_thread()`. It can reduce the Thread's knowledge about the subtypes. This patch removes two methods

Re: RFR: 8256306: ObjectMonitor::_contentions field should not be 'jint'

2021-06-21 Thread David Holmes
On Tue, 11 May 2021 15:01:18 GMT, Coleen Phillimore wrote: > I changed the _contentions and _waiters fields from jint to int and ran tests > tier1-3. Tested tier1 with linux, mac, windows platforms. Also changed the > _previous_owner_tid to unintptr_t from jlong, since that's what the cast did

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v6]

2021-06-21 Thread Paul Sandoz
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request incrementally

Re: RFR: 8264941: Remove CodeCache::mark_for_evol_deoptimization() method

2021-06-21 Thread Serguei Spitsyn
On Wed, 16 Jun 2021 12:52:46 GMT, Coleen Phillimore wrote: > This change removes the mark_for_evol_deoptimization method and removes the > flag that all dependencies are recorded. Before the change to walk the > entire nmethod looking for "old" (redefined) methods with metadata_do(), we > use

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v2]

2021-06-21 Thread Volker Simonis
On Mon, 21 Jun 2021 12:26:20 GMT, Thomas Stuefe wrote: > _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on > [hotspot-runtime-dev](mailto:hotspot-runtime-...@mail.openjdk.java.net):_ > > On 21/06/2021 7:58 pm, Thomas Stuefe wrote: > > > On Mon, 21 Jun 2021 09:15:05 G

RFR: 8256306: ObjectMonitor::_contentions field should not be 'jint'

2021-06-21 Thread Coleen Phillimore
I changed the _contentions and _waiters fields from jint to int and ran tests tier1-3. Tested tier1 with linux, mac, windows platforms. Also changed the _previous_owner_tid to unintptr_t from jlong, since that's what the cast did. - Commit messages: - 8256306: ObjectMonitor::_cont

Re: RFR: 8264941: Remove CodeCache::mark_for_evol_deoptimization() method

2021-06-21 Thread Coleen Phillimore
On Wed, 16 Jun 2021 12:52:46 GMT, Coleen Phillimore wrote: > This change removes the mark_for_evol_deoptimization method and removes the > flag that all dependencies are recorded. Before the change to walk the > entire nmethod looking for "old" (redefined) methods with metadata_do(), we > use

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v2]

2021-06-21 Thread Thomas Stuefe
On Thu, 17 Jun 2021 08:53:55 GMT, Thomas Stuefe wrote: >> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in >> the VM process. >> >> >> The glibc is somewhat notorious for retaining released C Heap memory: >> calling free(3) returns memory to the glibc, and most lib

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v2]

2021-06-21 Thread David Holmes
On 21/06/2021 7:58 pm, Thomas Stuefe wrote: On Mon, 21 Jun 2021 09:15:05 GMT, Volker Simonis wrote: I like this little new diagnostic command which I think can be quite useful in specific situations. Thanks a lot Volker! However, in contrast to other reviewers, I'd rather keep this simpl

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v2]

2021-06-21 Thread Thomas Stuefe
On Mon, 21 Jun 2021 09:15:05 GMT, Volker Simonis wrote: > I like this little new diagnostic command which I think can be quite useful > in specific situations. > Thanks a lot Volker! > However, in contrast to other reviewers, I'd rather keep this simple and > Glibc specific instead of extend

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v2]

2021-06-21 Thread Volker Simonis
On Thu, 17 Jun 2021 08:53:55 GMT, Thomas Stuefe wrote: >> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in >> the VM process. >> >> >> The glibc is somewhat notorious for retaining released C Heap memory: >> calling free(3) returns memory to the glibc, and most lib

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v2]

2021-06-21 Thread Thomas Stuefe
On Thu, 17 Jun 2021 08:53:55 GMT, Thomas Stuefe wrote: >> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in >> the VM process. >> >> >> The glibc is somewhat notorious for retaining released C Heap memory: >> calling free(3) returns memory to the glibc, and most lib