Re: RFR: 8269886: Inaccurate error message for compressed hprof test [v2]

2021-07-05 Thread David Holmes
On Tue, 6 Jul 2021 06:32:12 GMT, Lin Zang wrote: >> The current implementation of hprof Reader for testing always prompts "Can >> not decompress the compressed hprof file" when there is error for testing >> gzipped heap dump. This is inaccurate if the gzipped file was decompressed >> successfu

Re: RFR: 8269886: Inaccurate error message for compressed hprof test

2021-07-05 Thread Lin Zang
On Tue, 6 Jul 2021 03:14:15 GMT, David Holmes wrote: >> The current implementation of hprof Reader for testing always prompts "Can >> not decompress the compressed hprof file" when there is error for testing >> gzipped heap dump. This is inaccurate if the gzipped file was decompressed >> succe

Re: RFR: 8269886: Inaccurate error message for compressed hprof test [v2]

2021-07-05 Thread Lin Zang
> The current implementation of hprof Reader for testing always prompts "Can > not decompress the compressed hprof file" when there is error for testing > gzipped heap dump. This is inaccurate if the gzipped file was decompressed > successfully but the hprof file format is incorrect. So the inac

Re: RFR: 8269886: Inaccurate error message for compressed hprof test

2021-07-05 Thread David Holmes
Hi Lin, On 6/07/2021 1:33 pm, Lin Zang wrote: On Tue, 6 Jul 2021 02:55:37 GMT, Lin Zang wrote: The current implementation of hprof Reader for testing always prompts "Can not decompress the compressed hprof file" when there is error for testing gzipped heap dump. This is inaccurate if the gz

Re: RFR: 8269886: Inaccurate error message for compressed hprof test

2021-07-05 Thread Lin Zang
On Tue, 6 Jul 2021 02:55:37 GMT, Lin Zang wrote: > The current implementation of hprof Reader for testing always prompts "Can > not decompress the compressed hprof file" when there is error for testing > gzipped heap dump. This is inaccurate if the gzipped file was decompressed > successfully

Re: RFR: 8268425: Show decimal nid of OSThread instead of hex format one [v5]

2021-07-05 Thread David Holmes
On 6/07/2021 1:25 pm, Yi Yang wrote: On Tue, 6 Jul 2021 03:08:42 GMT, David Holmes wrote: Yi Yang has updated the pull request incrementally with one additional commit since the last revision: use \p{XDigit} src/hotspot/share/runtime/osThread.cpp line 41: 39: // Printing 40: void OSTh

Re: RFR: 8268425: Show decimal nid of OSThread instead of hex format one [v5]

2021-07-05 Thread Yi Yang
On Tue, 6 Jul 2021 03:08:42 GMT, David Holmes wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use \p{XDigit} > > src/hotspot/share/runtime/osThread.cpp line 41: > >> 39: // Printing >> 40: void OSThread::print_on(outpu

Re: RFR: 8269886: Inaccurate error message for compressed hprof test

2021-07-05 Thread David Holmes
On Tue, 6 Jul 2021 02:55:37 GMT, Lin Zang wrote: > The current implementation of hprof Reader for testing always prompts "Can > not decompress the compressed hprof file" when there is error for testing > gzipped heap dump. This is inaccurate if the gzipped file was decompressed > successfully

Re: RFR: 8268425: Show decimal nid of OSThread instead of hex format one [v5]

2021-07-05 Thread David Holmes
On Wed, 30 Jun 2021 06:38:30 GMT, Yi Yang wrote: >> From users' perspective, we can find corresponding os thread via top >> directly, otherwise, we must convert hex format based nid to an integer, and >> find that thread via `top -pid `. This slightly facilitates our >> debugging process, but

RFR: 8269886: Inaccurate error message for compressed hprof test

2021-07-05 Thread Lin Zang
The current implementation of hprof Reader for testing always prompts "Can not decompress the compressed hprof file" when there is error for testing gzipped heap dump. This is inaccurate if the gzipped file was decompressed successfully but the hprof file format is incorrect. So the inaccurate e

Re: RFR: 8268425: Show decimal nid of OSThread instead of hex format one [v5]

2021-07-05 Thread Yi Yang
On Wed, 30 Jun 2021 06:38:30 GMT, Yi Yang wrote: >> From users' perspective, we can find corresponding os thread via top >> directly, otherwise, we must convert hex format based nid to an integer, and >> find that thread via `top -pid `. This slightly facilitates our >> debugging process, but

[jdk17] RFR: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field

2021-07-05 Thread Christoph Göttschkes
Hi, please review this small change for two Clhsdb test cases, which are using C2 specific fields during testing. This makes the tests fail, if C2 is not available during testing. - Commit messages: - 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v3]

2021-07-05 Thread Lin Zang
> This PR rewrite the implementation of the HeapHprofBinWriter, which could > simplify the logic of current implementation. > please see detail description at > https://bugs.openjdk.java.net/browse/JDK-8269685. Lin Zang has updated the pull request incrementally with one additional commit since

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v2]

2021-07-05 Thread Lin Zang
> This PR rewrite the implementation of the HeapHprofBinWriter, which could > simplify the logic of current implementation. > please see detail description at > https://bugs.openjdk.java.net/browse/JDK-8269685. Lin Zang has updated the pull request with a new target base due to a merge or a reb

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible

2021-07-05 Thread Yi Yang
On Mon, 5 Jul 2021 06:01:23 GMT, Yi Yang wrote: >> Class loading order is different to class initialization order. >> >> There are a lot more tests than just tier1. :) I don't expect many, if any, >> tests to be looking for a specific IOOBE message, and I can't see an easy >> way to find such