On 7/07/2021 2:37 pm, xpbob wrote:
On Wed, 7 Jul 2021 04:29:01 GMT, David Holmes wrote:
Why did you create a new PR ??
bug description changed。
update the commit info.
There was no reason to create a new PR.
David
-
PR: https://git.openjdk.java.net/jdk/pull/4702
On Wed, 7 Jul 2021 04:03:27 GMT, xpbob
wrote:
> …ocess cpu usage in containers
Hi Bob,
I am not a reviewer, just a tiny comments that you may need to remove the
unnecessary empty line. Thanks.
-Lin
src/jdk.management/unix/classes/com/sun/management/internal/OperatingSystemImpl.java
line
On Wed, 7 Jul 2021 04:29:01 GMT, David Holmes wrote:
> Why did you create a new PR ??
bug description changed。
update the commit info.
-
PR: https://git.openjdk.java.net/jdk/pull/4702
On Wed, 7 Jul 2021 01:11:00 GMT, xpbob
wrote:
> …ocess cpu usage inside a container
This has moved to https://github.com/openjdk/jdk/pull/4702
-
PR: https://git.openjdk.java.net/jdk/pull/4700
On Wed, 7 Jul 2021 04:03:27 GMT, xpbob
wrote:
> …ocess cpu usage in containers
Why did you create a new PR ??
-
PR: https://git.openjdk.java.net/jdk/pull/4702
On Wed, 7 Jul 2021 04:03:27 GMT, xpbob
wrote:
> …ocess cpu usage in containers
getProcessCpuLoad return jvm cpu load。
8 core in machine, set 1 core for container。
Run same program, the getProcessCpuLoad return the same value。
expected
same program run in machine,value 0.12
run in 1 core contai
…ocess cpu usage in containers
-
Commit messages:
- 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process
cpu usage in containers
Changes: https://git.openjdk.java.net/jdk/pull/4702/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4702&range=00
Is
On Wed, 7 Jul 2021 01:11:00 GMT, xpbob
wrote:
> …ocess cpu usage inside a container
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/4700
On Fri, 2 Jul 2021 21:57:23 GMT, Chris Plummer wrote:
> See the CR for details. This issue is causing a lot of failures related to
> some threads occasionally not being included in the jstack output, such as
> SteadyStateThread, Common-Cleaner, and "Signal Dispatcher". The bug caused SA
> to s
On Wed, 7 Jul 2021 02:39:10 GMT, Lin Zang wrote:
>> The current implementation of hprof Reader for testing always prompts "Can
>> not decompress the compressed hprof file" when there is error for testing
>> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
>> successfu
> The current implementation of hprof Reader for testing always prompts "Can
> not decompress the compressed hprof file" when there is error for testing
> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
> successfully but the hprof file format is incorrect. So the inac
On Wed, 7 Jul 2021 01:11:00 GMT, xpbob
wrote:
> …ocess cpu usage inside a container
@YaSuenag and @jerboaa could you please take a look at this one.
-
PR: https://git.openjdk.java.net/jdk/pull/4700
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with two additional commits
since the last revision:
- re
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with four additional commits
since the last revision:
- r
On Tue, 6 Jul 2021 19:06:43 GMT, Mandy Chung wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tests rely on IOOBE exception message
>
> test/jdk/java/lang/StringBuffer/Exceptions.java line 73:
>
>> 71: n
On Tue, 6 Jul 2021 03:14:15 GMT, David Holmes wrote:
>> The current implementation of hprof Reader for testing always prompts "Can
>> not decompress the compressed hprof file" when there is error for testing
>> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
>> succe
On Wed, 7 Jul 2021 01:11:00 GMT, xpbob
wrote:
> …ocess cpu usage inside a container
getProcessCpuLoad return jvm cpu load。
8 core in machine, set 1 core for container。
Run same program, the getProcessCpuLoad return the same value。
expected
same program run in machine,value 0.12
run in 1 core
On Thu, 10 Jun 2021 02:07:36 GMT, Yi Yang wrote:
> From users' perspective, we can find corresponding os thread via top
> directly, otherwise, we must convert hex format based nid to an integer, and
> find that thread via `top -pid `. This slightly facilitates our
> debugging process, but woul
…ocess cpu usage inside a container
-
Commit messages:
- 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process
cpu usage inside a container
Changes: https://git.openjdk.java.net/jdk/pull/4700/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4700&ran
On Wed, 7 Jul 2021 00:44:11 GMT, Lin Zang wrote:
>> The current implementation of hprof Reader for testing always prompts "Can
>> not decompress the compressed hprof file" when there is error for testing
>> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
>> successfu
On Tue, 6 Jul 2021 18:12:09 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> divid the try block
>
> After decompressing, no error or exception is thrown if MAGIC_NUMBER is not
> found. It just silen
> The current implementation of hprof Reader for testing always prompts "Can
> not decompress the compressed hprof file" when there is error for testing
> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
> successfully but the hprof file format is incorrect. So the inac
On Mon, 5 Jul 2021 12:16:22 GMT, Christoph Göttschkes wrote:
> Hi,
>
> please review this small change for two Clhsdb test cases, which are using C2
> specific fields during testing. This makes the tests fail, if C2 is not
> available during testing.
Marked as reviewed by sspitsyn (Reviewer).
On Mon, 5 Jul 2021 12:16:22 GMT, Christoph Göttschkes wrote:
> Hi,
>
> please review this small change for two Clhsdb test cases, which are using C2
> specific fields during testing. This makes the tests fail, if C2 is not
> available during testing.
Thanks for the reviews.
-
PR
On Mon, 5 Jul 2021 12:16:22 GMT, Christoph Göttschkes wrote:
> Hi,
>
> please review this small change for two Clhsdb test cases, which are using C2
> specific fields during testing. This makes the tests fail, if C2 is not
> available during testing.
Looks good.
-
Marked as revi
On Fri, 2 Jul 2021 21:57:23 GMT, Chris Plummer wrote:
> See the CR for details. This issue is causing a lot of failures related to
> some threads occasionally not being included in the jstack output, such as
> SteadyStateThread, Common-Cleaner, and "Signal Dispatcher". The bug caused SA
> to s
On Fri, 2 Jul 2021 21:57:23 GMT, Chris Plummer wrote:
> See the CR for details. This issue is causing a lot of failures related to
> some threads occasionally not being included in the jstack output, such as
> SteadyStateThread, Common-Cleaner, and "Signal Dispatcher". The bug caused SA
> to s
On Fri, 2 Jul 2021 21:23:39 GMT, Alex Menkov wrote:
> SocketIOPipe/IOPipe classes can select listening port by 2 ways:
> 1. caller specifies "-transport.address=dynamic" argument creating
> ArgumentHandler,
> and calls Binder.prepareForPipeConnection (actually see
> nsk.share.jpda.DebugeeBinder
On Fri, 2 Jul 2021 19:30:11 GMT, Alex Menkov wrote:
>> The change fixes several hundreds tests which launch debugee by using uses
>> Debugee.prepareDebugee() method or use
>> debugee = Binder.bindToDebugee(...);
>> IOPipe pipe = debugee.createIOPipe();
>> logic.
>> Debugee.prepareDebugee() and
On Wed, 23 Jun 2021 03:54:55 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
On Mon, 5 Jul 2021 06:29:58 GMT, David Holmes wrote:
>> @dholmes-ora @AlanBateman @PaulSandoz do you have any comments on the latest
>> version? Thanks.
>
> @kelthuzadx I did not see any response to my query about the change in
> initialization (not load) order. I also remain concerned about i
On Tue, 6 Jul 2021 07:59:25 GMT, Kevin Walls wrote:
> Much simpler!
Thank you Kevin!
Can I get one more review please?
-
PR: https://git.openjdk.java.net/jdk17/pull/206
On Tue, 6 Jul 2021 06:32:12 GMT, Lin Zang wrote:
>> The current implementation of hprof Reader for testing always prompts "Can
>> not decompress the compressed hprof file" when there is error for testing
>> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
>> successfu
On Mon, 5 Jul 2021 12:16:22 GMT, Christoph Göttschkes wrote:
> Hi,
>
> please review this small change for two Clhsdb test cases, which are using C2
> specific fields during testing. This makes the tests fail, if C2 is not
> available during testing.
Marked as reviewed by cjplummer (Reviewer)
On Tue, 6 Jul 2021 06:32:12 GMT, Lin Zang wrote:
>> The current implementation of hprof Reader for testing always prompts "Can
>> not decompress the compressed hprof file" when there is error for testing
>> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
>> successfu
On Sun, 6 Jun 2021 08:50:22 GMT, Anton Kozlov wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix windows flags (although complied fine)
>
> Thanks for the comments! Indeed, the change is about the "overwrite" opti
On Wed, 23 Jun 2021 12:06:41 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
> imple
On Fri, 2 Jul 2021 21:57:23 GMT, Chris Plummer wrote:
> See the CR for details. This issue is causing a lot of failures related to
> some threads occasionally not being included in the jstack output, such as
> SteadyStateThread, Common-Cleaner, and "Signal Dispatcher". The bug caused SA
> to s
On Tue, 6 Jul 2021 06:32:12 GMT, Lin Zang wrote:
>> The current implementation of hprof Reader for testing always prompts "Can
>> not decompress the compressed hprof file" when there is error for testing
>> gzipped heap dump. This is inaccurate if the gzipped file was decompressed
>> successfu
40 matches
Mail list logo
