Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v4]

2021-07-08 Thread Thomas Stuefe
> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in > the VM process. > > > The glibc is somewhat notorious for retaining released C Heap memory: calling > free(3) returns memory to the glibc, and most libc variants will return at > least a portion of it back to the

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v3]

2021-07-08 Thread Thomas Stuefe
On Fri, 25 Jun 2021 06:22:37 GMT, Thomas Stuefe wrote: >> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in >> the VM process. >> >> >> The glibc is somewhat notorious for retaining released C Heap memory: >> calling free(3) returns memory to the glibc, and most lib

Re: [jdk17] RFR: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec

2021-07-08 Thread Serguei Spitsyn
On Thu, 8 Jul 2021 19:11:45 GMT, Serguei Spitsyn wrote: > The fix of: >8252657 JVMTI agent is not unloaded when Agent_OnAttach is failed > did not update the JVM TI spec history at the end of document. > This PR adds missed item to the JVM TI spec history. Dan and Chris, thank you for quick

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-08 Thread Mandy Chung
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has refreshed the contents of this pull req

Re: [jdk17] RFR: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec

2021-07-08 Thread Chris Plummer
On Thu, 8 Jul 2021 19:11:45 GMT, Serguei Spitsyn wrote: > The fix of: >8252657 JVMTI agent is not unloaded when Agent_OnAttach is failed > did not update the JVM TI spec history at the end of document. > This PR adds missed item to the JVM TI spec history. Marked as reviewed by cjplummer (R

Re: [jdk17] RFR: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec

2021-07-08 Thread Daniel D . Daugherty
On Thu, 8 Jul 2021 19:11:45 GMT, Serguei Spitsyn wrote: > The fix of: >8252657 JVMTI agent is not unloaded when Agent_OnAttach is failed > did not update the JVM TI spec history at the end of document. > This PR adds missed item to the JVM TI spec history. Thumbs up. This looks like a trivi

Re: [jdk17] Integrated: 8270109: ProblemList 4 SA tests on macOS-aarch64

2021-07-08 Thread Daniel D . Daugherty
On Thu, 8 Jul 2021 19:21:20 GMT, Mikael Vidstedt wrote: >> A trivial fix to ProblemList 4 SA tests on macOS-aarch64 > > Marked as reviewed by mikael (Reviewer). @vidmik - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk17/pull/234

[jdk17] Integrated: 8270109: ProblemList 4 SA tests on macOS-aarch64

2021-07-08 Thread Daniel D . Daugherty
On Thu, 8 Jul 2021 19:17:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 4 SA tests on macOS-aarch64 This pull request has now been integrated. Changeset: 9acb2a69 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk17/commit/9acb2a69a9f80a6aeae38ce2bf1

[jdk17] Integrated: 8270109: ProblemList 4 SA tests on macOS-aarch64

2021-07-08 Thread Daniel D . Daugherty
A trivial fix to ProblemList 4 SA tests on macOS-aarch64 - Commit messages: - 8270109: ProblemList 4 SA tests on macOS-aarch64 Changes: https://git.openjdk.java.net/jdk17/pull/234/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=234&range=00 Issue: https://bugs.openj

Re: [jdk17] Integrated: 8270109: ProblemList 4 SA tests on macOS-aarch64

2021-07-08 Thread Mikael Vidstedt
On Thu, 8 Jul 2021 19:17:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 4 SA tests on macOS-aarch64 Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/234

[jdk17] RFR: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec

2021-07-08 Thread Serguei Spitsyn
The fix of: 8252657 JVMTI agent is not unloaded when Agent_OnAttach is failed did not update the JVM TI spec history at the end of document. This PR adds missed item to the JVM TI spec history. - Commit messages: - 8269558: fix of JDK-8252657 missed to update history at the end o

Integrated: 8269962: SA has unused Hashtable, Dictionary classes

2021-07-08 Thread Coleen Phillimore
On Wed, 7 Jul 2021 13:27:49 GMT, Coleen Phillimore wrote: > See bug for more details. This code is unused and is soon going to be not in > hotspot. > I left in logBytesPerWord() from my previous change because it might be > useful in the SA. I could remove it if opinion warrants. > Ran tier1-3

Re: RFR: 8269962: SA has unused Hashtable, Dictionary classes

2021-07-08 Thread Coleen Phillimore
On Wed, 7 Jul 2021 13:27:49 GMT, Coleen Phillimore wrote: > See bug for more details. This code is unused and is soon going to be not in > hotspot. > I left in logBytesPerWord() from my previous change because it might be > useful in the SA. I could remove it if opinion warrants. > Ran tier1-3

RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource

2021-07-08 Thread Lin Zang
8269909: getStack method in hprof.parser.Reader should use try-with-resource - Commit messages: - 8269909: getStack method in hprof.parser.Reader should use try-with-resource Changes: https://git.openjdk.java.net/jdk/pull/4717/files Webrev: https://webrevs.openjdk.java.net/?repo=jd