Re: RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers [v7]

2021-07-12 Thread xpbob
> …ocess cpu usage in containers xpbob has updated the pull request incrementally with one additional commit since the last revision: Set 1.0 for cpu set max - Changes: - all: https://git.openjdk.java.net/jdk/pull/4702/files - new:

Re: RFR: 8269470: Add truncation and compression information to EventHeapDump [v2]

2021-07-12 Thread Denghui Dong
On Mon, 28 Jun 2021 07:39:40 GMT, Denghui Dong wrote: >> Could I have a review of this change that adds the truncation and >> compression information to EventHeapDump? >> >> We occasionally receive feedback from users that the heap size parsed from >> the heap dump does not match the GC log.

Re: RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers [v6]

2021-07-12 Thread xpbob
> …ocess cpu usage in containers xpbob has updated the pull request incrementally with one additional commit since the last revision: Refactor process/system cpu load calculation - Changes: - all: https://git.openjdk.java.net/jdk/pull/4702/files - new:

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v2]

2021-07-12 Thread David Holmes
On Fri, 9 Jul 2021 08:21:21 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-12 Thread Yi Yang
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has refreshed the contents of this pull

Integrated: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base

2021-07-12 Thread Yi Yang
On Wed, 16 Jun 2021 08:08:47 GMT, Yi Yang wrote: > After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. This pull request has now been integrated. Changeset:

Re: RFR: 8270067: AArch64: several clhsdb tests fail with -Xcomp

2021-07-12 Thread Nick Gasson
On Mon, 12 Jul 2021 22:01:37 GMT, Chris Plummer wrote: > How did you even get the test to run without running into > [JDK-8270199](https://bugs.openjdk.java.net/browse/JDK-8270199) Linux not macOS. - PR: https://git.openjdk.java.net/jdk/pull/4737

Re: [jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run

2021-07-12 Thread David Holmes
On Mon, 12 Jul 2021 20:22:25 GMT, Anton Kozlov wrote: > The change adds W^X transition in RawMonitor family of functions, fixing the > crash. RawMonitor functions are treated specially, so W^X transition is not > inserted automatically. A better fix would be in .xml description for entries >

Re: [jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run

2021-07-12 Thread Serguei Spitsyn
On Mon, 12 Jul 2021 20:22:25 GMT, Anton Kozlov wrote: > The change adds W^X transition in RawMonitor family of functions, fixing the > crash. RawMonitor functions are treated specially, so W^X transition is not > inserted automatically. A better fix would be in .xml description for entries >

RFR: Merge jdk17

2021-07-12 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8266345: (fs) Custom DefaultFileSystemProvider security related loops - 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field - 8268965: TCP Connection Reset when connecting simple socket to SSL

Re: RFR: 8270067: AArch64: several clhsdb tests fail with -Xcomp

2021-07-12 Thread Chris Plummer
On Fri, 9 Jul 2021 08:37:00 GMT, Nick Gasson wrote: > Running the jtreg test serviceability/sa/ClhsdbWhere.java with -Xcomp > -XX:-TieredCompilation fails with the following exception: > > Error: java.lang.NullPointerException: Cannot invoke >

[jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run

2021-07-12 Thread Anton Kozlov
The change adds W^X transition in RawMonitor family of functions, fixing the crash. RawMonitor functions are treated specially, so W^X transition is not inserted automatically. A better fix would be in .xml description for entries generation, but for now it is too risky. I hope to get this

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-12 Thread Roger Riggs
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has refreshed the contents of this pull

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} for java.base [v11]

2021-07-12 Thread Mandy Chung
On Mon, 12 Jul 2021 05:21:34 GMT, Yi Yang wrote: > I'm not familiar with the review process of core-lib group. Is it sufficient > for merging with one approval? Should I have more reviews for this? 樂 It depends on the change. For this patch, it's good to get another reviewer to look through

Re: RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers [v4]

2021-07-12 Thread Severin Gehwolf
On Mon, 12 Jul 2021 03:46:23 GMT, xpbob wrote: > > Thanks for the update. `getProcessCpuLoad()` and `getCpuLoad()` looks way > > too similar to me. Is there a way to make them more generic and do the > > process vs. system paths as needed? I think there is. > > use getCpuLoadWithTarget for

[jdk17] Integrated: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field

2021-07-12 Thread Christoph Göttschkes
On Mon, 5 Jul 2021 12:16:22 GMT, Christoph Göttschkes wrote: > Hi, > > please review this small change for two Clhsdb test cases, which are using C2 > specific fields during testing. This makes the tests fail, if C2 is not > available during testing. This pull request has now been

Integrated: 8267666: Add option to jcmd GC.heap_dump to use existing file

2021-07-12 Thread Anton Kozlov
On Tue, 25 May 2021 11:23:33 GMT, Anton Kozlov wrote: > Please review a small change that adds an option to GC.heap_dump to use an > existing file. > > The option is necessary if the target file is a predefined file-like object, > like a named pipe. This opens up a lot of possibilities to

Re: [jdk17] RFR: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field

2021-07-12 Thread Christoph Göttschkes
On Mon, 5 Jul 2021 12:16:22 GMT, Christoph Göttschkes wrote: > Hi, > > please review this small change for two Clhsdb test cases, which are using C2 > specific fields during testing. This makes the tests fail, if C2 is not > available during testing. Could someone please sponsor this change